Completed
Pull Request — master (#29319)
by Jörn Friedrich
19:20 queued 06:03
created
lib/private/legacy/template/functions.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -191,6 +191,7 @@
 block discarded – undo
191 191
 
192 192
 /**
193 193
  * @param string $path
194
+ * @param string $token
194 195
  */
195 196
 function publicPreview_icon ( $path, $token ) {
196 197
 	return \OC::$server->getURLGenerator()->linkToRoute('core_ajax_public_preview', ['x' => 32, 'y' => 32, 'file' => $path, 't' => $token]);
Please login to merge, or discard this patch.
lib/private/Preview/Movie.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -81,8 +81,8 @@  discard block
 block discarded – undo
81 81
 	}
82 82
 
83 83
 	/**
84
-	 * @param $absPath
85
-	 * @return bool|string
84
+	 * @param string $absPath
85
+	 * @return false|string
86 86
 	 */
87 87
 	private function extractMp4CoverArtwork($absPath) {
88 88
 		if (isset($this->noArtworkIndex[$absPath])) {
@@ -118,9 +118,9 @@  discard block
 block discarded – undo
118 118
 	}
119 119
 
120 120
 	/**
121
-	 * @param $absPath
122
-	 * @param $second
123
-	 * @return bool|string
121
+	 * @param string $absPath
122
+	 * @param integer $second
123
+	 * @return string|false
124 124
 	 */
125 125
 	private function generateFromMovie($absPath, $second) {
126 126
 		$tmpPath = \OC::$server->getTempManager()->getTemporaryFile();
Please login to merge, or discard this patch.
lib/private/Files/Node/Root.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -174,7 +174,7 @@  discard block
 block discarded – undo
174 174
 	 * @param string $path
175 175
 	 * @throws \OCP\Files\NotFoundException
176 176
 	 * @throws \OCP\Files\NotPermittedException
177
-	 * @return File|Folder
177
+	 * @return string
178 178
 	 */
179 179
 	public function get($path) {
180 180
 		$path = $this->normalizePath($path);
@@ -371,6 +371,9 @@  discard block
 block discarded – undo
371 371
 
372 372
 	}
373 373
 
374
+	/**
375
+	 * @param string $fullPath
376
+	 */
374 377
 	private function resolveVirtualNode($fullPath) {
375 378
 		$pieces = explode('/', $fullPath);
376 379
 		if ($pieces[1] !== 'meta') {
Please login to merge, or discard this patch.
lib/private/Preview.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -920,7 +920,7 @@  discard block
 block discarded – undo
920 920
 	 * @param int $previewWidth
921 921
 	 * @param int $previewHeight
922 922
 	 *
923
-	 * @return int[]
923
+	 * @return double[]
924 924
 	 */
925 925
 	private function scale($image, $askedWidth, $askedHeight, $previewWidth, $previewHeight) {
926 926
 		$scalingUp = $this->getScalingUp();
@@ -1083,6 +1083,7 @@  discard block
 block discarded – undo
1083 1083
 	/**
1084 1084
 	 * Returns the path to the folder where the previews are stored, identified by the fileId
1085 1085
 	 *
1086
+	 * @param integer $fileId
1086 1087
 	 * @return string
1087 1088
 	 */
1088 1089
 	private function getPreviewPath($fileId = null) {
Please login to merge, or discard this patch.