owncloud / calendar

businesslayer/subscription.php

Unused Use Statements -1 removed lines

@@ -25,7 +25,6 @@
 use OCA\Calendar\IBackendCollection;
 use OCP\AppFramework\Db\DoesNotExistException;
 use OCP\AppFramework\Db\MultipleObjectsReturnedException;
-use OCP\AppFramework\Http;
 use OCA\Calendar\ISubscription;
 use OCA\Calendar\Backend as BackendUtils;
 

db/collection.php

Doc Comments +8 added lines, -8 removed lines

@@ -98,7 +98,7 @@ 
 	 * @param ICollection $collection collection of entities to be added
 	 * @param integer $nth insert at index, if not set, collection will be appended
 	 *        if negative, it will be inserted at the position that many elements from the end
-	 * @return integer
+	 * @return Collection
 	 */
 	public function addCollection(ICollection $collection, $nth=null) {
 		return $this->addObjects($collection->getObjects(), $nth);
@@ -111,7 +111,7 @@ 
 	 * @param array $array
 	 * @param integer $nth insert at index, if not set, objects will be appended
 	 *        if negative, it will be inserted at the position that many elements from the end
-	 * @return integer
+	 * @return Collection
 	 */
 	public function addObjects(array $array, $nth=null) {
 		if ($nth === null) {
@@ -138,7 +138,7 @@ 
 	/**
 	 * set objects
 	 *
-	 * @param array $objects
+	 * @param TestEntity[] $objects
 	 * @return $this
 	 */
 	public function setObjects(array $objects) {
@@ -152,7 +152,7 @@ 
 	 *
 	 * @param integer $limit
 	 * @param integer $offset
-	 * @return array of Entities
+	 * @return ICollection of Entities
 	 */
 	public function subset($limit=null, $offset=null) {
 		/** @var ICollection $instance */
@@ -187,8 +187,8 @@ 
 	 * get a collection of entities that meet criteria
 	 *
 	 * @param string $key property that's supposed to be searched
-	 * @param mixed $value expected value, can be a regular expression when 3rd param is set to true
-	 * @return mixed (boolean|ICollection)
+	 * @param boolean|string $value expected value, can be a regular expression when 3rd param is set to true
+	 * @return Collection (boolean|ICollection)
 	 */
 	public function search($key, $value) {
 		$collection = new static();
@@ -277,7 +277,7 @@ 
 
 
 	/**
-	 * @param mixed $offset
+	 * @param integer $offset
 	 * @param mixed $value
 	 */
 	public function offsetSet($offset, $value){
@@ -293,7 +293,7 @@ 
 
 
 	/**
-	 * @param mixed $offset
+	 * @param integer $offset
 	 */
 	public function offsetUnset($offset) {
 		unset($this->objects[$offset]);

tests/unit/db/collectionTest.php

Doc Comments +4 added lines

@@ -27,6 +27,10 @@
 
 class TestEntity extends Entity {
 	private $name;
+
+	/**
+	 * @param string $name
+	 */
 	public function __construct($name)
 	{
 		$this->name = $name;