Completed
Push — master ( 42947c...112211 )
by
unknown
02:28
created
controller/lib/bookmarks.php 1 patch
Doc Comments   +11 added lines, -6 removed lines patch added patch discarded remove patch
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
 
86 86
 	/**
87 87
 	 * @brief Check if an URL is bookmarked
88
-	 * @param $url Url of a possible bookmark
88
+	 * @param string $url Url of a possible bookmark
89 89
 	 * @param $userId UserId
90 90
 	 * @param IDb $db Database Interface
91 91
 	 * @return boolean if the url is already bookmarked
@@ -187,6 +187,11 @@  discard block
 block discarded – undo
187 187
 		return $bookmarks;
188 188
 	}
189 189
 
190
+	/**
191
+	 * @param string $sql
192
+	 * @param boolean $filterTagOnly
193
+	 * @param string $tagFilterConjunction
194
+	 */
190 195
 	private static function findBookmarksBuildFilter(&$sql, &$params, $filters, $filterTagOnly, $tagFilterConjunction, $CONFIG_DBTYPE) {
191 196
 		$tagOrSearch = false;
192 197
 		$connectWord = 'AND';
@@ -231,7 +236,7 @@  discard block
 block discarded – undo
231 236
 	 * @brief Delete bookmark with specific id
232 237
 	 * @param $userId UserId
233 238
 	 * @param IDb $db Database Interface
234
-	 * @param $id Bookmark ID to delete
239
+	 * @param integer $id Bookmark ID to delete
235 240
 	 * @return boolean Success of operation
236 241
 	 */
237 242
 	public static function deleteUrl($userId, IDb $db, $id) {
@@ -371,7 +376,7 @@  discard block
 block discarded – undo
371 376
 	 * @param array $tags Simple array of tags to qualify the bookmark (different tags are taken from values)
372 377
 	 * @param string $description A longer description about the bookmark
373 378
 	 * @param boolean $is_public True if the bookmark is publishable to not registered users
374
-	 * @return null
379
+	 * @return null|integer
375 380
 	 */
376 381
 	public static function editBookmark($userid, IDb $db, $id, $url, $title, $tags = array(), $description = '', $is_public = false) {
377 382
 
@@ -423,7 +428,7 @@  discard block
 block discarded – undo
423 428
 	 * @param string $title Name of the bookmark
424 429
 	 * @param array $tags Simple array of tags to qualify the bookmark (different tags are taken from values)
425 430
 	 * @param string $description A longer description about the bookmark
426
-	 * @param boolean $public True if the bookmark is publishable to not registered users
431
+	 * @param boolean $is_public True if the bookmark is publishable to not registered users
427 432
 	 * @return int The id of the bookmark created
428 433
 	 */
429 434
 	public static function addBookmark($userid, IDb $db, $url, $title, $tags = array(), $description = '', $is_public = false) {
@@ -543,7 +548,7 @@  discard block
 block discarded – undo
543 548
 
544 549
 	/**
545 550
 	 * @brief Load Url and receive Metadata (Title)
546
-	 * @param $url Url to load and analyze
551
+	 * @param string $url Url to load and analyze
547 552
 	 * @return array Metadata for url;
548 553
 	 * */
549 554
 	public static function getURLMetadata($url) {
@@ -587,7 +592,7 @@  discard block
 block discarded – undo
587 592
 
588 593
 	/**
589 594
 	 * @brief Seperate Url String at comma charachter
590
-	 * @param $line String of Tags
595
+	 * @param string $line String of Tags
591 596
 	 * @return array Array of Tags
592 597
 	 * */
593 598
 	public static function analyzeTagRequest($line) {
Please login to merge, or discard this patch.
controller/rest/bookmarkcontroller.php 1 patch
Doc Comments   -2 removed lines patch added patch discarded remove patch
@@ -155,7 +155,6 @@  discard block
 block discarded – undo
155 155
 	  @NoAdminRequired
156 156
 	 * 
157 157
 	 * @param int $id
158
-	 * @param bool $is_public Description
159 158
 	 * @return \OCP\AppFramework\Http\JSONResponse
160 159
 	 */
161 160
 	public function legacyDeleteBookmark($id = -1) {
@@ -166,7 +165,6 @@  discard block
 block discarded – undo
166 165
 	  @NoAdminRequired
167 166
 	 * 
168 167
 	 * @param int $id
169
-	 * @param bool $is_public Description
170 168
 	 * @return \OCP\AppFramework\Http\JSONResponse
171 169
 	 */
172 170
 	public function deleteBookmark($id = -1) {
Please login to merge, or discard this patch.