ovr / phpsa

src/Definition/ClosureDefinition.php

<?php
/**
 * @author Patsura Dmitry https://github.com/ovr <talk@dmtry.me>
 */

namespace PHPSA\Definition;

use PHPSA\CompiledExpression;
use PHPSA\Compiler\SymbolTable;
use PHPSA\Context;
use PhpParser\Node;
use PHPSA\Compiler\Parameter;
use PHPSA\Compiler\Types;
use PHPSA\Variable;

/**
 * Closure Definition
 *
 * @package PHPSA\Definition
 */
class ClosureDefinition extends ParentDefinition
{
    /**
     * @todo Use Finder
     *
     * @var string
     */
    protected $filepath;

    /**
     * @var Node\Expr\Closure
     */
    protected $statement;

    /**
     * @var int
     */
    protected $returnTypes = CompiledExpression::MIXED;

    /**
     * @var array
     */
    protected $possibleReturnTypes = [];

    /**
     * @var SymbolTable
     */
    protected $symbolTable;

    /**
     * @param Node\Expr\Closure $statement
     */
    public function __construct(Node\Expr\Closure $statement)
    {
        $this->symbolTable = new SymbolTable();
        $this->statement = $statement;
    }

    /**
     * @param Context $context
     */
    public function preCompile(Context $context)
    {
        if ($this->statement->uses) {

The expression $this->statement->uses of type PhpParser\Node\Expr\ClosureUse[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            /**
             * Store variables from User to next restore Context
             */
            foreach ($this->statement->uses as $variable) {
                $variable = $context->getSymbol($variable->var);

Are you sure the assignment to $variable is correct as $context->getSymbol($variable->var) (which targets PHPSA\Context::getSymbol()) seems to always return null.

                if ($variable) {
                    $variable->incGets();

                    $this->symbolTable->add(clone $variable);
                }
            }
        }
    }

    /**
     * Compile function to check it
     *
     * @param Context $context
     * @return bool
     */
    public function compile(Context $context)

This operation has 576 execution paths which exceeds the configured maximum of 200.

    {
        if ($this->compiled) {
            return true;
        }

        $context->setFilepath($this->filepath);
        $this->compiled = true;

        $context->clearSymbols();

        // @todo rewrite when we will use symbol table in all places!
        foreach ($this->symbolTable->getVariables() as $variable) {
            $context->addVariable($variable);
        }

        if ($context->scopePointer) {
            if ($context->scopePointer->isClassMethod()) {
                /** @var \PHPSA\Definition\ClassMethod $method */
                $method = $context->scopePointer->getObject();

                if (!$method->isStatic()) {
                    $thisPtr = new Variable('this', $this, CompiledExpression::OBJECT);
                    $thisPtr->incGets();

                    $this->symbolTable->add($thisPtr);
                    $context->addVariable($thisPtr);
                }
            } elseif ($context->scopePointer->isClosure()) {
                /** @var \PHPSA\Definition\ClosureDefinition $closure */
                $closure = $context->scopePointer->getObject();

                $thisPtr = $closure->getSymbolTable()->get('this');
                if ($thisPtr) {
                    $thisPtr->incGets();
                    $context->addVariable($thisPtr);
                }
            }
        }

        $context->scopePointer = $this->getPointer();
        $context->setScope(null);

        if (count($this->statement->stmts) == 0) {
            return $context->notice(
                'not-implemented-function',
                sprintf('Closure %s() is not implemented', $this->name),
                $this->statement
            );
        }

        if (count($this->statement->params) > 0) {
            /** @var  Node\Param $parameter */
            foreach ($this->statement->params as $parameter) {
                $type = CompiledExpression::UNKNOWN;

                if ($parameter->type) {
                    if (is_string($parameter->type)) {
                        $type = Types::getType($parameter->type);
                    } elseif ($parameter->type instanceof Node\Name) {
                        $type = CompiledExpression::OBJECT;
                    }
                }

                $context->addVariable(
                    new Parameter($parameter->name, null, $type, $parameter->byRef)
                );
            }
        }

        foreach ($this->statement->stmts as $st) {
            \PHPSA\nodeVisitorFactory($st, $context);
        }

        return true;
    }

    /**
     * @param CompiledExpression[] $arguments
     * @param Context $context
     * @return CompiledExpression
     */
    public function run(array $arguments, Context $context)

The parameter $arguments is not used and could be removed.

The parameter $context is not used and could be removed.

    {
        return new CompiledExpression();
    }

    /**
     * @return string
     */
    public function getFilepath()
    {
        return $this->filepath;
    }

    /**
     * @param string $filepath
     */
    public function setFilepath($filepath)
    {
        $this->filepath = $filepath;
    }

    /**
     * @return string
     */
    public function getNamespace()
    {
        return $this->namespace;
    }

    /**
     * @return SymbolTable
     */
    public function getSymbolTable()
    {
        return $this->symbolTable;
    }
}