Issues in StaticCall.php (master) - Issues in master - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Issues (132)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Compiler/Expression/StaticCall.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * PHP Smart Analysis project 2015-2016
 *
 * @author Patsura Dmitry https://github.com/ovr <[email protected]>
 */

namespace PHPSA\Compiler\Expression;

use PHPSA\CompiledExpression;
use PHPSA\Context;
use PHPSA\Definition\ClassDefinition;

class StaticCall extends AbstractExpressionCompiler
{
    protected $name = 'PhpParser\Node\Expr\StaticCall';

    /**
     * {expr}::{expr}();
     *
     * @param \PhpParser\Node\Expr\StaticCall $expr
     * @param Context $context
     * @return CompiledExpression
     */
    protected function compile($expr, Context $context)
    {
        $expressionCompiler = $context->getExpressionCompiler();
        $leftCE = $expressionCompiler->compile($expr->class);
        $rightCE = $expressionCompiler->compile($expr->name);

        $this->parseArgs($expr->args, $context);

        if ($leftCE->isObject() && $rightCE->isString() && $rightCE->isCorrectValue()) {
            /** @var ClassDefinition|null $classDefinition */
            $classDefinition = $leftCE->getValue();
            if ($classDefinition instanceof ClassDefinition) {
                $name = $rightCE->getValue();

                if (!$classDefinition->hasMethod($name, true)) {
                    $context->notice(
                        'language_error',
                        sprintf('Static method %s() does not exist in %s scope', $name, $expr->class),
                        $expr
                    );

                    return new CompiledExpression();
                }

                $method = $classDefinition->getMethod($name, true);
                if ($expr->class->toString() !== 'parent' && !$method->isStatic()) {
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
                    $context->notice(
                        'language_error',
                        sprintf('Method %s() is not static but was called in a static way', $name),
                        $expr
                    );
                }
            }

            return new CompiledExpression();
        }

        $context->debug('Unknown static function call', $expr);
        return new CompiledExpression();
    }


    /**
     * @param \PhpParser\Node\Arg[] $arguments
     * @param Context $context
     * @return CompiledExpression[]
     */
    protected function parseArgs(array $arguments, Context $context)
    {
        $compiled = [];

        if ($arguments) {

            foreach ($arguments as $argument) {
                $compiled[] = $context->getExpressionCompiler()->compile($argument->value);
            }
        }

        return $compiled;
    }
}


1			<?php
2			/**
3			* PHP Smart Analysis project 2015-2016
4			*
5			* @author Patsura Dmitry https://github.com/ovr <[email protected]>
6			*/
7
8			namespace PHPSA\Compiler\Expression;
9
10			use PHPSA\CompiledExpression;
11			use PHPSA\Context;
12			use PHPSA\Definition\ClassDefinition;
13
14			class StaticCall extends AbstractExpressionCompiler
15			{
16			protected $name = 'PhpParser\Node\Expr\StaticCall';
17
18			/**
19			* {expr}::{expr}();
20			*
21			* @param \PhpParser\Node\Expr\StaticCall $expr
22			* @param Context $context
23			* @return CompiledExpression
24			*/
25			protected function compile($expr, Context $context)
26			{
27			$expressionCompiler = $context->getExpressionCompiler();
28			$leftCE = $expressionCompiler->compile($expr->class);
29			$rightCE = $expressionCompiler->compile($expr->name);
30
31			$this->parseArgs($expr->args, $context);
32
33			if ($leftCE->isObject() && $rightCE->isString() && $rightCE->isCorrectValue()) {
34			/** @var ClassDefinition\|null $classDefinition */
35			$classDefinition = $leftCE->getValue();
36			if ($classDefinition instanceof ClassDefinition) {
37			$name = $rightCE->getValue();
38
39			if (!$classDefinition->hasMethod($name, true)) {
40			$context->notice(
41			'language_error',
42			sprintf('Static method %s() does not exist in %s scope', $name, $expr->class),
43			$expr
44			);
45
46			return new CompiledExpression();
47			}
48
49			$method = $classDefinition->getMethod($name, true);
50			if ($expr->class->toString() !== 'parent' && !$method->isStatic()) {
			0 ignored issues – show Bug introduced 2016-12-29 10:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `toString` does only exist in `PhpParser\Node\Name`, but not in `PhpParser\Node\Expr`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
51			$context->notice(
52			'language_error',
53			sprintf('Method %s() is not static but was called in a static way', $name),
54			$expr
55			);
56			}
57			}
58
59			return new CompiledExpression();
60			}
61
62			$context->debug('Unknown static function call', $expr);
63			return new CompiledExpression();
64			}
65
66
67			/**
68			* @param \PhpParser\Node\Arg[] $arguments
69			* @param Context $context
70			* @return CompiledExpression[]
71			*/
72			protected function parseArgs(array $arguments, Context $context)
73			{
74			$compiled = [];
75
76			if ($arguments) {
			0 ignored issues – show Bug Best Practice introduced 2016-12-07 05:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$arguments` of type `PhpParser\Node\Arg[]` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
77			foreach ($arguments as $argument) {
78			$compiled[] = $context->getExpressionCompiler()->compile($argument->value);
79			}
80			}
81
82			return $compiled;
83			}
84			}
85

ovr / phpsa

Issues (132)

Security Analysis no request data

src/Compiler/Expression/StaticCall.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like