ovr / phpsa

src/Command/CompileCommand.php

<?php

namespace PHPSA\Command;

use PhpParser\ParserFactory;
use PHPSA\Application;
use PHPSA\Compiler;
use PHPSA\Context;
use PHPSA\Definition\FileParser;
use RecursiveDirectoryIterator;
use RecursiveIteratorIterator;
use SplFileInfo;
use FilesystemIterator;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;
use Webiny\Component\EventManager\EventManager;

/**
 * Command to run compiler on files (no analyzer)
 */
class CompileCommand extends AbstractCommand
{
    /**
     * {@inheritdoc}
     */
    protected function configure()
    {
        $this
            ->setName('compile')
            ->setDescription('Runs compiler on all files in path')
            ->addOption('config-file', null, InputOption::VALUE_REQUIRED, 'Path to the configuration file.')
            ->addArgument('path', InputArgument::OPTIONAL, 'Path to check file or directory', '.');
    }

    /**
     * {@inheritdoc}
     */
    protected function execute(InputInterface $input, OutputInterface $output)

This operation has 3030 execution paths which exceeds the configured maximum of 200.

    {
        $output->writeln('');

        if (extension_loaded('xdebug')) {
            /**
             * This will disable only showing stack traces on error conditions.
             */
            if (function_exists('xdebug_disable')) {
                xdebug_disable();
            }

            $output->writeln('<error>It is highly recommended to disable the XDebug extension before invoking this command.</error>');
        }

        /** @var Application $application */
        $application = $this->getApplication();
        $application->compiler = new Compiler();

        $configFile = $input->getOption('config-file') ?: '.phpsa.yml';
        $configDir = realpath($input->getArgument('path'));
        $application->configuration = $this->loadConfiguration($configFile, $configDir);

        $parser = $this->createParser($application);

$application is of type object<PHPSA\Application>, but the function expects a string.

        $output->writeln('Used config file: ' . $application->configuration->getPath());

        $em = EventManager::getInstance();

Avoid variables with short names like $em. Configured minimum length is 3.

        $context = new Context($output, $application, $em);

        $fileParser = new FileParser(
            $parser,
            $application->compiler
        );

        $path = $input->getArgument('path');
        if (is_dir($path)) {
            $directoryIterator = new RecursiveIteratorIterator(
                new RecursiveDirectoryIterator($path, FilesystemIterator::SKIP_DOTS)
            );
            $output->writeln('Scanning directory <info>' . $path . '</info>');

            $count = 0;

            $ignore =  $application->configuration->getValue('ignore');
            /** @var SplFileInfo $file */
            foreach ($directoryIterator as $file) {
                $skip = 0;
                foreach ($ignore as $item) {
                    $item = preg_replace('#/+#', '/', ($path . $item));

                    if (preg_match("#$item#", $file->getPathname())) {
                        $skip = 1;
                        break;
                    }
                }

                if ($file->getExtension() !== 'php' || $skip) {
                    continue;
                }

                $context->debug($file->getPathname());
                $count++;
            }

            $output->writeln("Found <info>{$count} files</info>");

            if ($count > 100) {
                $output->writeln('<comment>Caution: You are trying to scan a lot of files; this might be slow. For bigger libraries, consider setting up a dedicated platform or using ci.lowl.io.</comment>');
            }

            $output->writeln('');

            /** @var SplFileInfo $file */
            foreach ($directoryIterator as $file) {
                $skip = 0;
                foreach ($ignore as $item) {
                    $item = preg_replace('#/+#', '/', ($path . $item));

                    if (preg_match("#$item#", $file->getPathname())) {
                        $skip = 1;
                        break;
                    }
                }

                if ($file->getExtension() !== 'php' || $skip) {
                    continue;
                }

                $fileParser->parserFile($file->getPathname(), $context);
            }
        } elseif (is_file($path)) {
            $fileParser->parserFile($path, $context);

It seems like $path defined by $input->getArgument('path') on line 75 can also be of type array<integer,string> or null; however, PHPSA\Definition\FileParser::parserFile() does only seem to accept string, maybe add an additional type check?

        }


        /**
         * Step 2 Recursive check ...
         */
        $application->compiler->compile($context);

        $output->writeln('');
        $output->writeln('Memory usage: ' . $this->getMemoryUsage(false) . ' (peak: ' . $this->getMemoryUsage(true) . ') MB');
    }
}