PHPSA\Analyzer\Pass\Expression\FunctionCall\DeprecatedIniOptions

Complexity

Total Complexity

7

Size/Duplication

Total Lines	66
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

100%

Importance

Changes	4
Bugs	0	Features	3

1 Method

Rating	Name	Duplication	Size	Complexity
C	pass()	0	22	7

<?php
/**
 * @author Patsura Dmitry https://github.com/ovr <talk@dmtry.me>
 */

namespace PHPSA\Analyzer\Pass\Expression\FunctionCall;

use PhpParser\Node\Expr\FuncCall;
use PHPSA\Compiler\Expression;
use PHPSA\Context;

class DeprecatedIniOptions extends AbstractFunctionCallAnalyzer
{
    static protected $functions = array(
        'ini_set' => 'ini_set',
        'ini_get' => 'ini_get',
        'ini_alter' => 'ini_alter',
        'ini_restore' => 'ini_restore'
    );

    static protected $deprecatedOptions = array(
        'asp_tags' => 'is a deprecated option since PHP 7.0.0',
        'always_populate_raw_post_data' => 'is a deprecated option since PHP 7.0.0',
        //
        'iconv.input_encoding' => 'is a deprecated option since PHP 5.6.0. Use \'default_charset\' instead',
        'iconv.output_encoding' => 'is a deprecated option since PHP 5.6.0. Use \'default_charset\' instead',
        'iconv.internal_encoding' => 'is a deprecated option since PHP 5.6.0. Use \'default_charset\' instead',
        'mbstring.http_input' => 'is a deprecated option since PHP 5.6.0. Use \'default_charset\' instead',
        'mbstring.http_output' => 'is a deprecated option since PHP 5.6.0. Use \'default_charset\' instead',
        'mbstring.internal_encoding' => 'is a deprecated option since PHP 5.6.0. Use \'default_charset\' instead',
        //
        'xsl.security_prefs' => 'is a deprecated option since PHP 5.4.0 (removed in PHP 7.0.0). Use XsltProcessor->setSecurityPrefs() instead',
        //
        'allow_call_time_pass_reference' => 'is a deprecated option since PHP 5.4.0',
        'highlight.bg' => 'is a deprecated option since PHP 5.4.0',
        'zend.ze1_compatibility_mode' => 'is a deprecated option since PHP 5.4.0',
        'session.bug_compat_42' => 'is a deprecated option since PHP 5.4.0',
        'session.bug_compat_warn' => 'is a deprecated option since PHP 5.4.0',
        'y2k_compliance' => 'is a deprecated option since PHP 5.4.0',
        //
        'define_syslog_variables' => 'is a deprecated option since PHP 5.3.0 (removed in PHP 5.4.0)',
        'magic_quotes_gpc' => 'is a deprecated option since PHP 5.3.0 (removed in PHP 5.4.0)',
        'magic_quotes_runtime' => 'is a deprecated option since PHP 5.3.0 (removed in PHP 5.4.0)',
        'magic_quotes_sybase' => 'is a deprecated option since PHP 5.3.0 (removed in PHP 5.4.0)',
        'register_globals' => 'is a deprecated option since PHP 5.3.0 (removed in PHP 5.4.0)',
        'register_long_arrays' => 'is a deprecated option since PHP 5.3.0 (removed in PHP 5.4.0)',
        'safe_mode' => 'is a deprecated option since PHP 5.3.0 (removed in PHP 5.4.0)',
        'safe_mode_gid' => 'is a deprecated option since PHP 5.3.0 (removed in PHP 5.4.0)',
        'safe_mode_include_dir' => 'is a deprecated option since PHP 5.3.0 (removed in PHP 5.4.0)',
        'safe_mode_exec_dir' => 'is a deprecated option since PHP 5.3.0 (removed in PHP 5.4.0)',
        'safe_mode_allowed_env_vars' => 'is a deprecated option since PHP 5.3.0 (removed in PHP 5.4.0)',
        'safe_mode_protected_env_vars' => 'is a deprecated option since PHP 5.3.0 (removed in PHP 5.4.0)'
    );

    public function pass(FuncCall $funcCall, Context $context)
    {
        $functionName = $this->resolveFunctionName($funcCall, $context);
        if ($functionName && isset(self::$functions[$functionName])) {
            if ($funcCall->args) {

The expression $funcCall->args of type PhpParser\Node\Arg[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

                $compiledOptionName = $context->getExpressionCompiler()->compile($funcCall->args[0]);
                if ($compiledOptionName->isString() && $compiledOptionName->isCorrectValue()) {
                    if (isset(self::$deprecatedOptions[$compiledOptionName->getValue()])) {
                        $context->notice(
                            'deprecated.option',
                            sprintf(
                                'Ini option %s %s.',
                                $compiledOptionName->getValue(),
                                self::$deprecatedOptions[$compiledOptionName->getValue()]
                            ),
                            $funcCall
                        );
                    }
                }
            }
        }
    }
}