ArrayDimFetch::compile() - Code Metrics - Inspection of "Merge pull request #324 from algo13/issue_307_311" - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e1144e...7e8850 )

by Enrico

created 2017-02-23 17:57 UTC

ArrayDimFetch::compile() D

↳ Parent: ArrayDimFetch

Complexity

Conditions	10
Paths	7

Size

Total Lines	37
Code Lines	24

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	110

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
cc	10
eloc	24
nc	7
nop	2
dl	0
loc	37
ccs	0
cts	27
cp	0
crap	110
rs	4.8196
c	2
b	0
f	1

How to fix Complexity

<?php

namespace PHPSA\Compiler\Expression;

use PHPSA\CompiledExpression;
use PHPSA\Context;

class ArrayDimFetch extends AbstractExpressionCompiler
{
    protected $name = 'PhpParser\Node\Expr\ArrayDimFetch';

    /**
     * $array[1], $array[$var], $array["string"], "string"[1]
     *
     * @param \PhpParser\Node\Expr\ArrayDimFetch $expr
     * @param Context $context
     * @return CompiledExpression
     */
    protected function compile($expr, Context $context)
    {
        $compiler = $context->getExpressionCompiler();
        $var = $compiler->compile($expr->var);
        $dim = $compiler->compile($expr->dim);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}

        if ($var->getType() === CompiledExpression::UNIMPLEMENTED
         || $dim->getType() === CompiledExpression::UNIMPLEMENTED
        ) {
            return new CompiledExpression(CompiledExpression::UNIMPLEMENTED);
        }

        if (!$var->isTypeKnown() || !$dim->isTypeKnown()
         || !$var->isCorrectValue() || !$dim->isCorrectValue()
        ) {
            return new CompiledExpression();
        }

        switch ($var->getType()) {
            case CompiledExpression::STRING:
            case CompiledExpression::ARR:
                if ($dim->isArray()) {
                    $context->notice(
                        'language_error',
                        'Illegal offset type',
                        $expr
                    );
                    return new CompiledExpression();
                }
                break;
            default:
                break;
        }

        $resultArray = $var->getValue();
        return CompiledExpression::fromZvalValue($resultArray[$dim->getValue()]);
    }
}


1			<?php
2
3			namespace PHPSA\Compiler\Expression;
4
5			use PHPSA\CompiledExpression;
6			use PHPSA\Context;
7
8			class ArrayDimFetch extends AbstractExpressionCompiler
9			{
10			protected $name = 'PhpParser\Node\Expr\ArrayDimFetch';
11
12			/**
13			* $array[1], $array[$var], $array["string"], "string"[1]
14			*
15			* @param \PhpParser\Node\Expr\ArrayDimFetch $expr
16			* @param Context $context
17			* @return CompiledExpression
18			*/
19			protected function compile($expr, Context $context)
20			{
21			$compiler = $context->getExpressionCompiler();
22			$var = $compiler->compile($expr->var);
23			$dim = $compiler->compile($expr->dim);
			0 ignored issues – show Bug introduced 2016-10-07 12:42 UTC by Report Bug Copy Issue Report It seems like `$expr->dim` can be `null`; however, `compile()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
24
25			if ($var->getType() === CompiledExpression::UNIMPLEMENTED
26			\|\| $dim->getType() === CompiledExpression::UNIMPLEMENTED
27			) {
28			return new CompiledExpression(CompiledExpression::UNIMPLEMENTED);
29			}
30
31			if (!$var->isTypeKnown() \|\| !$dim->isTypeKnown()
32			\|\| !$var->isCorrectValue() \|\| !$dim->isCorrectValue()
33			) {
34			return new CompiledExpression();
35			}
36
37			switch ($var->getType()) {
38			case CompiledExpression::STRING:
39			case CompiledExpression::ARR:
40			if ($dim->isArray()) {
41			$context->notice(
42			'language_error',
43			'Illegal offset type',
44			$expr
45			);
46			return new CompiledExpression();
47			}
48			break;
49			default:
50			break;
51			}
52
53			$resultArray = $var->getValue();
54			return CompiledExpression::fromZvalValue($resultArray[$dim->getValue()]);
55			}
56			}
57

ovr / phpsa

Push — master ( e1144e...7e8850 )

ArrayDimFetch::compile() D

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like