CheckLNumberKind::pass() - Code Metrics - Inspection of "Created a Compiler for Node\Scalar and Analyzer fo..." - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#251)

unknown

created 2016-10-13 16:31 UTC

CheckLNumberKind::pass() A

↳ Parent: CheckLNumberKind

Complexity

Conditions	2
Paths	2

Size

Total Lines	13
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	2

Importance

Changes

Metric	Value
cc	2
eloc	8
nc	2
nop	2
dl	0
loc	13
ccs	8
cts	8
cp	1
crap	2
rs	9.4285
c	0
b	0
f	0

<?php

namespace PHPSA\Analyzer\Pass\Scalar;

use PhpParser\Node\Scalar;
use PHPSA\Analyzer\Helper\DefaultMetadataPassTrait;
use PHPSA\Analyzer\Pass\AnalyzerPassInterface;
use PHPSA\Context;

class CheckLNumberKind implements AnalyzerPassInterface
{
    use DefaultMetadataPassTrait;

    const DESCRIPTION = 'Using octal, hexadecimal or binary integers are discouraged.';

    /**
     * @param Scalar\LNumber $lNum
     * @param Context $context
     * @return bool
     */
    public function pass(Scalar\LNumber $lNum, Context $context)
    {
        if ($lNum->getAttribute('kind') != Scalar\LNumber::KIND_DEC) {
            $context->notice(
                'l_number_kind',
                'Avoid using octal, hexadecimal or binary',
                $lNum
            );
            return true;
        }

        return false;
    }

    /**
     * @return array
     */
    public function getRegister()
    {
        return [
            Scalar\LNumber::class,
        ];
    }
}


1		<?php
2
3		namespace PHPSA\Analyzer\Pass\Scalar;
4
5		use PhpParser\Node\Scalar;
6		use PHPSA\Analyzer\Helper\DefaultMetadataPassTrait;
7		use PHPSA\Analyzer\Pass\AnalyzerPassInterface;
8		use PHPSA\Context;
9
10		class CheckLNumberKind implements AnalyzerPassInterface
11		{
12		use DefaultMetadataPassTrait;
13
14		const DESCRIPTION = 'Using octal, hexadecimal or binary integers are discouraged.';
15
16		/**
17		* @param Scalar\LNumber $lNum
18		* @param Context $context
19		* @return bool
20		*/
21	491	public function pass(Scalar\LNumber $lNum, Context $context)
22		{
23	491	if ($lNum->getAttribute('kind') != Scalar\LNumber::KIND_DEC) {
24	487	$context->notice(
25	487	'l_number_kind',
26	487	'Avoid using octal, hexadecimal or binary',
27		$lNum
28	487	);
29	487	return true;
30		}
31
32	5	return false;
33		}
34
35		/**
36		* @return array
37		*/
38	1	public function getRegister()
39		{
40		return [
41	1	Scalar\LNumber::class,
42	1	];
43		}
44		}
45

ovr / phpsa

Pull Request — master (#251)

CheckLNumberKind::pass() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like