AssignRefNew::pass() - Code Metrics - Inspection of "Assign ref new analyzer" - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#305)

by Дмитрий

created 2017-01-22 11:01 UTC

AssignRefNew::pass() A

↳ Parent: AssignRefNew

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	2

Importance

Changes

Metric	Value
cc	2
eloc	8
nc	2
nop	2
dl	0
loc	14
ccs	8
cts	8
cp	1
crap	2
rs	9.4285
c	0
b	0
f	0

<?php
/**
 * @author Patsura Dmitry https://github.com/ovr <[email protected]>
 */

namespace PHPSA\Analyzer\Pass\Expression;

use PHPSA\Analyzer\Helper\DefaultMetadataPassTrait;
use PHPSA\Analyzer\Pass\AnalyzerPassInterface;
use PhpParser\Node\Expr;
use PHPSA\Context;

class AssignRefNew implements AnalyzerPassInterface
{
    use DefaultMetadataPassTrait {
        DefaultMetadataPassTrait::getMetadata as defaultMetadata;
    }

    const DESCRIPTION = 'Protection of usage & and new.';

    /**
     * @param Expr\AssignRef $expr
     * @param Context $context
     * @return bool
     */
    public function pass(Expr\AssignRef $expr, Context $context)
    {
        if ($expr->expr instanceof Expr\New_) {
            $context->notice(
                'assign_ref_new',
                'Do not use = & new, all objects in PHP are passed by reference',
                $expr
            );

            return true;
        }

        return false;
    }

    /**
     * @return array
     */
    public function getRegister()
    {
        return [
            Expr\AssignRef::class
        ];
    }
}


1		<?php
2		/**
3		* @author Patsura Dmitry https://github.com/ovr <[email protected]>
4		*/
5
6		namespace PHPSA\Analyzer\Pass\Expression;
7
8		use PHPSA\Analyzer\Helper\DefaultMetadataPassTrait;
9		use PHPSA\Analyzer\Pass\AnalyzerPassInterface;
10		use PhpParser\Node\Expr;
11		use PHPSA\Context;
12
13		class AssignRefNew implements AnalyzerPassInterface
14		{
15		use DefaultMetadataPassTrait {
16		DefaultMetadataPassTrait::getMetadata as defaultMetadata;
17		}
18
19		const DESCRIPTION = 'Protection of usage & and new.';
20
21		/**
22		* @param Expr\AssignRef $expr
23		* @param Context $context
24		* @return bool
25		*/
26	2	public function pass(Expr\AssignRef $expr, Context $context)
27		{
28	2	if ($expr->expr instanceof Expr\New_) {
29	1	$context->notice(
30	1	'assign_ref_new',
31	1	'Do not use = & new, all objects in PHP are passed by reference',
32		$expr
33	1	);
34
35	1	return true;
36		}
37
38	1	return false;
39		}
40
41		/**
42		* @return array
43		*/
44	2	public function getRegister()
45		{
46		return [
47		Expr\AssignRef::class
48	2	];
49		}
50		}
51

ovr / phpsa

Pull Request — master (#305)

AssignRefNew::pass() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like