Application::getCVVersion() - Code Metrics - Inspection of "[CodeClimate Integration] Application - fix getCVV..." - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( af006f...5a2620 )

by Дмитрий

created 2016-12-26 11:35 UTC

Application::getCVVersion() B

↳ Parent: Application

Complexity

Conditions	4
Paths	4

Size

Total Lines	25
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
cc	4
eloc	14
c	1
b	1
f	0
nc	4
nop	0
dl	0
loc	25
ccs	0
cts	0
cp	0
crap	20
rs	8.5806

<?php
/**
 * @author Patsura Dmitry https://github.com/ovr <[email protected]>
 */

namespace PHPSA;

/**
 * PHPSA Application
 */
class Application extends \Symfony\Component\Console\Application
{
    /**
     * @var Configuration
     */
    public $configuration;

    /**
     * @var IssuesCollector
     */
    protected $issuesCollector;

    /**
     * @var Compiler
     */
    public $compiler;

    const VERSION = '0.6.2';

    /**
     * Starts the application.
     */
    public function __construct()
    {
        parent::__construct('PHP Smart Analyzer', $this->getStringVersion());

        $this->add(new Command\CheckCommand());
        $this->add(new Command\CompileCommand());
        $this->add(new Command\DumpReferenceCommand());
        $this->add(new Command\DumpDocumentationCommand());

        $this->issuesCollector = new IssuesCollector();
        $this->configuration = new Configuration();
    }

    /**
     * Returns the version as a string.
     *
     * @return string
     * @codeCoverageIgnore
     */
    protected function getStringVersion()
    {
        $hash = $this->getCVVersion();
        if ($hash) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            return self::VERSION . ' #' . $hash;
        }

        return self::VERSION;
    }

    /**
     * Returns CV Version.
     *
     * @return string|null
     * @codeCoverageIgnore
     */
    protected function getCVVersion()
    {
        if (!extension_loaded('pcntl')) {
            return null;
        }

        $proc = proc_open(
            'git describe --always',
            [
                1 => ['pipe','w'],
            ],
            $pipes
        );
        if ($proc) {
            $stdout = stream_get_contents($pipes[1]);
            fclose($pipes[1]);

            $exitCode = proc_close($proc);
            if ($exitCode === 0) {
                return $stdout;
            }
        }

        return null;
    }

    /**
     * Get the configuration object.
     *
     * @return Configuration
     */
    public function getConfiguration()
    {
        return $this->configuration;
    }

    /**
     * Get the IssuesCollector object.
     *
     * @return IssuesCollector
     */
    public function getIssuesCollector()
    {
        return $this->issuesCollector;
    }
}


1		<?php
2		/**
3		* @author Patsura Dmitry https://github.com/ovr <[email protected]>
4		*/
5
6		namespace PHPSA;
7
8		/**
9		* PHPSA Application
10		*/
11		class Application extends \Symfony\Component\Console\Application
12		{
13		/**
14		* @var Configuration
15		*/
16		public $configuration;
17
18		/**
19		* @var IssuesCollector
20		*/
21		protected $issuesCollector;
22
23		/**
24		* @var Compiler
25		*/
26		public $compiler;
27
28		const VERSION = '0.6.2';
29
30		/**
31		* Starts the application.
32		*/
33	887	public function __construct()
34		{
35	887	parent::__construct('PHP Smart Analyzer', $this->getStringVersion());
36
37	887	$this->add(new Command\CheckCommand());
38	887	$this->add(new Command\CompileCommand());
39	887	$this->add(new Command\DumpReferenceCommand());
40	887	$this->add(new Command\DumpDocumentationCommand());
41
42	887	$this->issuesCollector = new IssuesCollector();
43	887	$this->configuration = new Configuration();
44	887	}
45
46		/**
47		* Returns the version as a string.
48		*
49		* @return string
50		* @codeCoverageIgnore
51		*/
52		protected function getStringVersion()
53		{
54		$hash = $this->getCVVersion();
55		if ($hash) {
		0 ignored issues – show Bug Best Practice introduced 2016-12-26 11:38 UTC by Report Bug Copy Issue Report The expression `$hash` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
56		return self::VERSION . ' #' . $hash;
57		}
58
59		return self::VERSION;
60		}
61
62		/**
63		* Returns CV Version.
64		*
65		* @return string\|null
66		* @codeCoverageIgnore
67		*/
68		protected function getCVVersion()
69		{
70		if (!extension_loaded('pcntl')) {
71		return null;
72		}
73
74		$proc = proc_open(
75		'git describe --always',
76		[
77		1 => ['pipe','w'],
78		],
79		$pipes
80		);
81		if ($proc) {
82		$stdout = stream_get_contents($pipes[1]);
83		fclose($pipes[1]);
84
85		$exitCode = proc_close($proc);
86		if ($exitCode === 0) {
87		return $stdout;
88		}
89		}
90
91		return null;
92		}
93
94		/**
95		* Get the configuration object.
96		*
97		* @return Configuration
98		*/
99	51	public function getConfiguration()
100		{
101	51	return $this->configuration;
102		}
103
104		/**
105		* Get the IssuesCollector object.
106		*
107		* @return IssuesCollector
108		*/
109	51	public function getIssuesCollector()
110		{
111	51	return $this->issuesCollector;
112		}
113		}
114

ovr / phpsa

Push — master ( af006f...5a2620 )

Application::getCVVersion() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like