FixedCondition::pass() - Code Metrics - Inspection of "Disable FixedCondition" - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 41783b...6c90aa )

by Enrico

created 2016-10-10 11:22 UTC

FixedCondition::pass() B

↳ Parent: FixedCondition

Complexity

Conditions	4
Paths	4

Size

Total Lines	22
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
cc	4
eloc	12
c	1
b	1
f	0
nc	4
nop	2
dl	0
loc	22
ccs	0
cts	13
cp	0
crap	20
rs	8.9197

<?php
/**
 * @author Christian Kraus <[email protected]>
 */

namespace PHPSA\Analyzer\Pass\Statement;

use PhpParser\Node\Stmt\Do_;
use PhpParser\Node\Stmt\If_;
use PhpParser\Node\Stmt\ElseIf_;
use PhpParser\Node\Stmt\Switch_;
use PhpParser\Node\Stmt\While_;
use PhpParser\Node\Stmt\For_;
use PHPSA\Analyzer\Pass;
use PHPSA\Context;

class FixedCondition implements Pass\AnalyzerPassInterface
{
    /**
     * @param $stmt
     * @param Context $context
     * @return bool
     */
    public function pass($stmt, Context $context)
    {
        $condition = $stmt->cond;

        if ($stmt instanceof For_ && count($stmt->cond) > 0) { // For is the only one that has an array as condition
            $condition = $condition[0];
        }

        $expression = $context->getExpressionCompiler()->compile($condition);

        if ($expression->hasValue()) { // @todo implement isStatic() method to see if expression changes or not
            $context->notice(
                'fixed_condition',
                'The condition will always result in the same boolean value',
                $stmt
            );

            return true;
        }

        return false;
    }

    /**
     * @return array
     */
    public function getRegister()
    {
        return [
            If_::class,
            ElseIf_::class,
            While_::class,
            For_::class,
            Do_::class,
            Switch_::class,
        ];
    }
}


1			<?php
2			/**
3			* @author Christian Kraus <[email protected]>
4			*/
5
6			namespace PHPSA\Analyzer\Pass\Statement;
7
8			use PhpParser\Node\Stmt\Do_;
9			use PhpParser\Node\Stmt\If_;
10			use PhpParser\Node\Stmt\ElseIf_;
11			use PhpParser\Node\Stmt\Switch_;
12			use PhpParser\Node\Stmt\While_;
13			use PhpParser\Node\Stmt\For_;
14			use PHPSA\Analyzer\Pass;
15			use PHPSA\Context;
16
17			class FixedCondition implements Pass\AnalyzerPassInterface
18			{
19			/**
20			* @param $stmt
21			* @param Context $context
22			* @return bool
23			*/
24			public function pass($stmt, Context $context)
25			{
26			$condition = $stmt->cond;
27
28			if ($stmt instanceof For_ && count($stmt->cond) > 0) { // For is the only one that has an array as condition
29			$condition = $condition[0];
30			}
31
32			$expression = $context->getExpressionCompiler()->compile($condition);
33
34			if ($expression->hasValue()) { // @todo implement isStatic() method to see if expression changes or not
35			$context->notice(
36			'fixed_condition',
37			'The condition will always result in the same boolean value',
38			$stmt
39			);
40
41			return true;
42			}
43
44			return false;
45			}
46
47			/**
48			* @return array
49			*/
50			public function getRegister()
51			{
52			return [
53			If_::class,
54			ElseIf_::class,
55			While_::class,
56			For_::class,
57			Do_::class,
58			Switch_::class,
59			];
60			}
61			}
62

ovr / phpsa

Push — master ( 41783b...6c90aa )

FixedCondition::pass() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like