TryCatchSt::compile() - Code Metrics - Inspection of "[Compiler] TryCatch - compile finally statements" - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( fb0961...0bb080 )

by Дмитрий

created 2016-01-20 20:51 UTC

TryCatchSt::compile() B

↳ Parent: TryCatchSt

Complexity

Conditions	5
Paths	6

Size

Total Lines	16
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	30

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	16
ccs	0
cts	8
cp	0
rs	8.8571
cc	5
eloc	9
nc	6
nop	2
crap	30

<?php
/**
 * @author Patsura Dmitry https://github.com/ovr <[email protected]>
 */

namespace PHPSA\Compiler\Statement;

use PHPSA\CompiledExpression;
use PHPSA\Context;
use PHPSA\Compiler\Expression;

class TryCatchSt extends AbstractCompiler
{
    protected $name = '\PhpParser\Node\Stmt\TryCatch';

    /**
     * @param \PhpParser\Node\Stmt\TryCatch $statement
     * @param Context $context
     * @return CompiledExpression
     */
    public function compile($statement, Context $context)
    {
        if (count($statement->stmts) > 0) {
            foreach ($statement->stmts as $stmt) {
                \PHPSA\nodeVisitorFactory($stmt, $context);
            }
        } else {
            $context->notice('not-implemented-body', 'Missing body', $statement);
        }

        if (count($statement->finallyStmts) > 0) {
            foreach ($statement->finallyStmts as $stmt) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                \PHPSA\nodeVisitorFactory($stmt, $context);
            }
        }
    }
}


1			<?php
2			/**
3			* @author Patsura Dmitry https://github.com/ovr <[email protected]>
4			*/
5
6			namespace PHPSA\Compiler\Statement;
7
8			use PHPSA\CompiledExpression;
9			use PHPSA\Context;
10			use PHPSA\Compiler\Expression;
11
12			class TryCatchSt extends AbstractCompiler
13			{
14			protected $name = '\PhpParser\Node\Stmt\TryCatch';
15
16			/**
17			* @param \PhpParser\Node\Stmt\TryCatch $statement
18			* @param Context $context
19			* @return CompiledExpression
20			*/
21			public function compile($statement, Context $context)
22			{
23			if (count($statement->stmts) > 0) {
24			foreach ($statement->stmts as $stmt) {
25			\PHPSA\nodeVisitorFactory($stmt, $context);
26			}
27			} else {
28			$context->notice('not-implemented-body', 'Missing body', $statement);
29			}
30
31			if (count($statement->finallyStmts) > 0) {
32			foreach ($statement->finallyStmts as $stmt) {
			0 ignored issues – show Bug introduced 2016-01-20 21:15 UTC by Report Bug Copy Issue Report The expression `$statement->finallyStmts` of type `null\|array<integer,object<PhpParser\Node>>` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
33			\PHPSA\nodeVisitorFactory($stmt, $context);
34			}
35			}
36			}
37			}
38

ovr / phpsa

Push — master ( fb0961...0bb080 )

TryCatchSt::compile() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like