|
1
|
|
|
<?php |
|
2
|
|
|
/** |
|
3
|
|
|
* @author Patsura Dmitry https://github.com/ovr <[email protected]> |
|
4
|
|
|
*/ |
|
5
|
|
|
|
|
6
|
|
|
namespace PHPSA\Analyzer\Pass\Statement; |
|
7
|
|
|
|
|
8
|
|
|
use PhpParser\Node\Stmt\ClassMethod; |
|
9
|
|
|
use PHPSA\Analyzer\Pass\AnalyzerPassInterface; |
|
10
|
|
|
use PHPSA\Analyzer\Pass\ConfigurablePassInterface; |
|
11
|
|
|
use PHPSA\Check; |
|
12
|
|
|
use PHPSA\Context; |
|
13
|
|
|
use Symfony\Component\Config\Definition\Builder\TreeBuilder; |
|
14
|
|
|
|
|
15
|
|
|
class GetParametersCheck implements ConfigurablePassInterface, AnalyzerPassInterface |
|
16
|
|
|
{ |
|
17
|
|
|
public function __clone($name, $value) |
|
|
|
|
|
|
18
|
|
|
{ |
|
19
|
|
|
|
|
20
|
|
|
} |
|
21
|
|
|
|
|
22
|
|
|
/** |
|
23
|
|
|
* @param ClassMethod $methodStmt |
|
24
|
|
|
* @param Context $context |
|
25
|
|
|
* @return bool |
|
26
|
|
|
*/ |
|
27
|
|
|
public function pass(ClassMethod $methodStmt, Context $context) |
|
28
|
|
|
{ |
|
29
|
|
|
if ($methodStmt->name == '__get') { |
|
30
|
|
|
if (count($methodStmt->params) == 0) { |
|
31
|
|
|
$context->notice( |
|
32
|
|
|
'magic.get.wrong-parameters', |
|
33
|
|
|
'Magic method __get must take 1 paramter at least', |
|
34
|
|
|
$methodStmt, |
|
35
|
|
|
Check::CHECK_SAFE |
|
36
|
|
|
); |
|
37
|
|
|
} |
|
38
|
|
|
} |
|
39
|
|
|
|
|
40
|
|
|
if ($methodStmt->name == '__set') { |
|
41
|
|
|
if (count($methodStmt->params) == 0) { |
|
42
|
|
|
$context->notice( |
|
43
|
|
|
'magic.get.wrong-parameters', |
|
44
|
|
|
'Magic method __set must take 1 paramter at least', |
|
45
|
|
|
$methodStmt, |
|
46
|
|
|
Check::CHECK_SAFE |
|
47
|
|
|
); |
|
48
|
|
|
} |
|
49
|
|
|
} |
|
50
|
|
|
|
|
51
|
|
|
if ($methodStmt->name == '__clone') { |
|
52
|
|
|
if (count($methodStmt->params) > 0) { |
|
53
|
|
|
$context->notice( |
|
54
|
|
|
'magic.get.wrong-parameters', |
|
55
|
|
|
'Magic method __clone cannot accept arguments', |
|
56
|
|
|
$methodStmt, |
|
57
|
|
|
Check::CHECK_SAFE |
|
58
|
|
|
); |
|
59
|
|
|
} |
|
60
|
|
|
} |
|
61
|
|
|
} |
|
62
|
|
|
|
|
63
|
|
|
/** |
|
64
|
|
|
* @return TreeBuilder |
|
65
|
|
|
*/ |
|
66
|
|
|
public function getConfiguration() |
|
67
|
|
|
{ |
|
68
|
|
|
$treeBuilder = new TreeBuilder(); |
|
69
|
|
|
$treeBuilder->root('method_cannot_return') |
|
70
|
|
|
->canBeDisabled() |
|
71
|
|
|
; |
|
72
|
|
|
|
|
73
|
|
|
return $treeBuilder; |
|
74
|
|
|
} |
|
75
|
|
|
|
|
76
|
|
|
/** |
|
77
|
|
|
* @return array |
|
78
|
|
|
*/ |
|
79
|
|
|
public function getRegister() |
|
80
|
|
|
{ |
|
81
|
|
|
return [ |
|
82
|
|
|
\PhpParser\Node\Stmt\ClassMethod::class |
|
83
|
|
|
]; |
|
84
|
|
|
} |
|
85
|
|
|
} |
|
86
|
|
|
|
ovr /
phpsa
Loading history...
This check looks from parameters that have been defined for a function or method, but which are not used in the method body.