PHPSA\Compiler\Expression\Ternary

Complexity

Total Complexity

2

Size/Duplication

Total Lines	24
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	5

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	compile()	0	12	2

<?php

namespace PHPSA\Compiler\Expression;

use PHPSA\CompiledExpression;
use PHPSA\Context;
use PHPSA\Compiler\Expression;
use PHPSA\Compiler\Expression\AbstractExpressionCompiler;

class Ternary extends AbstractExpressionCompiler
{
    protected $name = 'PhpParser\Node\Expr\Ternary';

    /**
     * ({expr}) ? {expr} : {expr}
     *
     * @param \PhpParser\Node\Expr\Ternary $expr
     * @param Context $context
     * @return CompiledExpression
     */
    protected function compile($expr, Context $context)
    {
        $condition = $context->getExpressionCompiler()->compile($expr->cond);
        $left = $context->getExpressionCompiler()->compile($expr->if);

It seems like $expr->if can be null; however, compile() does not accept null, maybe add an additional type check?

        $right = $context->getExpressionCompiler()->compile($expr->else);

        if ($condition->getValue() == true) {
            return CompiledExpression::fromZvalValue($left->getValue());
        } else {
            return CompiledExpression::fromZvalValue($right->getValue());
        }
    }
}