ContextTest::testModifyReferencedVariables() - Code Metrics - Inspection of "Context - implement modifyReferencedVariables meth..." - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3d4dba...95fa9b )

by Дмитрий

created 2016-05-17 10:56 UTC

ContextTest::testModifyReferencedVariables() B

↳ Parent: ContextTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	40
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	1
eloc	15
c	1
b	0
f	1
nc	1
nop	0
dl	0
loc	40
rs	8.8571

<?php

namespace Tests\PHPSA;

use PHPSA\CompiledExpression;
use PHPSA\Variable;

class ContextTest extends TestCase
{
    public function testModifyReferencedVariables()
    {
        $context = $this->getContext();

        /**
         * This variable is not needed for change
         */
        $context->addVariable(
            new Variable('a', null, CompiledExpression::INTEGER, 1)
        );

        /**
         * $b = true;
         */
        $context->addVariable(
            $variableB = new Variable('b', null, CompiledExpression::BOOLEAN, true)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        /**
         * $c = &$b;
         */
        $variableC = new Variable('c');
        $variableC->setReferencedTo($variableB);

        $context->addVariable(
            $variableC
        );

        $newType = CompiledExpression::INTEGER;
        $newValue = 55;

        /**
         * $b = {$newValue};
         * After it variable $c will change type and value
         */
        $context->modifyReferencedVariables($variableB, $newType, $newValue);

        self::assertSame($newValue, $variableC->getValue());
        self::assertSame($newType, $variableC->getType());
    }
}


1			<?php
2
3			namespace Tests\PHPSA;
4
5			use PHPSA\CompiledExpression;
6			use PHPSA\Variable;
7
8			class ContextTest extends TestCase
9			{
10			public function testModifyReferencedVariables()
11			{
12			$context = $this->getContext();
13
14			/**
15			* This variable is not needed for change
16			*/
17			$context->addVariable(
18			new Variable('a', null, CompiledExpression::INTEGER, 1)
19			);
20
21			/**
22			* $b = true;
23			*/
24			$context->addVariable(
25			$variableB = new Variable('b', null, CompiledExpression::BOOLEAN, true)
			0 ignored issues – show Documentation introduced 2016-05-17 11:01 UTC by Report Bug Copy Issue Report `true` is of type `boolean`, but the function expects a `integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
26			);
27
28			/**
29			* $c = &$b;
30			*/
31			$variableC = new Variable('c');
32			$variableC->setReferencedTo($variableB);
33
34			$context->addVariable(
35			$variableC
36			);
37
38			$newType = CompiledExpression::INTEGER;
39			$newValue = 55;
40
41			/**
42			* $b = {$newValue};
43			* After it variable $c will change type and value
44			*/
45			$context->modifyReferencedVariables($variableB, $newType, $newValue);
46
47			self::assertSame($newValue, $variableC->getValue());
48			self::assertSame($newType, $variableC->getType());
49			}
50			}
51

ovr / phpsa

Push — master ( 3d4dba...95fa9b )

ContextTest::testModifyReferencedVariables() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like