PHPSA\ControlFlow\Visitor\UnreachableVisitor

Complexity

Total Complexity

7

Size/Duplication

Total Lines	30
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	enterBlock()	0	17	6
A	leaveBlock()	0	3	1

<?php
/**
 * @author Patsura Dmitry https://github.com/ovr <talk@dmtry.me>
 */

namespace PHPSA\ControlFlow\Visitor;

use PHPSA\ControlFlow\Block;

/**
 *
 * function test($a) {
 *     return $a;
 *
 *     $a = 1; // Unreachable node!
 * }
 *
 */
class UnreachableVisitor extends AbstractVisitor
{
    /**
     * @param Block $block
     */
    public function enterBlock(Block $block)
    {
        $childrens = $block->getChildrens();
        if ($childrens) {

The expression $childrens of type PHPSA\ControlFlow\Node\AbstractNode[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $childrensCount = count($childrens);
            if ($childrensCount <= 1) {
                return;
            }

            foreach ($childrens as $index => $children) {
                // Check that exit node is not the latest
                if ($children->willExit() && ($index + 1) != $childrensCount) {
                    echo 'Unreacheable block ' . $block->getId() . PHP_EOL;
                }
            }
        }
    }

    /**
     * @param Block $block
     */
    public function leaveBlock(Block $block)
    {
    }
}