Completed
Push — master ( 579f40...ac2f15 )
by Дмитрий
16s
created

ReturnAndYieldInOneMethod::getRegister()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 6
Code Lines 3

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 3
CRAP Score 1

Importance

Changes 1
Bugs 0 Features 0
Metric Value
cc 1
eloc 3
nc 1
nop 0
dl 0
loc 6
ccs 3
cts 3
cp 1
crap 1
rs 9.4285
c 1
b 0
f 0
1
<?php
2
3
namespace PHPSA\Analyzer\Pass\Statement;
4
5
use PhpParser\Node\Stmt;
6
use PHPSA\Analyzer\Helper\DefaultMetadataPassTrait;
7
use PHPSA\Analyzer\Helper\ResolveExpressionTrait;
8
use PHPSA\Analyzer\Pass;
9
use PhpParser\Node\Expr;
10
use PHPSA\Context;
11
12
class ReturnAndYieldInOneMethod implements Pass\AnalyzerPassInterface
13
{
14
    const DESCRIPTION = 'Checks for using return and yield statements in a one method and discourages it.';
15
16
    use DefaultMetadataPassTrait;
17
    use ResolveExpressionTrait;
18
19
    /**
20
     * @param Stmt $stmt
21
     * @param Context $context
22
     * @return bool
23
     */
24 1
    public function pass(Stmt $stmt, Context $context)
25
    {
26 1
        $yieldExists = \PHPSA\generatorHasValue($this->findYieldExpression([$stmt]));
27 1
        if (!$yieldExists) {
28
            // YieldFrom is another expression
29 1
            $yieldExists = \PHPSA\generatorHasValue($this->findNode([$stmt], Expr\YieldFrom::class));
30 1
        }
31
32 1
        if ($yieldExists && \PHPSA\generatorHasValue($this->findReturnStatement([$stmt]))) {
33 1
            $context->notice('return_and_yield_in_one_method', 'Do not use return and yield in a one method', $stmt);
34 1
            return true;
35
        }
36
37 1
        return false;
38
    }
39
40
    /**
41
     * @return array
42
     */
43 1
    public function getRegister()
44
    {
45
        return [
46 1
            Stmt\ClassMethod::class,
47 1
        ];
48
    }
49
}
50