DuplicatedVariablesInUseClosure::pass() - Code Metrics - Inspection of "Var duplicate in Closure use statement" - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#343)

by Strahinja

created 2017-11-15 18:25 UTC

DuplicatedVariablesInUseClosure::pass() A

↳ Parent: DuplicatedVariablesInUseClosure

Complexity

Conditions	3
Paths	3

Size

Total Lines	20
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	13
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	13
nc	3
nop	2
dl	0
loc	20
ccs	13
cts	13
cp	1
crap	3
rs	9.4285
c	1
b	0
f	0

<?php
/**
 * @author Strahinja Djuric https://github.com/kilgaloon <[email protected]>
 */
namespace PHPSA\Analyzer\Pass\Expression;

use PHPSA\Context;
use PHPSA\Analyzer\Pass;
use PhpParser\Node\Expr\Closure;
use PHPSA\Analyzer\Pass\AnalyzerPassInterface;
use PHPSA\Analyzer\Helper\DefaultMetadataPassTrait;

class DuplicatedVariablesInUseClosure implements AnalyzerPassInterface
{
    use DefaultMetadataPassTrait;

    const DESCRIPTION = 'Check for duplicate variables in use statement';

    /**
     * @param Closure $funcCall
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param Context $context
     * @return bool
     */
    public function pass(Closure $expr, Context $context)
    {
        $varUsed = [];
        foreach ($expr->uses as $use) {
            $var = $context->getExpressionCompiler()->compile($use->var);
            if (in_array($var->getValue(), $varUsed)) {
                $context->notice(
                    'duplicated_variable_in_use_closure',
                    sprintf("Duplicated variable $%s in use statement.", $use->var),
                    $expr
                );

                return false;
            } else {
                array_push($varUsed, $use->var);
            }
        }

        return true;
    }

    public function getRegister()
    {
        return [
            Closure::class
        ];
    }
}


1		<?php
2		/**
3		* @author Strahinja Djuric https://github.com/kilgaloon <[email protected]>
4		*/
5		namespace PHPSA\Analyzer\Pass\Expression;
6
7		use PHPSA\Context;
8		use PHPSA\Analyzer\Pass;
9		use PhpParser\Node\Expr\Closure;
10		use PHPSA\Analyzer\Pass\AnalyzerPassInterface;
11		use PHPSA\Analyzer\Helper\DefaultMetadataPassTrait;
12
13		class DuplicatedVariablesInUseClosure implements AnalyzerPassInterface
14		{
15		use DefaultMetadataPassTrait;
16
17		const DESCRIPTION = 'Check for duplicate variables in use statement';
18
19		/**
20		* @param Closure $funcCall
		0 ignored issues – show Bug introduced 2017-11-15 18:30 UTC by Report Bug Copy Issue Report There is no parameter named `$funcCall`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
21		* @param Context $context
22		* @return bool
23		*/
24	2	public function pass(Closure $expr, Context $context)
25		{
26	2	$varUsed = [];
27	2	foreach ($expr->uses as $use) {
28	1	$var = $context->getExpressionCompiler()->compile($use->var);
29	1	if (in_array($var->getValue(), $varUsed)) {
30	1	$context->notice(
31	1	'duplicated_variable_in_use_closure',
32	1	sprintf("Duplicated variable $%s in use statement.", $use->var),
33		$expr
34	1	);
35
36	1	return false;
37		} else {
38	1	array_push($varUsed, $use->var);
39		}
40	2	}
41
42	2	return true;
43		}
44
45	2	public function getRegister()
46		{
47		return [
48		Closure::class
49	2	];
50		}
51		}
52

ovr / phpsa

Pull Request — master (#343)

DuplicatedVariablesInUseClosure::pass() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like