Compiler::compile() - Code Metrics - Inspection of "Phpsa on phpsa" - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#264)

by Enrico

created 2016-11-04 12:29 UTC

Compiler::compile() C

↳ Parent: Compiler

Complexity

Conditions	14
Paths	135

Size

Total Lines	68
Code Lines	28

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	23
CRAP Score	26.0519

Importance

Changes

Metric	Value
cc	14
eloc	28
nc	135
nop	1
dl	0
loc	68
ccs	23
cts	38
cp	0.6052
crap	26.0519
rs	5.2791
c	0
b	0
f	0

How to fix Long Method Complexity

<?php
/**
 * @author Patsura Dmitry https://github.com/ovr <[email protected]>
 */

namespace PHPSA;

use PHPSA\Definition\ClassDefinition;
use PHPSA\Definition\FunctionDefinition;
use PHPSA\Definition\RuntimeClassDefinition;
use PHPSA\Definition\TraitDefinition;
use ReflectionClass;

class Compiler
{
    /**
     * @var ClassDefinition[]
     */
    protected $classes = [];

    /**
     * @var TraitDefinition[]
     */
    protected $traits = [];

    /**
     * @var FunctionDefinition[]
     */
    protected $functions = [];

    /**
     * @param ClassDefinition $class
     */
    public function addClass(ClassDefinition $class)
    {
        $this->classes[implode('\\', [$class->getNamespace(), $class->getName()])] = $class;
    }

    /**
     * @param TraitDefinition $class
     */
    public function addTrait(TraitDefinition $class)
    {
        $this->traits[implode('\\', [$class->getNamespace(), $class->getName()])] = $class;
    }

    /**
     * @param FunctionDefinition $function
     */
    public function addFunction(FunctionDefinition $function)
    {
        $this->functions[] = $function;
    }

    /**
     * @param Context $context
     */
    public function compile(Context $context)

    {
        $context->scopePointer = null;

        /**
         * @todo Implement class map...
         */
        foreach ($this->classes as $class) {
            $extends = $class->getExtendsClass();
            if ($extends) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
                if (isset($this->classes[$extends])) {
                    $class->setExtendsClassDefinition($this->classes[$extends]);
                } else {
                    if (class_exists($extends, true)) {
                        $class->setExtendsClassDefinition(
                            new RuntimeClassDefinition(
                                new ReflectionClass(
                                    $extends
                                )
                            )
                        );
                    }
                }
            }
        }

        foreach ($this->functions as $function) {
            /**
             * @todo Configuration
             *
             * Ignore functions compiling from vendor
             */
            $checkVendor = strpos($function->getFilepath(), './vendor');
            if ($checkVendor !== false && $checkVendor < 3) {
                continue;
            }

            $function->compile($context);
        }

        foreach ($this->traits as $trait) {
            /**
             * @todo Configuration
             *
             * Ignore traits compiling from vendor
             */
            $checkVendor = strpos($trait->getFilepath(), './vendor');
            if ($checkVendor !== false && $checkVendor < 3) {
                continue;
            }

            $trait->compile($context);
        }

        foreach ($this->classes as $class) {
            /**
             * @todo Configuration
             *
             * Ignore Classes compiling from vendor
             */
            $checkVendor = strpos($class->getFilepath(), './vendor');
            if ($checkVendor !== false && $checkVendor < 3) {
                continue;
            }

            $class->compile($context);
        }
    }

    /**
     * Try to find function with $namespace from pre-compiled function(s)
     *
     * @param string $name
     * @param string|null $namespace
     * @return bool|FunctionDefinition
     */
    public function getFunctionNS($name, $namespace = null)
    {
        foreach ($this->functions as $function) {
            if ($function->getName() == $name && $function->getNamespace() == $namespace) {
                return $function;
            }
        }

        return false;
    }

    /**
     * @param string $name
     * @return TraitDefinition|null
     */
    public function getTrait($name)
    {
        if (isset($this->traits[$name])) {
            return $this->traits[$name];
        }

        return null;
    }

    /**
     * Try to find function from pre-compiled function(s)
     *
     * @param string $name
     * @return bool|FunctionDefinition
     */
    public function getFunction($name)
    {
        foreach ($this->functions as $function) {
            if ($function->getName() == $name) {
                return $function;
            }
        }

        return false;
    }
}


1		<?php
2		/**
3		* @author Patsura Dmitry https://github.com/ovr <[email protected]>
4		*/
5
6		namespace PHPSA;
7
8		use PHPSA\Definition\ClassDefinition;
9		use PHPSA\Definition\FunctionDefinition;
10		use PHPSA\Definition\RuntimeClassDefinition;
11		use PHPSA\Definition\TraitDefinition;
12		use ReflectionClass;
13
14		class Compiler
15		{
16		/**
17		* @var ClassDefinition[]
18		*/
19		protected $classes = [];
20
21		/**
22		* @var TraitDefinition[]
23		*/
24		protected $traits = [];
25
26		/**
27		* @var FunctionDefinition[]
28		*/
29		protected $functions = [];
30
31		/**
32		* @param ClassDefinition $class
33		*/
34	46	public function addClass(ClassDefinition $class)
35		{
36	46	$this->classes[implode('\\', [$class->getNamespace(), $class->getName()])] = $class;
37	46	}
38
39		/**
40		* @param TraitDefinition $class
41		*/
42	1	public function addTrait(TraitDefinition $class)
43		{
44	1	$this->traits[implode('\\', [$class->getNamespace(), $class->getName()])] = $class;
45	1	}
46
47		/**
48		* @param FunctionDefinition $function
49		*/
50	5	public function addFunction(FunctionDefinition $function)
51		{
52	5	$this->functions[] = $function;
53	5	}
54
55		/**
56		* @param Context $context
57		*/
58	46	public function compile(Context $context)
		0 ignored issues – show Complexity introduced 2016-10-02 12:14 UTC by Report Bug Copy Issue Report This operation has 320 execution paths which exceeds the configured maximum of 200. A high number of execution paths generally suggests many nested conditional statements and make the code less readible. This can usually be fixed by splitting the method into several smaller methods. You can also find more information in the “Code” section of your repository. Loading history...
59		{
60	46	$context->scopePointer = null;
61
62		/**
63		* @todo Implement class map...
64		*/
65	46	foreach ($this->classes as $class) {
66	46	$extends = $class->getExtendsClass();
67	46	if ($extends) {
		0 ignored issues – show Bug Best Practice introduced 2015-11-22 15:25 UTC by Report Bug Copy Issue Report The expression `$extends` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
68		if (isset($this->classes[$extends])) {
69		$class->setExtendsClassDefinition($this->classes[$extends]);
70		} else {
71		if (class_exists($extends, true)) {
72		$class->setExtendsClassDefinition(
73		new RuntimeClassDefinition(
74		new ReflectionClass(
75		$extends
76		)
77		)
78		);
79		}
80		}
81		}
82	46	}
83
84	46	foreach ($this->functions as $function) {
85		/**
86		* @todo Configuration
87		*
88		* Ignore functions compiling from vendor
89		*/
90	5	$checkVendor = strpos($function->getFilepath(), './vendor');
91	5	if ($checkVendor !== false && $checkVendor < 3) {
92		continue;
93	1	}
94
95	5	$function->compile($context);
96	46	}
97
98	46	foreach ($this->traits as $trait) {
99		/**
100		* @todo Configuration
101		*
102		* Ignore traits compiling from vendor
103		*/
104	1	$checkVendor = strpos($trait->getFilepath(), './vendor');
105	1	if ($checkVendor !== false && $checkVendor < 3) {
106		continue;
107		}
108
109	1	$trait->compile($context);
110	46	}
111
112	46	foreach ($this->classes as $class) {
113		/**
114		* @todo Configuration
115		*
116		* Ignore Classes compiling from vendor
117		*/
118	46	$checkVendor = strpos($class->getFilepath(), './vendor');
119	46	if ($checkVendor !== false && $checkVendor < 3) {
120		continue;
121		}
122
123	46	$class->compile($context);
124	46	}
125	46	}
126
127		/**
128		* Try to find function with $namespace from pre-compiled function(s)
129		*
130		* @param string $name
131		* @param string\|null $namespace
132		* @return bool\|FunctionDefinition
133		*/
134	9	public function getFunctionNS($name, $namespace = null)
135		{
136	9	foreach ($this->functions as $function) {
137	1	if ($function->getName() == $name && $function->getNamespace() == $namespace) {
138		return $function;
139		}
140	9	}
141
142	9	return false;
143		}
144
145		/**
146		* @param string $name
147		* @return TraitDefinition\|null
148		*/
149		public function getTrait($name)
150		{
151		if (isset($this->traits[$name])) {
152		return $this->traits[$name];
153		}
154
155		return null;
156		}
157
158		/**
159		* Try to find function from pre-compiled function(s)
160		*
161		* @param string $name
162		* @return bool\|FunctionDefinition
163		*/
164	1	public function getFunction($name)
165		{
166	1	foreach ($this->functions as $function) {
167	1	if ($function->getName() == $name) {
168		return $function;
169		}
170	1	}
171
172	1	return false;
173		}
174		}
175

ovr / phpsa

Pull Request — master (#264)

Compiler::compile() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like