CheckLNumberKind::pass() - Code Metrics - Inspection of "Added the ability to register analyzers to Node\Sc..." - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#232)

unknown

created 2016-10-11 13:34 UTC

CheckLNumberKind::pass() A

↳ Parent: CheckLNumberKind

Complexity

Conditions	2
Paths	2

Size

Total Lines	15
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
cc	2
eloc	10
nc	2
nop	2
dl	0
loc	15
ccs	0
cts	10
cp	0
crap	6
rs	9.4285
c	0
b	0
f	0

<?php

namespace PHPSA\Analyzer\Pass\Scalar;

use PhpParser\Node\Scalar;
use PHPSA\Analyzer\Helper\DefaultMetadataPassTrait;
use PHPSA\Analyzer\Pass\AnalyzerPassInterface;
use PHPSA\Context;

class CheckLNumberKind implements AnalyzerPassInterface
{
    use DefaultMetadataPassTrait;

    /**
     * @param Scalar\LNumber $lNum
     * @param Context $context
     * @return bool
     */
    public function pass(Scalar\LNumber $lNum, Context $context)
    {
        error_log('*************************');
        var_dump($lNum->getAttribute('kind'));

        if ($lNum->getAttribute('kind') != Scalar\LNumber::KIND_DEC) {
            $context->notice(
                'l_number_kind',
                'Avoid using octal, hexadecimal or binary',
                $lNum
            );
            return true;
        }

        return true;
    }

    /**
     * @return array
     */
    public function getRegister()
    {
        return [
            Scalar\LNumber::class,
        ];
    }
}


1		<?php
2
3		namespace PHPSA\Analyzer\Pass\Scalar;
4
5		use PhpParser\Node\Scalar;
6		use PHPSA\Analyzer\Helper\DefaultMetadataPassTrait;
7		use PHPSA\Analyzer\Pass\AnalyzerPassInterface;
8		use PHPSA\Context;
9
10		class CheckLNumberKind implements AnalyzerPassInterface
11		{
12		use DefaultMetadataPassTrait;
13
14		/**
15		* @param Scalar\LNumber $lNum
16		* @param Context $context
17		* @return bool
18		*/
19		public function pass(Scalar\LNumber $lNum, Context $context)
20		{
21		error_log('*************************');
22		var_dump($lNum->getAttribute('kind'));
		0 ignored issues – show Security Debugging Code introduced 2016-10-11 13:39 UTC by Report Bug Copy Issue Report `var_dump($lNum->getAttribute('kind'));` looks like debug code. Are you sure you do not want to remove it? This might expose sensitive data. Loading history...
23		if ($lNum->getAttribute('kind') != Scalar\LNumber::KIND_DEC) {
24		$context->notice(
25		'l_number_kind',
26		'Avoid using octal, hexadecimal or binary',
27		$lNum
28		);
29		return true;
30		}
31
32		return true;
33		}
34
35		/**
36		* @return array
37		*/
38	1	public function getRegister()
39		{
40		return [
41	1	Scalar\LNumber::class,
42	1	];
43		}
44		}
45

ovr / phpsa

Pull Request — master (#232)

CheckLNumberKind::pass() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like