ConstantNaming::pass() - Code Metrics - Inspection of "Add ConstantNaming analyzer" - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#132)

by Enrico

created 2016-09-17 10:35 UTC

ConstantNaming::pass() A

↳ Parent: ConstantNaming

Complexity

Conditions	3
Paths	3

Size

Total Lines	17
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	10
c	1
b	0
f	0
nc	3
nop	2
dl	0
loc	17
ccs	12
cts	12
cp	1
crap	3
rs	9.4285

<?php

namespace PHPSA\Analyzer\Pass\Statement;

use PhpParser\Node\Stmt\ClassConst;
use PHPSA\Analyzer\Pass\AnalyzerPassInterface;
use PHPSA\Analyzer\Pass\ConfigurablePassInterface;
use PHPSA\Context;
use Symfony\Component\Config\Definition\Builder\TreeBuilder;

class ConstantNaming implements ConfigurablePassInterface, AnalyzerPassInterface
{
    /**
     * @param ClassConst $stmt
     * @param Context $context
     * @return bool
     */
    public function pass(ClassConst $stmt, Context $context)
    {
        $result = false;
        foreach ($stmt->consts as $const) {
            if ($const->name !== strtoupper($const->name)) {
                $context->notice(
                    'constant.naming',
                    'Constant names should be all uppercase.',
                    $stmt
                );

                $result = true;
            }
        }
        
        return $result;
    }

    /**
     * @return TreeBuilder
     */
    public function getConfiguration()
    {
        $treeBuilder = new TreeBuilder();
        $treeBuilder->root('constant_naming')
            ->canBeDisabled()
        ;

        return $treeBuilder;
    }

    /**
     * @return array
     */
    public function getRegister()
    {
        return [
            ClassConst::class
        ];
    }
}


1		<?php
2
3		namespace PHPSA\Analyzer\Pass\Statement;
4
5		use PhpParser\Node\Stmt\ClassConst;
6		use PHPSA\Analyzer\Pass\AnalyzerPassInterface;
7		use PHPSA\Analyzer\Pass\ConfigurablePassInterface;
8		use PHPSA\Context;
9		use Symfony\Component\Config\Definition\Builder\TreeBuilder;
10
11		class ConstantNaming implements ConfigurablePassInterface, AnalyzerPassInterface
12		{
13		/**
14		* @param ClassConst $stmt
15		* @param Context $context
16		* @return bool
17		*/
18	1	public function pass(ClassConst $stmt, Context $context)
19		{
20	1	$result = false;
21	1	foreach ($stmt->consts as $const) {
22	1	if ($const->name !== strtoupper($const->name)) {
23	1	$context->notice(
24	1	'constant.naming',
25	1	'Constant names should be all uppercase.',
26		$stmt
27	1	);
28
29	1	$result = true;
30	1	}
31	1	}
32
33	1	return $result;
34		}
35
36		/**
37		* @return TreeBuilder
38		*/
39		public function getConfiguration()
40		{
41		$treeBuilder = new TreeBuilder();
42		$treeBuilder->root('constant_naming')
43		->canBeDisabled()
44		;
45
46		return $treeBuilder;
47		}
48
49		/**
50		* @return array
51		*/
52	1	public function getRegister()
53		{
54		return [
55		ClassConst::class
56	1	];
57		}
58		}
59

ovr / phpsa

Pull Request — master (#132)

ConstantNaming::pass() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like