Mul::compile() - Code Metrics - Inspection of "[Compiler] Add AssignOp tests" - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 558809...774145 )

by Дмитрий

created 2016-09-17 10:50 UTC

Mul::compile() C

↳ Parent: Mul

Complexity

Conditions	9
Paths	21

Size

Total Lines	23
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	18
CRAP Score	9

Importance

Changes

Metric	Value
cc	9
eloc	17
nc	21
nop	2
dl	0
loc	23
ccs	18
cts	18
cp	1
crap	9
rs	5.8541
c	0
b	0
f	0

<?php

namespace PHPSA\Compiler\Expression\AssignOp;

use PHPSA\CompiledExpression;
use PHPSA\Compiler\Expression;
use PHPSA\Compiler\Expression\AbstractExpressionCompiler;
use PHPSA\Context;

class Mul extends AbstractExpressionCompiler
{
    protected $name = 'PhpParser\Node\Expr\AssignOp\Mul';

    /**
     * {left-expr} *= {right-expr}
     *
     * @param \PhpParser\Node\Expr\AssignOp\Mul $expr
     * @param Context $context
     * @return CompiledExpression
     */
    protected function compile($expr, Context $context)
    {
        $left = $context->getExpressionCompiler()->compile($expr->var);
        $expExpression = $context->getExpressionCompiler()->compile($expr->expr);

        switch ($left->getType()) {
            case CompiledExpression::INTEGER:
            case CompiledExpression::DOUBLE:
            case CompiledExpression::NUMBER:
            case CompiledExpression::BOOLEAN:
                switch ($expExpression->getType()) {
                    case CompiledExpression::INTEGER:
                    case CompiledExpression::DOUBLE:
                    case CompiledExpression::NUMBER:
                    case CompiledExpression::BOOLEAN:
                        return CompiledExpression::fromZvalValue($left->getValue() * $expExpression->getValue());
                        break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
                }
                break;
        }
        
        return new CompiledExpression(CompiledExpression::UNKNOWN);
    }
}


1		<?php
2
3		namespace PHPSA\Compiler\Expression\AssignOp;
4
5		use PHPSA\CompiledExpression;
6		use PHPSA\Compiler\Expression;
7		use PHPSA\Compiler\Expression\AbstractExpressionCompiler;
8		use PHPSA\Context;
9
10		class Mul extends AbstractExpressionCompiler
11		{
12		protected $name = 'PhpParser\Node\Expr\AssignOp\Mul';
13
14		/**
15		* {left-expr} *= {right-expr}
16		*
17		* @param \PhpParser\Node\Expr\AssignOp\Mul $expr
18		* @param Context $context
19		* @return CompiledExpression
20		*/
21	20	protected function compile($expr, Context $context)
22		{
23	20	$left = $context->getExpressionCompiler()->compile($expr->var);
24	20	$expExpression = $context->getExpressionCompiler()->compile($expr->expr);
25
26	20	switch ($left->getType()) {
27	20	case CompiledExpression::INTEGER:
28	20	case CompiledExpression::DOUBLE:
29	20	case CompiledExpression::NUMBER:
30	20	case CompiledExpression::BOOLEAN:
31	19	switch ($expExpression->getType()) {
32	19	case CompiledExpression::INTEGER:
33	19	case CompiledExpression::DOUBLE:
34	19	case CompiledExpression::NUMBER:
35	19	case CompiledExpression::BOOLEAN:
36	18	return CompiledExpression::fromZvalValue($left->getValue() * $expExpression->getValue());
37		break;
		0 ignored issues – show Unused Code introduced 2016-09-13 12:43 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
38	1	}
39	1	break;
40	2	}
41
42	2	return new CompiledExpression(CompiledExpression::UNKNOWN);
43		}
44		}
45

ovr / phpsa

Push — master ( 558809...774145 )

Mul::compile() C

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like