ClassDefintionTest::testSetGetHasForClassProperty() - Code Metrics - Inspection of "Merge pull request #101 from K-Phoen/fix-propertie..." - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 781244...9f496f )

by Дмитрий

created 2016-09-08 14:12 UTC

testSetGetHasForClassProperty() A

↳ Parent: ClassDefintionTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	53
Code Lines	34

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
cc	1
eloc	34
c	1
b	1
f	0
nc	1
nop	0
dl	0
loc	53
rs	9.5797

How to fix Long Method

<?php

namespace Tests\PHPSA\Defintion;

use PHPSA\Definition\ClassDefinition;
use Tests\PHPSA\TestCase;

class ClassDefintionTest extends TestCase
{
    /**
     * @return ClassDefinition
     */
    protected function getSimpleInstance()
    {
        return new ClassDefinition('MyTestClass', 0);
    }

    public function testSimpleInstance()
    {
        $classDefinition = $this->getSimpleInstance();
        $this->assertSame('MyTestClass', $classDefinition->getName());
        $this->assertFalse($classDefinition->isCompiled());
    }

    public function testScopePointer()
    {
        $classDefinition = $this->getSimpleInstance();

        $pointer = $classDefinition->getPointer();
        $this->assertInstanceOf('PHPSA\ScopePointer', $pointer);
        $this->assertEquals($classDefinition, $pointer->getObject());
    }

    public function testSetGetHasForClassProperty()
    {
        $classDefinition = $this->getSimpleInstance();
        $this->assertFalse($classDefinition->hasProperty('test1'));
        $this->assertFalse($classDefinition->hasProperty('test2'));

        $property = new \PhpParser\Node\Stmt\Property(
            0,
            array(
                new \PhpParser\Node\Stmt\PropertyProperty(
                    'test1',
                    new \PhpParser\Node\Scalar\String_(
                        'test string'
                    )
                )
            )
        );
        $classDefinition->addProperty($property);

        $this->assertTrue($classDefinition->hasProperty('test1'));
        $this->assertFalse($classDefinition->hasProperty('test2'));

        $property = new \PhpParser\Node\Stmt\Property(
            0,
            array(
                new \PhpParser\Node\Stmt\PropertyProperty(
                    'test2',
                    new \PhpParser\Node\Scalar\String_(
                        'test string'
                    )
                )
            )
        );
        $classDefinition->addProperty($property);

        $this->assertTrue($classDefinition->hasProperty('test1'));
        $this->assertTrue($classDefinition->hasProperty('test2'));

        $property = new \PhpParser\Node\Stmt\Property(0, [
            new \PhpParser\Node\Stmt\PropertyProperty(
                'foo',
                new \PhpParser\Node\Scalar\String_('test string')
            ),
            new \PhpParser\Node\Stmt\PropertyProperty(
                'bar',
                new \PhpParser\Node\Scalar\String_('test string')
            )
        ]);
        $classDefinition->addProperty($property);

        $this->assertTrue($classDefinition->hasProperty('foo'));
        $this->assertTrue($classDefinition->hasProperty('bar'));
    }

    public function testMethodSetGet()
    {
        $classDefinition = $this->getSimpleInstance();
        $methodName = 'method1';
        $nonExistsMethodName = 'method2';

        $this->assertFalse($classDefinition->hasMethod($methodName));
        $this->assertFalse($classDefinition->hasMethod($nonExistsMethodName));

        $classDefinition->addMethod(
            new \PHPSA\Definition\ClassMethod(
                $methodName,
                new \PhpParser\Node\Stmt\ClassMethod(
                    $methodName
                ),
                0
            )
        );

        $this->assertTrue($classDefinition->hasMethod($methodName));
        $this->assertFalse($classDefinition->hasMethod($nonExistsMethodName));

        $method = $classDefinition->getMethod($methodName);
        $this->assertInstanceOf('PHPSA\Definition\ClassMethod', $method);
        $this->assertSame($methodName, $method->getName());

        return $classDefinition;
    }
}


1			<?php
2
3			namespace Tests\PHPSA\Defintion;
4
5			use PHPSA\Definition\ClassDefinition;
6			use Tests\PHPSA\TestCase;
7
8			class ClassDefintionTest extends TestCase
9			{
10			/**
11			* @return ClassDefinition
12			*/
13			protected function getSimpleInstance()
14			{
15			return new ClassDefinition('MyTestClass', 0);
16			}
17
18			public function testSimpleInstance()
19			{
20			$classDefinition = $this->getSimpleInstance();
21			$this->assertSame('MyTestClass', $classDefinition->getName());
22			$this->assertFalse($classDefinition->isCompiled());
23			}
24
25			public function testScopePointer()
26			{
27			$classDefinition = $this->getSimpleInstance();
28
29			$pointer = $classDefinition->getPointer();
30			$this->assertInstanceOf('PHPSA\ScopePointer', $pointer);
31			$this->assertEquals($classDefinition, $pointer->getObject());
32			}
33
34			public function testSetGetHasForClassProperty()
35			{
36			$classDefinition = $this->getSimpleInstance();
37			$this->assertFalse($classDefinition->hasProperty('test1'));
38			$this->assertFalse($classDefinition->hasProperty('test2'));
39
40			$property = new \PhpParser\Node\Stmt\Property(
41			0,
42			array(
43			new \PhpParser\Node\Stmt\PropertyProperty(
44			'test1',
45			new \PhpParser\Node\Scalar\String_(
46			'test string'
47			)
48			)
49			)
50			);
51			$classDefinition->addProperty($property);
52
53			$this->assertTrue($classDefinition->hasProperty('test1'));
54			$this->assertFalse($classDefinition->hasProperty('test2'));
55
56			$property = new \PhpParser\Node\Stmt\Property(
57			0,
58			array(
59			new \PhpParser\Node\Stmt\PropertyProperty(
60			'test2',
61			new \PhpParser\Node\Scalar\String_(
62			'test string'
63			)
64			)
65			)
66			);
67			$classDefinition->addProperty($property);
68
69			$this->assertTrue($classDefinition->hasProperty('test1'));
70			$this->assertTrue($classDefinition->hasProperty('test2'));
71
72			$property = new \PhpParser\Node\Stmt\Property(0, [
73			new \PhpParser\Node\Stmt\PropertyProperty(
74			'foo',
75			new \PhpParser\Node\Scalar\String_('test string')
76			),
77			new \PhpParser\Node\Stmt\PropertyProperty(
78			'bar',
79			new \PhpParser\Node\Scalar\String_('test string')
80			)
81			]);
82			$classDefinition->addProperty($property);
83
84			$this->assertTrue($classDefinition->hasProperty('foo'));
85			$this->assertTrue($classDefinition->hasProperty('bar'));
86			}
87
88			public function testMethodSetGet()
89			{
90			$classDefinition = $this->getSimpleInstance();
91			$methodName = 'method1';
92			$nonExistsMethodName = 'method2';
93
94			$this->assertFalse($classDefinition->hasMethod($methodName));
95			$this->assertFalse($classDefinition->hasMethod($nonExistsMethodName));
96
97			$classDefinition->addMethod(
98			new \PHPSA\Definition\ClassMethod(
99			$methodName,
100			new \PhpParser\Node\Stmt\ClassMethod(
101			$methodName
102			),
103			0
104			)
105			);
106
107			$this->assertTrue($classDefinition->hasMethod($methodName));
108			$this->assertFalse($classDefinition->hasMethod($nonExistsMethodName));
109
110			$method = $classDefinition->getMethod($methodName);
111			$this->assertInstanceOf('PHPSA\Definition\ClassMethod', $method);
112			$this->assertSame($methodName, $method->getName());
113
114			return $classDefinition;
115			}
116			}
117

ovr / phpsa

Push — master ( 781244...9f496f )

testSetGetHasForClassProperty() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like