PHPSA\Analyzer\Pass\Expression\VariableVariableUsage

Complexity

Total Complexity

21

Size/Duplication

Total Lines	117
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	8

Test Coverage

Coverage

89.8%

Importance

Changes	1
Bugs	0	Features	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	pass()	0	15	3
A	analyzeAssign()	0	9	2
A	analyzeList()	0	15	4
A	analyzePropertyFetch()	0	9	2
A	analyzeVar()	0	10	2
A	notice()	0	4	1
A	getRegister()	0	6	1
A	getConfiguration()	0	9	1
B	analyzeArrayDimFetch()	0	18	5

<?php
/**
 * @author Kévin Gomez https://github.com/K-Phoen <contact@kevingomez.fr>
 */

namespace PHPSA\Analyzer\Pass\Expression;

use PhpParser\Node\Expr;
use PHPSA\Analyzer\Pass;
use PHPSA\Context;
use Symfony\Component\Config\Definition\Builder\TreeBuilder;

class VariableVariableUsage implements Pass\AnalyzerPassInterface, Pass\ConfigurablePassInterface
{
    /**
     * @param Expr\Assign $expr
     * @param Context $context
     * @return bool
     */
    public function pass(Expr\Assign $expr, Context $context)
    {
        // $(this->)something[] = …
        if ($expr->var instanceof Expr\ArrayDimFetch) {
            return $this->analyzeArrayDimFetch($expr->var, $context);
        }

        // $this->something = …
        if ($expr->var instanceof Expr\PropertyFetch) {
            return $this->analyzePropertyFetch($expr->var, $context);
        }

        // $something = …
        return $this->analyzeAssign($expr, $context);
    }

    private function analyzeAssign(Expr\Assign $expr, Context $context)
    {
        // list($a, $b) = …
        if ($expr->var instanceof Expr\List_) {
            return $this->analyzeList($expr->var, $context);
        }

        return $this->analyzeVar($expr->var, $context);

$expr->var of type object<PhpParser\Node\Expr> is not a sub-type of object<PhpParser\Node\Expr\Variable>. It seems like you assume a child class of the class PhpParser\Node\Expr to be always present.

    }

    private function analyzeList(Expr\List_ $expr, Context $context)
    {
        $result = false;

        foreach ($expr->vars as $var) {
            // list($a, ) = …
            if (!$var) {
                continue;
            }

            $result = $this->analyzeVar($var, $context) || $result;

$var of type object<PhpParser\Node\Expr> is not a sub-type of object<PhpParser\Node\Expr\Variable>. It seems like you assume a child class of the class PhpParser\Node\Expr to be always present.

        }

        return $result;
    }

    private function analyzeArrayDimFetch(Expr\ArrayDimFetch $expr, Context $context)
    {
        $result = false;

        // $array[] = …
        if ($expr->var instanceof Expr\Variable) {
            $result = $this->analyzeVar($expr->var, $context);
        } else if ($expr->var instanceof Expr\PropertyFetch) {
            // $this->array[] = …
            $result = $this->analyzePropertyFetch($expr->var, $context);
        }

        if ($expr->dim instanceof Expr\Variable) {
            $result = $this->analyzeVar($expr->dim, $context) || $result;
        }

        return $result;
    }

    private function analyzePropertyFetch(Expr\PropertyFetch $expr, Context $context)
    {
        if ($expr->name instanceof Expr\Variable) {
            $this->notice($context, $expr->name);
            return true;
        }

        return false;
    }

    private function analyzeVar(Expr\Variable $var, Context $context)
    {
        if (!$var->name instanceof Expr\Variable) {
            return false;
        }

        $this->notice($context, $var);

        return true;
    }

    private function notice(Context $context, Expr $expr)
    {
        $context->notice('variable.dynamic_assignment', 'Dynamic assignment is greatly discouraged.', $expr);
    }

    /**
     * @return array
     */
    public function getRegister()
    {
        return [
            Expr\Assign::class
        ];
    }

    /**
     * @return TreeBuilder
     */
    public function getConfiguration()
    {
        $treeBuilder = new TreeBuilder();
        $treeBuilder->root('variable.dynamic_assignment')
            ->canBeDisabled()
        ;

        return $treeBuilder;
    }
}