OldConstructor::pass() - Code Metrics - Inspection of "Allow analyzers to be configured" - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#139)

by Kévin

created 2016-09-18 10:43 UTC

OldConstructor::pass() A

↳ Parent: OldConstructor

Complexity

Conditions	4
Paths	3

Size

Total Lines	16
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	4

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	4
eloc	10
c	1
b	0
f	0
nc	3
nop	2
dl	0
loc	16
ccs	11
cts	11
cp	1
crap	4
rs	9.2

<?php

namespace PHPSA\Analyzer\Pass\Statement;

use PhpParser\Node\Stmt;
use PHPSA\Analyzer\Helper\ConfigurablePassTrait;
use PHPSA\Analyzer\Pass\AnalyzerPassInterface;
use PHPSA\Analyzer\Pass\ConfigurablePassInterface;
use PHPSA\Context;

class OldConstructor implements ConfigurablePassInterface, AnalyzerPassInterface
{
    use ConfigurablePassTrait;

    /**
     * @param Stmt\Class_ $classStmt
     * @param Context $context
     * @return bool
     */
    public function pass(Stmt\Class_ $classStmt, Context $context)
    {
        foreach ($classStmt->stmts as $statement) {
            if (!($statement instanceof Stmt\ClassMethod) || $statement->name !== $classStmt->name) {
                continue;
            }
            $context->notice(
                'deprecated.constructor',
                sprintf('Class %s uses a PHP4 constructor.', $classStmt->name),
                $classStmt
            );
            return true;
        }

        return false;
    }

    /**
     * @return array
     */
    public function getRegister()
    {
        return [
            Stmt\Class_::class
        ];
    }
}


1		<?php
2
3		namespace PHPSA\Analyzer\Pass\Statement;
4
5		use PhpParser\Node\Stmt;
6		use PHPSA\Analyzer\Helper\ConfigurablePassTrait;
7		use PHPSA\Analyzer\Pass\AnalyzerPassInterface;
8		use PHPSA\Analyzer\Pass\ConfigurablePassInterface;
9		use PHPSA\Context;
10
11		class OldConstructor implements ConfigurablePassInterface, AnalyzerPassInterface
12		{
13		use ConfigurablePassTrait;
14
15		/**
16		* @param Stmt\Class_ $classStmt
17		* @param Context $context
18		* @return bool
19		*/
20	19	public function pass(Stmt\Class_ $classStmt, Context $context)
21		{
22	19	foreach ($classStmt->stmts as $statement) {
23	19	if (!($statement instanceof Stmt\ClassMethod) \|\| $statement->name !== $classStmt->name) {
24	19	continue;
25		}
26	1	$context->notice(
27	1	'deprecated.constructor',
28	1	sprintf('Class %s uses a PHP4 constructor.', $classStmt->name),
29		$classStmt
30	1	);
31	1	return true;
32	19	}
33
34	19	return false;
35		}
36
37		/**
38		* @return array
39		*/
40	1	public function getRegister()
41		{
42		return [
43		Stmt\Class_::class
44	1	];
45		}
46		}
47

ovr / phpsa

Pull Request — master (#139)

OldConstructor::pass() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like