MethodCannotReturn::pass() - Code Metrics - Inspection of "Allow analyzers to be configured" - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#139)

by Kévin

created 2016-09-18 10:43 UTC

MethodCannotReturn::pass() B

↳ Parent: MethodCannotReturn

Complexity

Conditions	6
Paths	3

Size

Total Lines	26
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	15
CRAP Score	6.0087

Importance

Changes	3
Bugs	0	Features	1

Metric	Value
cc	6
eloc	14
c	3
b	0
f	1
nc	3
nop	2
dl	0
loc	26
ccs	15
cts	16
cp	0.9375
crap	6.0087
rs	8.439

<?php
/**
 * @author Patsura Dmitry https://github.com/ovr <[email protected]>
 */

namespace PHPSA\Analyzer\Pass\Statement;

use PhpParser\Node\Stmt\ClassMethod;
use PHPSA\Analyzer\Helper\ConfigurablePassTrait;
use PHPSA\Analyzer\Helper\ResolveExpressionTrait;
use PHPSA\Analyzer\Pass\AnalyzerPassInterface;
use PHPSA\Analyzer\Pass\ConfigurablePassInterface;
use PHPSA\Context;

class MethodCannotReturn implements ConfigurablePassInterface, AnalyzerPassInterface
{
    use ConfigurablePassTrait;
    use ResolveExpressionTrait;

    /**
     * @param ClassMethod $methodStmt
     * @param Context $context
     * @return bool
     */
    public function pass(ClassMethod $methodStmt, Context $context)
    {
        if (count($methodStmt->stmts) == 0) {
            return false;
        }

        $result = false;

        if ($methodStmt->name == '__construct' || $methodStmt->name == '__destruct') {
            foreach ($this->findReturnStatement($methodStmt->stmts) as $returnStmt) {
                if (!$returnStmt->expr) {
                    continue;
                }

                $context->notice(
                    'return.construct',
                    sprintf('Method %s cannot return a value.', $methodStmt->name),
                    $returnStmt
                );

                $result = true;
            }
        }

        return $result;
    }

    /**
     * @return array
     */
    public function getRegister()
    {
        return [
            \PhpParser\Node\Stmt\ClassMethod::class
        ];
    }
}


1		<?php
2		/**
3		* @author Patsura Dmitry https://github.com/ovr <[email protected]>
4		*/
5
6		namespace PHPSA\Analyzer\Pass\Statement;
7
8		use PhpParser\Node\Stmt\ClassMethod;
9		use PHPSA\Analyzer\Helper\ConfigurablePassTrait;
10		use PHPSA\Analyzer\Helper\ResolveExpressionTrait;
11		use PHPSA\Analyzer\Pass\AnalyzerPassInterface;
12		use PHPSA\Analyzer\Pass\ConfigurablePassInterface;
13		use PHPSA\Context;
14
15		class MethodCannotReturn implements ConfigurablePassInterface, AnalyzerPassInterface
16		{
17		use ConfigurablePassTrait;
18		use ResolveExpressionTrait;
19
20		/**
21		* @param ClassMethod $methodStmt
22		* @param Context $context
23		* @return bool
24		*/
25	19	public function pass(ClassMethod $methodStmt, Context $context)
26		{
27	19	if (count($methodStmt->stmts) == 0) {
28	1	return false;
29		}
30
31	19	$result = false;
32
33	19	if ($methodStmt->name == '__construct' \|\| $methodStmt->name == '__destruct') {
34	2	foreach ($this->findReturnStatement($methodStmt->stmts) as $returnStmt) {
35	1	if (!$returnStmt->expr) {
36		continue;
37		}
38
39	1	$context->notice(
40	1	'return.construct',
41	1	sprintf('Method %s cannot return a value.', $methodStmt->name),
42		$returnStmt
43	1	);
44
45	1	$result = true;
46	2	}
47	2	}
48
49	19	return $result;
50		}
51
52		/**
53		* @return array
54		*/
55	1	public function getRegister()
56		{
57		return [
58		\PhpParser\Node\Stmt\ClassMethod::class
59	1	];
60		}
61		}
62

ovr / phpsa

Pull Request — master (#139)

MethodCannotReturn::pass() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like