MethodCannotReturn::pass() - Code Metrics - Inspection of "Working on Configuration by file, refs #39" - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b1b3d7...ed93a7 )

by Дмитрий

created 2016-05-22 08:14 UTC

MethodCannotReturn::pass() C

↳ Parent: MethodCannotReturn

Complexity

Conditions	7
Paths	3

Size

Total Lines	28
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	25.4573

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
cc	7
eloc	15
c	2
b	0
f	1
nc	3
nop	2
dl	0
loc	28
ccs	5
cts	18
cp	0.2778
crap	25.4573
rs	6.7272

<?php
/**
 * @author Patsura Dmitry https://github.com/ovr <[email protected]>
 */

namespace PHPSA\Analyzer\Pass\Statement;

use PhpParser\Node\Stmt\ClassMethod;
use PhpParser\Node\Stmt\Return_;
use PHPSA\Analyzer\Pass\ConfigurablePassInterface;
use PHPSA\Context;
use Symfony\Component\Config\Definition\Builder\TreeBuilder;

class MethodCannotReturn implements ConfigurablePassInterface
{
    /**
     * @param ClassMethod $methodStmt
     * @param Context $context
     * @return bool
     */
    public function pass(ClassMethod $methodStmt, Context $context)
    {
        if (count($methodStmt->stmts) == 0) {
            return false;
        }

        $result = false;

        if ($methodStmt->name == '__construct' || $methodStmt->name == '__destruct') {
            foreach ($methodStmt->stmts as $stmt) {
                if ($stmt instanceof Return_) {
                    if (!$stmt->expr) {
                        continue;
                    }

                    $context->notice(
                        'return.construct',
                        sprintf('Method %s cannot return a value.', $methodStmt->name),
                        $stmt
                    );

                    $result = true;
                }
            }
        }

        return $result;
    }

    /**
     * @return TreeBuilder
     */
    public function getConfiguration()
    {
        $treeBuilder = new TreeBuilder();
        $treeBuilder->root('method_cannot_return')
            ->canBeDisabled()
        ;

        return $treeBuilder;
    }
}


1		<?php
2		/**
3		* @author Patsura Dmitry https://github.com/ovr <[email protected]>
4		*/
5
6		namespace PHPSA\Analyzer\Pass\Statement;
7
8		use PhpParser\Node\Stmt\ClassMethod;
9		use PhpParser\Node\Stmt\Return_;
10		use PHPSA\Analyzer\Pass\ConfigurablePassInterface;
11		use PHPSA\Context;
12		use Symfony\Component\Config\Definition\Builder\TreeBuilder;
13
14		class MethodCannotReturn implements ConfigurablePassInterface
15		{
16		/**
17		* @param ClassMethod $methodStmt
18		* @param Context $context
19		* @return bool
20		*/
21	6	public function pass(ClassMethod $methodStmt, Context $context)
22		{
23	6	if (count($methodStmt->stmts) == 0) {
24		return false;
25		}
26
27	6	$result = false;
28
29	6	if ($methodStmt->name == '__construct' \|\| $methodStmt->name == '__destruct') {
30		foreach ($methodStmt->stmts as $stmt) {
31		if ($stmt instanceof Return_) {
32		if (!$stmt->expr) {
33		continue;
34		}
35
36		$context->notice(
37		'return.construct',
38		sprintf('Method %s cannot return a value.', $methodStmt->name),
39		$stmt
40		);
41
42		$result = true;
43		}
44		}
45		}
46
47	6	return $result;
48		}
49
50		/**
51		* @return TreeBuilder
52		*/
53		public function getConfiguration()
54		{
55		$treeBuilder = new TreeBuilder();
56		$treeBuilder->root('method_cannot_return')
57		->canBeDisabled()
58		;
59
60		return $treeBuilder;
61		}
62		}
63

ovr / phpsa

Push — master ( b1b3d7...ed93a7 )

MethodCannotReturn::pass() C

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like