ClosureDefinition::compile() - Code Metrics - Inspection of "[Compiler] Allow to run ClosureDefinition, refs #6..." - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 932831...28368b )

by Дмитрий

created 2016-06-11 13:56 UTC

ClosureDefinition::compile() B

↳ Parent: ClosureDefinition

Complexity

Conditions	6
Paths	7

Size

Total Lines	34
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	42

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	6
eloc	19
c	2
b	0
f	0
nc	7
nop	1
dl	0
loc	34
ccs	0
cts	23
cp	0
crap	42
rs	8.439

<?php
/**
 * @author Patsura Dmitry https://github.com/ovr <[email protected]>
 */

namespace PHPSA\Definition;

use PHPSA\CompiledExpression;
use PHPSA\Context;
use PhpParser\Node;

/**
 * Class FunctionDefinition
 * @package PHPSA\Definition
 */
class ClosureDefinition extends ParentDefinition
{
    /**
     * @todo Use Finder
     *
     * @var string
     */
    protected $filepath;

    /**
     * @var Node\Expr\Closure
     */
    protected $statement;

    /**
     * @var int
     */
    protected $returnTypes = CompiledExpression::MIXED;

    /**
     * @var array
     */
    protected $possibleReturnTypes = array();

    protected $symbolTable = [];

    /**
     * @param Node\Expr\Closure $statement
     */
    public function __construct(Node\Expr\Closure $statement)
    {
        $this->statement = $statement;
    }

    /**
     * @param Context $context
     */
    public function preCompile(Context $context)
    {
        if ($this->statement->uses) {

            /**
             * Store variables from User to next restore Context
             */
            foreach ($this->statement->uses as $variable) {
                $variable = $context->getSymbol($variable->var);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
                if ($variable) {
                    $this->symbolTable[$variable->getName()] = clone $variable;
                }
            }
        }
    }

    /**
     * Compile function to check it
     *
     * @param Context $context
     * @return bool
     */
    public function compile(Context $context)
    {
        if ($this->compiled) {
            return true;
        }

        $context->setFilepath($this->filepath);
        $this->compiled = true;

        $context->clearSymbols();
        $context->scopePointer = $this->getPointer();
        $context->setScope(null);

        if (count($this->statement->stmts) == 0) {
            return $context->notice(
                'not-implemented-function',
                sprintf('Closure %s() is not implemented', $this->name),
                $this->statement
            );
        }

        if (count($this->statement->params) > 0) {
            /** @var  Node\Param $parameter */
            foreach ($this->statement->params as $parameter) {
                $context->addSymbol($parameter->name);
            }
        }

        foreach ($this->statement->stmts as $st) {
            \PHPSA\nodeVisitorFactory($st, $context);
        }

        return true;
    }

    /**
     * @param CompiledExpression[] $arguments
     * @param Context $context
     * @return CompiledExpression
     */
    public function run(array $arguments, Context $context)

    {
        return new CompiledExpression();
    }

    /**
     * @return string
     */
    public function getFilepath()
    {
        return $this->filepath;
    }

    /**
     * @param string $filepath
     */
    public function setFilepath($filepath)
    {
        $this->filepath = $filepath;
    }

    /**
     * @return string
     */
    public function getNamespace()
    {
        return $this->namespace;
    }
}


1			<?php
2			/**
3			* @author Patsura Dmitry https://github.com/ovr <[email protected]>
4			*/
5
6			namespace PHPSA\Definition;
7
8			use PHPSA\CompiledExpression;
9			use PHPSA\Context;
10			use PhpParser\Node;
11
12			/**
13			* Class FunctionDefinition
14			* @package PHPSA\Definition
15			*/
16			class ClosureDefinition extends ParentDefinition
17			{
18			/**
19			* @todo Use Finder
20			*
21			* @var string
22			*/
23			protected $filepath;
24
25			/**
26			* @var Node\Expr\Closure
27			*/
28			protected $statement;
29
30			/**
31			* @var int
32			*/
33			protected $returnTypes = CompiledExpression::MIXED;
34
35			/**
36			* @var array
37			*/
38			protected $possibleReturnTypes = array();
39
40			protected $symbolTable = [];
41
42			/**
43			* @param Node\Expr\Closure $statement
44			*/
45			public function __construct(Node\Expr\Closure $statement)
46			{
47			$this->statement = $statement;
48			}
49
50			/**
51			* @param Context $context
52			*/
53			public function preCompile(Context $context)
54			{
55			if ($this->statement->uses) {
			0 ignored issues – show Bug Best Practice introduced 2016-06-11 13:21 UTC by Report Bug Copy Issue Report The expression `$this->statement->uses` of type `PhpParser\Node\Expr\ClosureUse[]` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
56			/**
57			* Store variables from User to next restore Context
58			*/
59			foreach ($this->statement->uses as $variable) {
60			$variable = $context->getSymbol($variable->var);
			0 ignored issues – show Bug introduced 2016-06-11 13:21 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$variable` is correct as `$context->getSymbol($variable->var)` (which targets `PHPSA\Context::getSymbol()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
61			if ($variable) {
62			$this->symbolTable[$variable->getName()] = clone $variable;
63			}
64			}
65			}
66			}
67
68			/**
69			* Compile function to check it
70			*
71			* @param Context $context
72			* @return bool
73			*/
74			public function compile(Context $context)
75			{
76			if ($this->compiled) {
77			return true;
78			}
79
80			$context->setFilepath($this->filepath);
81			$this->compiled = true;
82
83			$context->clearSymbols();
84			$context->scopePointer = $this->getPointer();
85			$context->setScope(null);
86
87			if (count($this->statement->stmts) == 0) {
88			return $context->notice(
89			'not-implemented-function',
90			sprintf('Closure %s() is not implemented', $this->name),
91			$this->statement
92			);
93			}
94
95			if (count($this->statement->params) > 0) {
96			/** @var Node\Param $parameter */
97			foreach ($this->statement->params as $parameter) {
98			$context->addSymbol($parameter->name);
99			}
100			}
101
102			foreach ($this->statement->stmts as $st) {
103			\PHPSA\nodeVisitorFactory($st, $context);
104			}
105
106			return true;
107			}
108
109			/**
110			* @param CompiledExpression[] $arguments
111			* @param Context $context
112			* @return CompiledExpression
113			*/
114			public function run(array $arguments, Context $context)
			0 ignored issues – show Unused Code introduced 2016-06-11 14:01 UTC by Report Bug Copy Issue Report The parameter `$arguments` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2016-06-11 14:01 UTC by Report Bug Copy Issue Report The parameter `$context` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
115			{
116			return new CompiledExpression();
117			}
118
119			/**
120			* @return string
121			*/
122			public function getFilepath()
123			{
124			return $this->filepath;
125			}
126
127			/**
128			* @param string $filepath
129			*/
130			public function setFilepath($filepath)
131			{
132			$this->filepath = $filepath;
133			}
134
135			/**
136			* @return string
137			*/
138			public function getNamespace()
139			{
140			return $this->namespace;
141			}
142			}
143

ovr / phpsa

Push — master ( 932831...28368b )

ClosureDefinition::compile() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like