Completed
Pull Request — master (#229)
by Enrico
04:42
created

ForeachSt   A

Complexity

Total Complexity 4

Size/Duplication

Total Lines 26
Duplicated Lines 0 %

Coupling/Cohesion

Components 0
Dependencies 4

Test Coverage

Coverage 83.33%

Importance

Changes 1
Bugs 0 Features 0
Metric Value
dl 0
loc 26
ccs 10
cts 12
cp 0.8333
rs 10
c 1
b 0
f 0
wmc 4
lcom 0
cbo 4

1 Method

Rating   Name   Duplication   Size   Complexity  
A compile() 0 16 4
1
<?php
2
/**
3
 * @author Patsura Dmitry https://github.com/ovr <[email protected]>
4
 */
5
6
namespace PHPSA\Compiler\Statement;
7
8
use PHPSA\Context;
9
use PHPSA\CompiledExpression;
10
11
class ForeachSt extends AbstractCompiler
12
{
13
    protected $name = '\PhpParser\Node\Stmt\Foreach_';
14
15
    /**
16
     * @param \PhpParser\Node\Stmt\Foreach_ $stmt
17
     * @param Context $context
18
     * @return null|boolean
19
     */
20 2
    public function compile($stmt, Context $context)
21
    {
22 2
        $context->getExpressionCompiler()->compile($stmt->expr);
23
24 2
        if ($stmt->keyVar) {
25
            $context->getExpressionCompiler()->declareVariable($stmt->keyVar, null, CompiledExpression::MIXED);
0 ignored issues
show
Compatibility introduced by
$stmt->keyVar of type object<PhpParser\Node\Expr> is not a sub-type of object<PhpParser\Node\Expr\Variable>. It seems like you assume a child class of the class PhpParser\Node\Expr to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
26
        }
27
28 2
        if ($stmt->valueVar) {
29 2
            $context->getExpressionCompiler()->declareVariable($stmt->valueVar, null, CompiledExpression::MIXED);
0 ignored issues
show
Compatibility introduced by
$stmt->valueVar of type object<PhpParser\Node\Expr> is not a sub-type of object<PhpParser\Node\Expr\Variable>. It seems like you assume a child class of the class PhpParser\Node\Expr to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
30 2
        }
31
32 2
        foreach ($stmt->stmts as $statement) {
33 2
            \PHPSA\nodeVisitorFactory($statement, $context);
34 2
        }
35 2
    }
36
}
37