GetParametersCheck::pass() - Code Metrics - Inspection of "Allow analyzers to be configured" - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#139)

by Kévin

created 2016-09-19 19:04 UTC

GetParametersCheck::pass() C

↳ Parent: GetParametersCheck

Complexity

Conditions	7
Paths	27

Size

Total Lines	35
Code Lines	22

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	29
CRAP Score	7

Importance

Changes

Metric	Value
cc	7
eloc	22
nc	27
nop	2
dl	0
loc	35
ccs	29
cts	29
cp	1
crap	7
rs	6.7272
c	0
b	0
f	0

<?php
/**
 * @author Patsura Dmitry https://github.com/ovr <[email protected]>
 */

namespace PHPSA\Analyzer\Pass\Statement\MagicMethod;

use PhpParser\Node\Stmt\ClassMethod;
use PHPSA\Analyzer\Helper\DefaultMetadataPassTrait;
use PHPSA\Analyzer\Pass\AnalyzerPassInterface;
use PHPSA\Check;
use PHPSA\Context;

class GetParametersCheck implements AnalyzerPassInterface
{
    use DefaultMetadataPassTrait;

    /**
     * @param ClassMethod $methodStmt
     * @param Context $context
     * @return bool
     */
    public function pass(ClassMethod $methodStmt, Context $context)
    {
        if ($methodStmt->name == '__get') {
            if (count($methodStmt->params) == 0) {
                $context->notice(
                    'magic.get.wrong-parameters',
                    'Magic method __get must take 1 parameter at least',
                    $methodStmt,
                    Check::CHECK_SAFE
                );
            }
        }

        if ($methodStmt->name == '__set') {
            if (count($methodStmt->params) < 2) {
                $context->notice(
                    'magic.get.wrong-parameters',
                    'Magic method __set must take 2 parameters at least',
                    $methodStmt,
                    Check::CHECK_SAFE
                );
            }
        }

        if ($methodStmt->name == '__clone') {
            if (count($methodStmt->params) > 0) {
                $context->notice(
                    'magic.get.wrong-parameters',
                    'Magic method __clone cannot accept arguments',
                    $methodStmt,
                    Check::CHECK_SAFE
                );
            }
        }
    }

    /**
     * @return array
     */
    public function getRegister()
    {
        return [
            \PhpParser\Node\Stmt\ClassMethod::class
        ];
    }
}


1		<?php
2		/**
3		* @author Patsura Dmitry https://github.com/ovr <[email protected]>
4		*/
5
6		namespace PHPSA\Analyzer\Pass\Statement\MagicMethod;
7
8		use PhpParser\Node\Stmt\ClassMethod;
9		use PHPSA\Analyzer\Helper\DefaultMetadataPassTrait;
10		use PHPSA\Analyzer\Pass\AnalyzerPassInterface;
11		use PHPSA\Check;
12		use PHPSA\Context;
13
14		class GetParametersCheck implements AnalyzerPassInterface
15		{
16		use DefaultMetadataPassTrait;
17
18		/**
19		* @param ClassMethod $methodStmt
20		* @param Context $context
21		* @return bool
22		*/
23	20	public function pass(ClassMethod $methodStmt, Context $context)
24		{
25	20	if ($methodStmt->name == '__get') {
26	1	if (count($methodStmt->params) == 0) {
27	1	$context->notice(
28	1	'magic.get.wrong-parameters',
29	1	'Magic method __get must take 1 parameter at least',
30	1	$methodStmt,
31		Check::CHECK_SAFE
32	1	);
33	1	}
34	1	}
35
36	20	if ($methodStmt->name == '__set') {
37	1	if (count($methodStmt->params) < 2) {
38	1	$context->notice(
39	1	'magic.get.wrong-parameters',
40	1	'Magic method __set must take 2 parameters at least',
41	1	$methodStmt,
42		Check::CHECK_SAFE
43	1	);
44	1	}
45	1	}
46
47	20	if ($methodStmt->name == '__clone') {
48	1	if (count($methodStmt->params) > 0) {
49	1	$context->notice(
50	1	'magic.get.wrong-parameters',
51	1	'Magic method __clone cannot accept arguments',
52	1	$methodStmt,
53		Check::CHECK_SAFE
54	1	);
55	1	}
56	1	}
57	20	}
58
59		/**
60		* @return array
61		*/
62	1	public function getRegister()
63		{
64		return [
65		\PhpParser\Node\Stmt\ClassMethod::class
66	1	];
67		}
68		}
69

ovr / phpsa

Pull Request — master (#139)

GetParametersCheck::pass() C

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like