ExpressionBeforeCompile::getContext() - Code Metrics - Inspection of "Path to v1" - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#335)

by Дмитрий

created 2017-08-04 17:41 UTC

ExpressionBeforeCompile::getContext() A

↳ Parent: ExpressionBeforeCompile

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	0
dl	0
loc	4
ccs	0
cts	2
cp	0
crap	2
rs	10
c	0
b	0
f	0

<?php
/**
 * @author Patsura Dmitry https://github.com/ovr <[email protected]>
 */

namespace PHPSA\Compiler\Event;

use PHPSA\Context;

class ExpressionBeforeCompile extends \Webiny\Component\EventManager\Event
{
    const EVENT_NAME = 'expression.before-compile';

    /**
     * @var Context
     */
    private $context;

    /**
     * @var \PhpParser\Node\Expr
     */
    private $expression;

    public function __construct(\PhpParser\NodeAbstract $expression, Context $context)
    {
        parent::__construct();

        $this->context = $context;
        $this->expression = $expression;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
    }

    /**
     * @return \PhpParser\Node\Expr
     */
    public function getExpression()
    {
        return $this->expression;
    }

    /**
     * @return Context
     */
    public function getContext()
    {
        return $this->context;
    }
}


1			<?php
2			/**
3			* @author Patsura Dmitry https://github.com/ovr <[email protected]>
4			*/
5
6			namespace PHPSA\Compiler\Event;
7
8			use PHPSA\Context;
9
10			class ExpressionBeforeCompile extends \Webiny\Component\EventManager\Event
11			{
12			const EVENT_NAME = 'expression.before-compile';
13
14			/**
15			* @var Context
16			*/
17			private $context;
18
19			/**
20			* @var \PhpParser\Node\Expr
21			*/
22			private $expression;
23
24			public function __construct(\PhpParser\NodeAbstract $expression, Context $context)
25			{
26			parent::__construct();
27
28			$this->context = $context;
29			$this->expression = $expression;
			0 ignored issues – show Documentation Bug introduced 2016-05-14 23:25 UTC by Report Bug Copy Issue Report `$expression` is of type `object<PhpParser\NodeAbstract>`, but the property `$expression` was declared to be of type `object<PhpParser\Node\Expr>`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
30			}
31
32			/**
33			* @return \PhpParser\Node\Expr
34			*/
35			public function getExpression()
36			{
37			return $this->expression;
38			}
39
40			/**
41			* @return Context
42			*/
43			public function getContext()
44			{
45			return $this->context;
46			}
47			}
48

ovr / phpsa

Pull Request — master (#335)

ExpressionBeforeCompile::getContext() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like