ArrayDuplicateKeys::pass() - Code Metrics - Inspection of "Merge pull request #86 from K-Phoen/array-duplicat..." - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 90421b...89471b )

by Дмитрий

created 2016-09-16 02:14 UTC

ArrayDuplicateKeys::pass() C

↳ Parent: ArrayDuplicateKeys

Complexity

Conditions	7
Paths	4

Size

Total Lines	33
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	22
CRAP Score	7

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	7
eloc	19
c	1
b	0
f	0
nc	4
nop	2
dl	0
loc	33
ccs	22
cts	22
cp	1
crap	7
rs	6.7272

<?php
/**
 * @author Kévin Gomez https://github.com/K-Phoen <[email protected]>
 */

namespace PHPSA\Analyzer\Pass\Expression;

use PhpParser\Node\Expr;
use PhpParser\Node\Scalar;
use PHPSA\Analyzer\Pass;
use PHPSA\Context;
use Symfony\Component\Config\Definition\Builder\TreeBuilder;

class ArrayDuplicateKeys implements Pass\AnalyzerPassInterface, Pass\ConfigurablePassInterface
{
    /**
     * @param Expr\Array_ $expr
     * @param Context $context
     * @return bool
     */
    public function pass(Expr\Array_ $expr, Context $context)
    {
        $result = false;
        $keys = [];

        /** @var Expr\ArrayItem $item */
        foreach ($expr->items as $item) {
            $compiledKey = $context->getExpressionCompiler()->compile($item->key);
            if (!$compiledKey->isTypeKnown() || !$compiledKey->isScalar() || !$compiledKey->hasValue()) {
                continue;
            }

            $key = $compiledKey->getValue();

            if (isset($keys[$key])) {
                $context->notice(
                    'array.duplicate_keys',
                    sprintf(
                        'Duplicate array key "%s" in array definition (previously declared in line %d).',
                        $item->key instanceof Expr\Variable ? sprintf('$%s (resolved value: "%s")', $item->key->name, $key) : $key,
                        $keys[$key]->getLine()
                    ),
                    $item
                );

                $result = true;
            }

            $keys[$key] = $item;
        }

        return $result;
    }

    /**
     * @return array
     */
    public function getRegister()
    {
        return [
            Expr\Array_::class
        ];
    }

    /**
     * @return TreeBuilder
     */
    public function getConfiguration()
    {
        $treeBuilder = new TreeBuilder();
        $treeBuilder->root('array.duplicate_keys')
            ->canBeDisabled()
        ;

        return $treeBuilder;
    }
}


1		<?php
2		/**
3		* @author Kévin Gomez https://github.com/K-Phoen <[email protected]>
4		*/
5
6		namespace PHPSA\Analyzer\Pass\Expression;
7
8		use PhpParser\Node\Expr;
9		use PhpParser\Node\Scalar;
10		use PHPSA\Analyzer\Pass;
11		use PHPSA\Context;
12		use Symfony\Component\Config\Definition\Builder\TreeBuilder;
13
14		class ArrayDuplicateKeys implements Pass\AnalyzerPassInterface, Pass\ConfigurablePassInterface
15		{
16		/**
17		* @param Expr\Array_ $expr
18		* @param Context $context
19		* @return bool
20		*/
21	23	public function pass(Expr\Array_ $expr, Context $context)
22		{
23	23	$result = false;
24	23	$keys = [];
25
26		/** @var Expr\ArrayItem $item */
27	23	foreach ($expr->items as $item) {
28	9	$compiledKey = $context->getExpressionCompiler()->compile($item->key);
29	9	if (!$compiledKey->isTypeKnown() \|\| !$compiledKey->isScalar() \|\| !$compiledKey->hasValue()) {
30	7	continue;
31		}
32
33	2	$key = $compiledKey->getValue();
34
35	2	if (isset($keys[$key])) {
36	1	$context->notice(
37	1	'array.duplicate_keys',
38	1	sprintf(
39	1	'Duplicate array key "%s" in array definition (previously declared in line %d).',
40	1	$item->key instanceof Expr\Variable ? sprintf('$%s (resolved value: "%s")', $item->key->name, $key) : $key,
41	1	$keys[$key]->getLine()
42	1	),
43		$item
44	1	);
45
46	1	$result = true;
47	1	}
48
49	2	$keys[$key] = $item;
50	23	}
51
52	23	return $result;
53		}
54
55		/**
56		* @return array
57		*/
58	1	public function getRegister()
59		{
60		return [
61		Expr\Array_::class
62	1	];
63		}
64
65		/**
66		* @return TreeBuilder
67		*/
68		public function getConfiguration()
69		{
70		$treeBuilder = new TreeBuilder();
71		$treeBuilder->root('array.duplicate_keys')
72		->canBeDisabled()
73		;
74
75		return $treeBuilder;
76		}
77		}
78

ovr / phpsa

Push — master ( 90421b...89471b )

ArrayDuplicateKeys::pass() C

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like