VariableVariableUsage::pass() - Code Metrics - Inspection of "Allow analyzers to be configured" - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#139)

by Kévin

created 2016-09-28 18:36 UTC

VariableVariableUsage::pass() A

↳ Parent: VariableVariableUsage

Complexity

Conditions	3
Paths	2

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	8
nc	2
nop	2
dl	0
loc	14
ccs	8
cts	8
cp	1
crap	3
rs	9.4285
c	1
b	0
f	0

<?php
/**
 * @author Kévin Gomez https://github.com/K-Phoen <[email protected]>
 */

namespace PHPSA\Analyzer\Pass\Expression;

use PhpParser\Node\Expr;
use PHPSA\Analyzer\Helper\DefaultMetadataPassTrait;
use PHPSA\Analyzer\Pass;
use PHPSA\Context;

class VariableVariableUsage implements Pass\AnalyzerPassInterface
{
    use DefaultMetadataPassTrait;

    /**
     * @param Expr\Assign $expr
     * @param Context $context
     * @return bool
     */
    public function pass(Expr\Assign $expr, Context $context)
    {
        if ($expr->var instanceof Expr\Variable && $expr->var->name instanceof Expr\Variable) {
            $context->notice(
                'variable.dynamic_assignment',
                'Dynamic assignment is greatly discouraged.',
                $expr
            );

            return true;
        }

        return false;
    }

    /**
     * @return array
     */
    public function getRegister()
    {
        return [
            Expr\Assign::class
        ];
    }
}


1		<?php
2		/**
3		* @author Kévin Gomez https://github.com/K-Phoen <[email protected]>
4		*/
5
6		namespace PHPSA\Analyzer\Pass\Expression;
7
8		use PhpParser\Node\Expr;
9		use PHPSA\Analyzer\Helper\DefaultMetadataPassTrait;
10		use PHPSA\Analyzer\Pass;
11		use PHPSA\Context;
12
13		class VariableVariableUsage implements Pass\AnalyzerPassInterface
14		{
15		use DefaultMetadataPassTrait;
16
17		/**
18		* @param Expr\Assign $expr
19		* @param Context $context
20		* @return bool
21		*/
22	13	public function pass(Expr\Assign $expr, Context $context)
23		{
24	13	if ($expr->var instanceof Expr\Variable && $expr->var->name instanceof Expr\Variable) {
25	1	$context->notice(
26	1	'variable.dynamic_assignment',
27	1	'Dynamic assignment is greatly discouraged.',
28		$expr
29	1	);
30
31	1	return true;
32		}
33
34	13	return false;
35		}
36
37		/**
38		* @return array
39		*/
40	1	public function getRegister()
41		{
42		return [
43		Expr\Assign::class
44	1	];
45		}
46		}
47

ovr / phpsa

Pull Request — master (#139)

VariableVariableUsage::pass() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like