PHPSA\Analyzer\Pass\FunctionCall\ArrayShortDefinition

Complexity

Total Complexity

4

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Test Coverage

Coverage

0%

Importance

Changes	2
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
B	pass()	0	24	4

<?php
/**
 * @author Patsura Dmitry https://github.com/ovr <talk@dmtry.me>
 */

namespace PHPSA\Analyzer\Pass\FunctionCall;

use PhpParser\Node\Expr\FuncCall;
use PhpParser\Node\Name;
use PHPSA\Compiler\Expression;
use PHPSA\Context;

class ArrayShortDefinition implements PassFunctionCallInterface
{
    public function pass(FuncCall $funcCall, Context $context)
    {
        $compiler = $context->getExpressionCompiler();
        $funcNameCompiledExpression = $compiler->compile($funcCall->name);

The variable name $funcNameCompiledExpression exceeds the maximum configured length of 20.

        if ($funcNameCompiledExpression->isString() && $funcNameCompiledExpression->isCorrectValue()) {
            $name = $funcNameCompiledExpression->getValue();
        } else {
            $context->debug(
                'Unexpected function name type ' . $funcNameCompiledExpression->getType(),
                $funcCall->name
            );

            return false;
        }

        if ($name == 'array') {
            $context->notice(
                'array.short-syntax',
                'Please use [] (short syntax) for array definition.',
                $funcCall
            );
        }
    }
}