PHPSA\Analyzer\Pass\Expression\CompareWithArray

Complexity

Total Complexity

4

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Test Coverage

Coverage

94.12%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	pass()	0	18	3
A	getRegister()	0	9	1

<?php

namespace PHPSA\Analyzer\Pass\Expression;

use PhpParser\Node\Expr;
use PHPSA\Analyzer\Helper\DefaultMetadataPassTrait;
use PHPSA\Analyzer\Pass\AnalyzerPassInterface;
use PHPSA\Context;

class CompareWithArray implements AnalyzerPassInterface
{
    use DefaultMetadataPassTrait;

    const DESCRIPTION = 'Checks for `{type array} > 1` and similar and suggests use of `count()`.';

    /**
     * @param Expr $expr
     * @param Context $context
     * @return bool
     */
    public function pass(Expr $expr, Context $context)
    {
        $compiler = $context->getExpressionCompiler();
        $left = $compiler->compile($expr->left);

The property left does not seem to exist in PhpParser\Node\Expr.

        $right = $compiler->compile($expr->right);

The property right does not seem to exist in PhpParser\Node\Expr.

        if ($left->isArray() || $right->isArray()) {
            $context->notice(
                'compare_with_array',
                "You are comparing an array. Did you want to use count()?",
                $expr
            );

            return true;
        }
        
        return false;
    }

    /**
     * @return array
     */
    public function getRegister()
    {
        return [
            Expr\BinaryOp\Greater::class,
            Expr\BinaryOp\GreaterOrEqual::class,
            Expr\BinaryOp\Smaller::class,
            Expr\BinaryOp\SmallerOrEqual::class,
        ];
    }
}