Completed
Push — master ( d8f6c8...9bf369 )
by Дмитрий
10s
created

MethodCannotReturn   A

Complexity

Total Complexity 2

Size/Duplication

Total Lines 12
Duplicated Lines 0 %

Coupling/Cohesion

Components 0
Dependencies 0

Importance

Changes 1
Bugs 0 Features 1
Metric Value
c 1
b 0
f 1
dl 0
loc 12
rs 10
wmc 2
lcom 0
cbo 0
1
<?php
0 ignored issues
show
Coding Style Compatibility introduced by
For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 5 and the first side effect is on line 34.

The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file.

The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place.

To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1.

Loading history...
2
3
namespace Tests\Compiling\Statements;
4
5
class MethodCannotReturn
6
{
7
    public function __construct()
8
    {
9
        return 1;
10
    }
11
12
    public function __destruct()
13
    {
14
        return 1;
15
    }
16
}
17
18
class TestNoReturn
0 ignored issues
show
Coding Style Compatibility introduced by
PSR1 recommends that each class should be in its own file to aid autoloaders.

Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule.

Loading history...
19
{
20
	public $a;
21
22
	public function __construct()
23
	{
24
		$a = 1;
25
	}
26
27
	public function __destruct()
28
	{
29
		$a = 0;
30
	}
31
}
32
33
?>
34
----------------------------
35
[
36
    {
37
        "type":"return.construct",
38
        "message":"Method __construct cannot return a value.",
39
        "file":"MethodCannotReturn.php",
40
        "line":8
41
    },
42
    {
43
        "type":"return.construct",
44
        "message":"Method __destruct cannot return a value.",
45
        "file":"MethodCannotReturn.php",
46
        "line":13
47
    }
48
]
49