Completed
Pull Request — master (#240)
by Дмитрий
08:27
created

StupidUnaryOperators   A

Complexity

Total Complexity 3

Size/Duplication

Total Lines 35
Duplicated Lines 0 %

Coupling/Cohesion

Components 0
Dependencies 2

Test Coverage

Coverage 90.91%

Importance

Changes 1
Bugs 0 Features 0
Metric Value
dl 0
loc 35
ccs 10
cts 11
cp 0.9091
rs 10
c 1
b 0
f 0
wmc 3
lcom 0
cbo 2

2 Methods

Rating   Name   Duplication   Size   Complexity  
A getRegister() 0 6 1
A pass() 0 13 2
1
<?php
2
3
namespace PHPSA\Analyzer\Pass\Expression;
4
5
use PhpParser\Node\Expr;
6
use PHPSA\Analyzer\Helper\DefaultMetadataPassTrait;
7
use PHPSA\Analyzer\Pass\AnalyzerPassInterface;
8
use PHPSA\Context;
9
10
class StupidUnaryOperators implements AnalyzerPassInterface
11
{
12
    use DefaultMetadataPassTrait;
13
14
    const DESCRIPTION = 'Checks for use of UnaryPlus `+$a` and suggests to use an int or float cast instead.';
15
16
    /**
17
     * @param Expr $expr
18
     * @param Context $context
19
     * @return bool
20
     */
21 10
    public function pass(Expr $expr, Context $context)
22
    {
23 10
        if (get_class($expr->expr) != get_class($expr)) {
0 ignored issues
show
Bug introduced by
The property expr does not seem to exist in PhpParser\Node\Expr.

An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name.

If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading.

Loading history...
24 10
            $context->notice(
25 10
                'stupid_unary_operators',
26 10
                'Better to use type casting then unary plus.',
27
                $expr
28 10
            );
29 10
            return true;
30
        }
31
32
        return false;
33
    }
34
35
    /**
36
     * @return array
37
     */
38 1
    public function getRegister()
39
    {
40
        return [
41 1
            Expr\UnaryPlus::class,
42 1
        ];
43
    }
44
}
45