Completed
Pull Request — master (#345)
by Enrico
04:40
created

CompileCommand::execute()   C

Complexity

Conditions 11
Paths 24

Size

Total Lines 83
Code Lines 42

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 45
CRAP Score 11.1967

Importance

Changes 0
Metric Value
cc 11
eloc 42
nc 24
nop 2
dl 0
loc 83
ccs 45
cts 51
cp 0.8824
crap 11.1967
rs 5.2653
c 0
b 0
f 0

How to fix   Long Method    Complexity   

Long Method

Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.

For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.

Commonly applied refactorings include:

1
<?php
2
3
namespace PHPSA\Command;
4
5
use PhpParser\ParserFactory;
6
use PHPSA\Application;
7
use PHPSA\Compiler;
8
use PHPSA\Context;
9
use PHPSA\Definition\FileParser;
10
use RecursiveDirectoryIterator;
11
use RecursiveIteratorIterator;
12
use SplFileInfo;
13
use FilesystemIterator;
14
use Symfony\Component\Console\Input\InputArgument;
15
use Symfony\Component\Console\Input\InputInterface;
16
use Symfony\Component\Console\Input\InputOption;
17
use Symfony\Component\Console\Output\OutputInterface;
18
use Webiny\Component\EventManager\EventManager;
19
20
/**
21
 * Command to run compiler on files (no analyzer)
22
 */
23
class CompileCommand extends AbstractCommand
24
{
25
    /**
26
     * {@inheritdoc}
27
     */
28 296
    protected function configure()
29
    {
30 296
        $this
31 296
            ->setName('compile')
32 296
            ->setDescription('Runs compiler on all files in path')
33 296
            ->addOption('config-file', null, InputOption::VALUE_REQUIRED, 'Path to the configuration file.')
34 296
            ->addArgument('path', InputArgument::OPTIONAL, 'Path to check file or directory', '.');
35 296
    }
36
37
    /**
38
     * {@inheritdoc}
39
     */
40 1
    protected function execute(InputInterface $input, OutputInterface $output)
0 ignored issues
show
Complexity introduced by
This operation has 300 execution paths which exceeds the configured maximum of 200.

A high number of execution paths generally suggests many nested conditional statements and make the code less readible. This can usually be fixed by splitting the method into several smaller methods.

You can also find more information in the “Code” section of your repository.

Loading history...
41
    {
42 1
        $output->writeln('');
43
44 1
        if (extension_loaded('xdebug')) {
45
            /**
46
             * This will disable only showing stack traces on error conditions.
47
             */
48 1
            if (function_exists('xdebug_disable')) {
49 1
                xdebug_disable();
50 1
            }
51
52 1
            $output->writeln('<error>It is highly recommended to disable the XDebug extension before invoking this command.</error>');
53 1
        }
54
55
        /** @var Application $application */
56 1
        $application = $this->getApplication();
57 1
        $application->compiler = new Compiler();
58
59 1
        $configFile = $input->getOption('config-file') ?: '.phpsa.yml';
60 1
        $configDir = realpath($input->getArgument('path'));
61 1
        $application->configuration = $this->loadConfiguration($configFile, $configDir);
62
63 1
        $parser = $this->createParser($application);
0 ignored issues
show
Documentation introduced by
$application is of type object<PHPSA\Application>, but the function expects a string.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
64
65 1
        $output->writeln('Used config file: ' . $application->configuration->getPath());
66
67 1
        $em = EventManager::getInstance();
0 ignored issues
show
Comprehensibility introduced by
Avoid variables with short names like $em. Configured minimum length is 3.

Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum.

Loading history...
68 1
        $context = new Context($output, $application, $em);
69
70 1
        $fileParser = new FileParser(
71 1
            $parser,
72 1
            $application->compiler
73 1
        );
74
75 1
        $path = $input->getArgument('path');
76 1
        if (is_dir($path)) {
77 1
            $directoryIterator = new RecursiveIteratorIterator(
78 1
                new RecursiveDirectoryIterator($path, FilesystemIterator::SKIP_DOTS)
79 1
            );
80 1
            $output->writeln('Scanning directory <info>' . $path . '</info>');
81
82 1
            $count = 0;
83
84
            /** @var SplFileInfo $file */
85 1
            foreach ($directoryIterator as $file) {
86 1
                if ($file->getExtension() !== 'php') {
87
                    continue;
88
                }
89
90 1
                $context->debug($file->getPathname());
91 1
                $count++;
92 1
            }
93
94 1
            $output->writeln("Found <info>{$count} files</info>");
95
96 1
            if ($count > 100) {
97
                $output->writeln('<comment>Caution: You are trying to scan a lot of files; this might be slow. For bigger libraries, consider setting up a dedicated platform or using ci.lowl.io.</comment>');
98
            }
99
100 1
            $output->writeln('');
101
102
            /** @var SplFileInfo $file */
103 1
            foreach ($directoryIterator as $file) {
104 1
                if ($file->getExtension() !== 'php') {
105
                    continue;
106
                }
107
108 1
                $fileParser->parserFile($file->getPathname(), $context);
109 1
            }
110 1
        } elseif (is_file($path)) {
111
            $fileParser->parserFile($path, $context);
112
        }
113
114
115
        /**
116
         * Step 2 Recursive check ...
117
         */
118 1
        $application->compiler->compile($context);
119
120 1
        $output->writeln('');
121 1
        $output->writeln('Memory usage: ' . $this->getMemoryUsage(false) . ' (peak: ' . $this->getMemoryUsage(true) . ') MB');
122 1
    }
123
}
124