PHPSA\Compiler\Expression\StaticCall::compile()

Complexity

Conditions	5
Paths	4

Size

Total Lines	35
Code Lines	21

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	9.0581

Importance

Changes

0

<?php
    protected function compile($expr, Context $context)
    {
        $expressionCompiler = $context->getExpressionCompiler();
        $leftCE = $expressionCompiler->compile($expr->class);

        if ($leftCE->isObject()) {
            $name = $expr->name;

            /** @var ClassDefinition $classDefinition */
            $classDefinition = $context->scope;
            if (!$classDefinition->hasMethod($name, true)) {

It seems like $name defined by $expr->name on line 31 can also be of type object<PhpParser\Node\Expr>; however, PHPSA\Definition\ClassDefinition::hasMethod() does only seem to accept string, maybe add an additional type check?

                $context->notice(
                    'undefined-scall',
                    sprintf('Static method %s() does not exist in %s scope', $name, $expr->class),
                    $expr
                );

                return new CompiledExpression();
            }

            $method = $classDefinition->getMethod($name, true);
            if ($expr->class->parts[0] !== 'parent' && !$method->isStatic()) {
                $context->notice(
                    'undefined-scall',
                    sprintf('Method %s() is not static but was called in a static way', $name),
                    $expr
                );
            }

            return new CompiledExpression();
        }

        $context->debug('Unknown static function call');
        return new CompiledExpression();
    }
}