Issues in StaticPropertyFetch.php - New Issues - Inspection of "Fix docblock bugs" - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a6da0a...4e29e6 )

by Дмитрий

created 2017-02-26 06:57 UTC

src/Compiler/Expression/StaticPropertyFetch.php (1 issue)

Labels

Bug 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * PHP Smart Analysis project 2015-2016
 *
 * @author Patsura Dmitry https://github.com/ovr <[email protected]>
 */

namespace PHPSA\Compiler\Expression;

use PHPSA\CompiledExpression;
use PHPSA\Context;
use PHPSA\Definition\ClassDefinition;

class StaticPropertyFetch extends AbstractExpressionCompiler
{
    protected $name = 'PhpParser\Node\Expr\StaticPropertyFetch';

    /**
     * {expr}::${expr};
     *
     * @param \PhpParser\Node\Expr\StaticPropertyFetch $expr
     * @param Context $context
     * @return CompiledExpression
     */
    protected function compile($expr, Context $context)
    {
        $expressionCompiler = $context->getExpressionCompiler();
        $leftCE = $expressionCompiler->compile($expr->class);

        if ($leftCE->isObject()) {
            $name = $expr->name;

            /** @var ClassDefinition $classDefinition */
            $classDefinition = $context->scope;
            if (!$classDefinition->hasProperty($name, true)) {
                $context->notice(
                    'language_error',
                    sprintf('Static property $%s does not exist in %s scope', $name, $expr->class),
                    $expr
                );

                return new CompiledExpression();
            }

            $property = $classDefinition->getPropertyStatement($name, true);
            if (!$property->isStatic()) {
                $context->notice(
                    'language_error',
                    sprintf('Property $%s is not static but was called in a static way', $name),
                    $expr
                );
            }

            return $expressionCompiler->compile($property);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
        }

        $context->debug('Unknown static property fetch', $expr);
        return new CompiledExpression();
    }
}


1			<?php
2			/**
3			* PHP Smart Analysis project 2015-2016
4			*
5			* @author Patsura Dmitry https://github.com/ovr <[email protected]>
6			*/
7
8			namespace PHPSA\Compiler\Expression;
9
10			use PHPSA\CompiledExpression;
11			use PHPSA\Context;
12			use PHPSA\Definition\ClassDefinition;
13
14			class StaticPropertyFetch extends AbstractExpressionCompiler
15			{
16			protected $name = 'PhpParser\Node\Expr\StaticPropertyFetch';
17
18			/**
19			* {expr}::${expr};
20			*
21			* @param \PhpParser\Node\Expr\StaticPropertyFetch $expr
22			* @param Context $context
23			* @return CompiledExpression
24			*/
25			protected function compile($expr, Context $context)
26			{
27			$expressionCompiler = $context->getExpressionCompiler();
28			$leftCE = $expressionCompiler->compile($expr->class);
29
30			if ($leftCE->isObject()) {
31			$name = $expr->name;
32
33			/** @var ClassDefinition $classDefinition */
34			$classDefinition = $context->scope;
35			if (!$classDefinition->hasProperty($name, true)) {
36			$context->notice(
37			'language_error',
38			sprintf('Static property $%s does not exist in %s scope', $name, $expr->class),
39			$expr
40			);
41
42			return new CompiledExpression();
43			}
44
45			$property = $classDefinition->getPropertyStatement($name, true);
46			if (!$property->isStatic()) {
47			$context->notice(
48			'language_error',
49			sprintf('Property $%s is not static but was called in a static way', $name),
50			$expr
51			);
52			}
53
54			return $expressionCompiler->compile($property);
			0 ignored issues – show Bug introduced 2017-02-23 17:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$property` defined by `$classDefinition->getPro...yStatement($name, true)` on line `45` can be `null`; however, `PHPSA\Compiler\Expression::compile()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
55			}
56
57			$context->debug('Unknown static property fetch', $expr);
58			return new CompiledExpression();
59			}
60			}
61

ovr / phpsa

Push — master ( a6da0a...4e29e6 )

src/Compiler/Expression/StaticPropertyFetch.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like