ConstantNaming::pass() - Code Metrics - Inspection of "Add ConstantNaming analyzer" - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#132)

by Enrico

created 2016-09-17 09:35 UTC

ConstantNaming::pass() A

↳ Parent: ConstantNaming

Complexity

Conditions	2
Paths	2

Size

Total Lines	13
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	8
c	1
b	0
f	0
nc	2
nop	2
dl	0
loc	13
ccs	8
cts	8
cp	1
crap	2
rs	9.4285

<?php

namespace PHPSA\Analyzer\Pass\Statement;

use PhpParser\Node\Stmt\ClassConst;
use PHPSA\Analyzer\Pass\AnalyzerPassInterface;
use PHPSA\Analyzer\Pass\ConfigurablePassInterface;
use PHPSA\Context;
use Symfony\Component\Config\Definition\Builder\TreeBuilder;

class ConstantNaming implements ConfigurablePassInterface, AnalyzerPassInterface
{

    /**
     * @param ClassConst $stmt
     * @param Context $context
     * @return bool
     */
    public function pass(ClassConst $stmt, Context $context)
    {
        if ($stmt->consts[0]->name != strtoupper($stmt->consts[0]->name)) {
            $context->notice(
                'constant.naming',
                'Constant names should be all uppercase.',
                $stmt
            );

            return true;
        }
        return false;
    }

    /**
     * @return TreeBuilder
     */
    public function getConfiguration()
    {
        $treeBuilder = new TreeBuilder();
        $treeBuilder->root('constant_naming')
            ->canBeDisabled()
        ;

        return $treeBuilder;
    }

    /**
     * @return array
     */
    public function getRegister()
    {
        return [
            \PhpParser\Node\Stmt\ClassConst::class
        ];
    }
}


1		<?php
2
3		namespace PHPSA\Analyzer\Pass\Statement;
4
5		use PhpParser\Node\Stmt\ClassConst;
6		use PHPSA\Analyzer\Pass\AnalyzerPassInterface;
7		use PHPSA\Analyzer\Pass\ConfigurablePassInterface;
8		use PHPSA\Context;
9		use Symfony\Component\Config\Definition\Builder\TreeBuilder;
10
11		class ConstantNaming implements ConfigurablePassInterface, AnalyzerPassInterface
12		{
13
14		/**
15		* @param ClassConst $stmt
16		* @param Context $context
17		* @return bool
18		*/
19	1	public function pass(ClassConst $stmt, Context $context)
20		{
21	1	if ($stmt->consts[0]->name != strtoupper($stmt->consts[0]->name)) {
22	1	$context->notice(
23	1	'constant.naming',
24	1	'Constant names should be all uppercase.',
25		$stmt
26	1	);
27
28	1	return true;
29		}
30	1	return false;
31		}
32
33		/**
34		* @return TreeBuilder
35		*/
36		public function getConfiguration()
37		{
38		$treeBuilder = new TreeBuilder();
39		$treeBuilder->root('constant_naming')
40		->canBeDisabled()
41		;
42
43		return $treeBuilder;
44		}
45
46		/**
47		* @return array
48		*/
49	1	public function getRegister()
50		{
51		return [
52		\PhpParser\Node\Stmt\ClassConst::class
53	1	];
54		}
55		}
56

ovr / phpsa

Pull Request — master (#132)

ConstantNaming::pass() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like