ClassDefintionTest::testSetGetHasForClassProperty() - Code Metrics - Inspection of "Merge pull request #88 from K-Phoen/fix-constant-e..." - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0b755b...d8f6c8 )

by Дмитрий

created 2016-09-09 14:40 UTC

testSetGetHasForClassProperty() A

↳ Parent: ClassDefintionTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	53
Code Lines	34

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
cc	1
eloc	34
c	1
b	1
f	0
nc	1
nop	0
dl	0
loc	53
rs	9.5797

How to fix Long Method

<?php

namespace Tests\PHPSA\Defintion;

use PhpParser\Node\Const_;
use PhpParser\Node\Scalar\String_;
use PhpParser\Node\Stmt\ClassConst;
use PHPSA\Definition\ClassDefinition;
use Tests\PHPSA\TestCase;

class ClassDefintionTest extends TestCase
{
    /**
     * @return ClassDefinition
     */
    protected function getSimpleInstance()
    {
        return new ClassDefinition('MyTestClass', 0);
    }

    public function testSimpleInstance()
    {
        $classDefinition = $this->getSimpleInstance();
        $this->assertSame('MyTestClass', $classDefinition->getName());
        $this->assertFalse($classDefinition->isCompiled());
    }

    public function testScopePointer()
    {
        $classDefinition = $this->getSimpleInstance();

        $pointer = $classDefinition->getPointer();
        $this->assertInstanceOf('PHPSA\ScopePointer', $pointer);
        $this->assertEquals($classDefinition, $pointer->getObject());
    }

    public function testSetGetHasForClassProperty()
    {
        $classDefinition = $this->getSimpleInstance();
        $this->assertFalse($classDefinition->hasProperty('test1'));
        $this->assertFalse($classDefinition->hasProperty('test2'));

        $property = new \PhpParser\Node\Stmt\Property(
            0,
            array(
                new \PhpParser\Node\Stmt\PropertyProperty(
                    'test1',
                    new \PhpParser\Node\Scalar\String_(
                        'test string'
                    )
                )
            )
        );
        $classDefinition->addProperty($property);

        $this->assertTrue($classDefinition->hasProperty('test1'));
        $this->assertFalse($classDefinition->hasProperty('test2'));

        $property = new \PhpParser\Node\Stmt\Property(
            0,
            array(
                new \PhpParser\Node\Stmt\PropertyProperty(
                    'test2',
                    new \PhpParser\Node\Scalar\String_(
                        'test string'
                    )
                )
            )
        );
        $classDefinition->addProperty($property);

        $this->assertTrue($classDefinition->hasProperty('test1'));
        $this->assertTrue($classDefinition->hasProperty('test2'));

        $property = new \PhpParser\Node\Stmt\Property(0, [
            new \PhpParser\Node\Stmt\PropertyProperty(
                'foo',
                new \PhpParser\Node\Scalar\String_('test string')
            ),
            new \PhpParser\Node\Stmt\PropertyProperty(
                'bar',
                new \PhpParser\Node\Scalar\String_('test string')
            )
        ]);
        $classDefinition->addProperty($property);

        $this->assertTrue($classDefinition->hasProperty('foo'));
        $this->assertTrue($classDefinition->hasProperty('bar'));
    }

    public function testMethodSetGet()
    {
        $classDefinition = $this->getSimpleInstance();
        $methodName = 'method1';
        $nonExistsMethodName = 'method2';

        $this->assertFalse($classDefinition->hasMethod($methodName));
        $this->assertFalse($classDefinition->hasMethod($nonExistsMethodName));

        $classDefinition->addMethod(
            new \PHPSA\Definition\ClassMethod(
                $methodName,
                new \PhpParser\Node\Stmt\ClassMethod(
                    $methodName
                ),
                0
            )
        );

        $this->assertTrue($classDefinition->hasMethod($methodName));
        $this->assertFalse($classDefinition->hasMethod($nonExistsMethodName));

        $method = $classDefinition->getMethod($methodName);
        $this->assertInstanceOf('PHPSA\Definition\ClassMethod', $method);
        $this->assertSame($methodName, $method->getName());

        return $classDefinition;
    }

    public function testHasConstWithNoParent()
    {
        $classDefinition = $this->getSimpleInstance();
        $classDefinition->addConst(new ClassConst([
            new Const_('FOO', new String_('bar'))
        ]));

        $this->assertTrue($classDefinition->hasConst('FOO'));
        $this->assertFalse($classDefinition->hasConst('BAR'));
    }

    public function testHasConstWithParent()
    {
        $parentClassDefinition = $this->getSimpleInstance();
        $classDefinition = $this->getSimpleInstance();

        $parentClassDefinition->addConst(new ClassConst([
            new Const_('BAR', new String_('baz'))
        ]));

        $classDefinition->setExtendsClassDefinition($parentClassDefinition);
        $classDefinition->addConst(new ClassConst([
            new Const_('FOO', new String_('bar'))
        ]));

        $this->assertTrue($classDefinition->hasConst('FOO'));
        $this->assertFalse($classDefinition->hasConst('BAR'));
        $this->assertTrue($classDefinition->hasConst('BAR', true));
    }
}


1			<?php
2
3			namespace Tests\PHPSA\Defintion;
4
5			use PhpParser\Node\Const_;
6			use PhpParser\Node\Scalar\String_;
7			use PhpParser\Node\Stmt\ClassConst;
8			use PHPSA\Definition\ClassDefinition;
9			use Tests\PHPSA\TestCase;
10
11			class ClassDefintionTest extends TestCase
12			{
13			/**
14			* @return ClassDefinition
15			*/
16			protected function getSimpleInstance()
17			{
18			return new ClassDefinition('MyTestClass', 0);
19			}
20
21			public function testSimpleInstance()
22			{
23			$classDefinition = $this->getSimpleInstance();
24			$this->assertSame('MyTestClass', $classDefinition->getName());
25			$this->assertFalse($classDefinition->isCompiled());
26			}
27
28			public function testScopePointer()
29			{
30			$classDefinition = $this->getSimpleInstance();
31
32			$pointer = $classDefinition->getPointer();
33			$this->assertInstanceOf('PHPSA\ScopePointer', $pointer);
34			$this->assertEquals($classDefinition, $pointer->getObject());
35			}
36
37			public function testSetGetHasForClassProperty()
38			{
39			$classDefinition = $this->getSimpleInstance();
40			$this->assertFalse($classDefinition->hasProperty('test1'));
41			$this->assertFalse($classDefinition->hasProperty('test2'));
42
43			$property = new \PhpParser\Node\Stmt\Property(
44			0,
45			array(
46			new \PhpParser\Node\Stmt\PropertyProperty(
47			'test1',
48			new \PhpParser\Node\Scalar\String_(
49			'test string'
50			)
51			)
52			)
53			);
54			$classDefinition->addProperty($property);
55
56			$this->assertTrue($classDefinition->hasProperty('test1'));
57			$this->assertFalse($classDefinition->hasProperty('test2'));
58
59			$property = new \PhpParser\Node\Stmt\Property(
60			0,
61			array(
62			new \PhpParser\Node\Stmt\PropertyProperty(
63			'test2',
64			new \PhpParser\Node\Scalar\String_(
65			'test string'
66			)
67			)
68			)
69			);
70			$classDefinition->addProperty($property);
71
72			$this->assertTrue($classDefinition->hasProperty('test1'));
73			$this->assertTrue($classDefinition->hasProperty('test2'));
74
75			$property = new \PhpParser\Node\Stmt\Property(0, [
76			new \PhpParser\Node\Stmt\PropertyProperty(
77			'foo',
78			new \PhpParser\Node\Scalar\String_('test string')
79			),
80			new \PhpParser\Node\Stmt\PropertyProperty(
81			'bar',
82			new \PhpParser\Node\Scalar\String_('test string')
83			)
84			]);
85			$classDefinition->addProperty($property);
86
87			$this->assertTrue($classDefinition->hasProperty('foo'));
88			$this->assertTrue($classDefinition->hasProperty('bar'));
89			}
90
91			public function testMethodSetGet()
92			{
93			$classDefinition = $this->getSimpleInstance();
94			$methodName = 'method1';
95			$nonExistsMethodName = 'method2';
96
97			$this->assertFalse($classDefinition->hasMethod($methodName));
98			$this->assertFalse($classDefinition->hasMethod($nonExistsMethodName));
99
100			$classDefinition->addMethod(
101			new \PHPSA\Definition\ClassMethod(
102			$methodName,
103			new \PhpParser\Node\Stmt\ClassMethod(
104			$methodName
105			),
106			0
107			)
108			);
109
110			$this->assertTrue($classDefinition->hasMethod($methodName));
111			$this->assertFalse($classDefinition->hasMethod($nonExistsMethodName));
112
113			$method = $classDefinition->getMethod($methodName);
114			$this->assertInstanceOf('PHPSA\Definition\ClassMethod', $method);
115			$this->assertSame($methodName, $method->getName());
116
117			return $classDefinition;
118			}
119
120			public function testHasConstWithNoParent()
121			{
122			$classDefinition = $this->getSimpleInstance();
123			$classDefinition->addConst(new ClassConst([
124			new Const_('FOO', new String_('bar'))
125			]));
126
127			$this->assertTrue($classDefinition->hasConst('FOO'));
128			$this->assertFalse($classDefinition->hasConst('BAR'));
129			}
130
131			public function testHasConstWithParent()
132			{
133			$parentClassDefinition = $this->getSimpleInstance();
134			$classDefinition = $this->getSimpleInstance();
135
136			$parentClassDefinition->addConst(new ClassConst([
137			new Const_('BAR', new String_('baz'))
138			]));
139
140			$classDefinition->setExtendsClassDefinition($parentClassDefinition);
141			$classDefinition->addConst(new ClassConst([
142			new Const_('FOO', new String_('bar'))
143			]));
144
145			$this->assertTrue($classDefinition->hasConst('FOO'));
146			$this->assertFalse($classDefinition->hasConst('BAR'));
147			$this->assertTrue($classDefinition->hasConst('BAR', true));
148			}
149			}
150

ovr / phpsa

Push — master ( 0b755b...d8f6c8 )

testSetGetHasForClassProperty() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like