ReturnVoid::pass() - Code Metrics - Inspection of "Add ReturnVoid analyzer" - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#290)

by Enrico

created 2016-12-29 11:38 UTC

ReturnVoid::pass() A

↳ Parent: ReturnVoid

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	2

Importance

Changes

Metric	Value
cc	2
eloc	8
nc	2
nop	2
dl	0
loc	12
ccs	8
cts	8
cp	1
crap	2
rs	9.4285
c	0
b	0
f	0

<?php

namespace PHPSA\Analyzer\Pass\Statement;

use PhpParser\Node\Stmt;
use PhpParser\Node;
use PhpParser\Node\Stmt\Return_;
use PHPSA\Analyzer\Helper\DefaultMetadataPassTrait;
use PHPSA\Analyzer\Pass;
use PHPSA\Context;

class ReturnVoid implements Pass\AnalyzerPassInterface
{
    use DefaultMetadataPassTrait;

    const DESCRIPTION = 'Checks for return void statements.';

    /**
     * @param $stmt
     * @param Context $context
     * @return bool
     */
    public function pass(Return_ $stmt, Context $context)
    {
        if ($stmt->expr === null) { // this is not the value null but "no value"
            $context->notice(
                'return.void',
                'You are trying to return void',
                $stmt
            );
            return true;
        }
        return false;
    }

    /**
     * @return array
     */
    public function getRegister()
    {
        return [
            Return_::class,
        ];
    }
}


1		<?php
2
3		namespace PHPSA\Analyzer\Pass\Statement;
4
5		use PhpParser\Node\Stmt;
6		use PhpParser\Node;
7		use PhpParser\Node\Stmt\Return_;
8		use PHPSA\Analyzer\Helper\DefaultMetadataPassTrait;
9		use PHPSA\Analyzer\Pass;
10		use PHPSA\Context;
11
12		class ReturnVoid implements Pass\AnalyzerPassInterface
13		{
14		use DefaultMetadataPassTrait;
15
16		const DESCRIPTION = 'Checks for return void statements.';
17
18		/**
19		* @param $stmt
20		* @param Context $context
21		* @return bool
22		*/
23	1	public function pass(Return_ $stmt, Context $context)
24		{
25	1	if ($stmt->expr === null) { // this is not the value null but "no value"
26	1	$context->notice(
27	1	'return.void',
28	1	'You are trying to return void',
29		$stmt
30	1	);
31	1	return true;
32		}
33	1	return false;
34		}
35
36		/**
37		* @return array
38		*/
39	2	public function getRegister()
40		{
41		return [
42	2	Return_::class,
43	2	];
44		}
45		}
46

ovr / phpsa

Pull Request — master (#290)

ReturnVoid::pass() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like