StaticPropertyFetch::compile() - Code Metrics - Inspection of "Compiler: include, backtick, yield, yield from" - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#209)

by Enrico

created 2016-10-07 18:36 UTC

StaticPropertyFetch::compile() B

↳ Parent: StaticPropertyFetch

Complexity

Conditions	4
Paths	4

Size

Total Lines	35
Code Lines	21

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
eloc	21
nc	4
nop	2
dl	0
loc	35
rs	8.5806
c	0
b	0
f	0

<?php
/**
 * PHP Smart Analysis project 2015-2016
 *
 * @author Patsura Dmitry https://github.com/ovr <[email protected]>
 */

namespace PHPSA\Compiler\Expression;

use PHPSA\CompiledExpression;
use PHPSA\Context;
use PHPSA\Definition\ClassDefinition;

class StaticPropertyFetch extends AbstractExpressionCompiler
{
    protected $name = 'PhpParser\Node\Expr\StaticPropertyFetch';

    /**
     * {expr}::${expr};
     *
     * @param \PhpParser\Node\Expr\StaticPropertyFetch $expr
     * @param Context $context
     * @return CompiledExpression
     */
    protected function compile($expr, Context $context)
    {
        $expressionCompiler = $context->getExpressionCompiler();
        $leftCE = $expressionCompiler->compile($expr->class);

        if ($leftCE->isObject()) {
            $name = $expr->name;

            /** @var ClassDefinition $classDefinition */
            $classDefinition = $context->scope;
            if (!$classDefinition->hasProperty($name, true)) {
                $context->notice(
                    'undefined-scall',
                    sprintf('Static property $%s does not exist in %s scope', $name, $expr->class),
                    $expr
                );

                return new CompiledExpression();
            }

            $property = $classDefinition->getPropertyStatement($name, true);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            if (!$property->isStatic()) {
                $context->notice(
                    'undefined-scall',
                    sprintf('Property $%s is not static but was called in a static way', $name),
                    $expr
                );
            }

            return $expressionCompiler->compile($property);
        }

        $context->debug('Unknown static property fetch', $expr);
        return new CompiledExpression();
    }
}


1			<?php
2			/**
3			* PHP Smart Analysis project 2015-2016
4			*
5			* @author Patsura Dmitry https://github.com/ovr <[email protected]>
6			*/
7
8			namespace PHPSA\Compiler\Expression;
9
10			use PHPSA\CompiledExpression;
11			use PHPSA\Context;
12			use PHPSA\Definition\ClassDefinition;
13
14			class StaticPropertyFetch extends AbstractExpressionCompiler
15			{
16			protected $name = 'PhpParser\Node\Expr\StaticPropertyFetch';
17
18			/**
19			* {expr}::${expr};
20			*
21			* @param \PhpParser\Node\Expr\StaticPropertyFetch $expr
22			* @param Context $context
23			* @return CompiledExpression
24			*/
25			protected function compile($expr, Context $context)
26			{
27			$expressionCompiler = $context->getExpressionCompiler();
28			$leftCE = $expressionCompiler->compile($expr->class);
29
30			if ($leftCE->isObject()) {
31			$name = $expr->name;
32
33			/** @var ClassDefinition $classDefinition */
34			$classDefinition = $context->scope;
35			if (!$classDefinition->hasProperty($name, true)) {
36			$context->notice(
37			'undefined-scall',
38			sprintf('Static property $%s does not exist in %s scope', $name, $expr->class),
39			$expr
40			);
41
42			return new CompiledExpression();
43			}
44
45			$property = $classDefinition->getPropertyStatement($name, true);
			0 ignored issues – show Bug introduced 2016-10-07 18:49 UTC by Report Bug Copy Issue Report It seems like `$name` defined by `$expr->name` on line `31` can also be of type `object<PhpParser\Node\Expr>`; however, `PHPSA\Definition\ClassDe...:getPropertyStatement()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
46			if (!$property->isStatic()) {
47			$context->notice(
48			'undefined-scall',
49			sprintf('Property $%s is not static but was called in a static way', $name),
50			$expr
51			);
52			}
53
54			return $expressionCompiler->compile($property);
55			}
56
57			$context->debug('Unknown static property fetch', $expr);
58			return new CompiledExpression();
59			}
60			}
61

ovr / phpsa

Pull Request — master (#209)

StaticPropertyFetch::compile() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like