IfTest::testIfElseIfCreatesVar() - Code Metrics - Inspection of "Add compiler events for case, elseif, else" - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#194)

by Enrico

created 2016-10-10 09:25 UTC

IfTest::testIfElseIfCreatesVar() B

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	25
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	14
c	1
b	0
f	0
nc	1
nop	0
dl	0
loc	25
rs	8.8571

<?php

namespace Tests\PHPSA\Compiler\Statement;

use PhpParser\Node;
use PHPSA\Variable;

class IfTest extends \Tests\PHPSA\TestCase
{
    /**
     * Tests if ($stmtTest = 2) creates the variable
     */
    public function testIfConditionCreatesVar()
    {
        $context = $this->getContext();

        $statement = new Node\Stmt\If_(
            new Node\Expr\Assign(
                new Node\Expr\Variable(
                    new Node\Name("stmtTest")
                ),
                $this->newScalarExpr(2)
            )
        );
        
        \PHPSA\nodeVisitorFactory($statement, $context);

        $variable = $context->getSymbol("stmtTest");

        parent::assertTrue($variable instanceof Variable);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * Tests if (1 == 1) { $stmtTest = 2; } creates the variable
     */
    public function testIfStatementCreatesVar()
    {
        $context = $this->getContext();

        $statement = new Node\Stmt\If_(
            new Node\Expr\BinaryOp\Equal($this->newScalarExpr(1), $this->newScalarExpr(1)),
            ["stmts" =>
                [new Node\Expr\Assign(
                    new Node\Expr\Variable(
                        new Node\Name("stmtTest")
                    ),
                    $this->newScalarExpr(2)
                )]
            ]
        );
        
        \PHPSA\nodeVisitorFactory($statement, $context);

        $variable = $context->getSymbol("stmtTest");

        parent::assertTrue($variable instanceof Variable);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }
}


1			<?php
2
3			namespace Tests\PHPSA\Compiler\Statement;
4
5			use PhpParser\Node;
6			use PHPSA\Variable;
7
8			class IfTest extends \Tests\PHPSA\TestCase
9			{
10			/**
11			* Tests if ($stmtTest = 2) creates the variable
12			*/
13			public function testIfConditionCreatesVar()
14			{
15			$context = $this->getContext();
16
17			$statement = new Node\Stmt\If_(
18			new Node\Expr\Assign(
19			new Node\Expr\Variable(
20			new Node\Name("stmtTest")
21			),
22			$this->newScalarExpr(2)
23			)
24			);
25
26			\PHPSA\nodeVisitorFactory($statement, $context);
27
28			$variable = $context->getSymbol("stmtTest");
29
30			parent::assertTrue($variable instanceof Variable);
			0 ignored issues – show Comprehensibility Bug introduced 2016-09-28 14:45 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`assertTrue()` instead of `testIfConditionCreatesVar()`). Are you sure this is correct? If so, you might want to change this to `$this->assertTrue()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
31			}
32
33			/**
34			* Tests if (1 == 1) { $stmtTest = 2; } creates the variable
35			*/
36			public function testIfStatementCreatesVar()
37			{
38			$context = $this->getContext();
39
40			$statement = new Node\Stmt\If_(
41			new Node\Expr\BinaryOp\Equal($this->newScalarExpr(1), $this->newScalarExpr(1)),
42			["stmts" =>
43			[new Node\Expr\Assign(
44			new Node\Expr\Variable(
45			new Node\Name("stmtTest")
46			),
47			$this->newScalarExpr(2)
48			)]
49			]
50			);
51
52			\PHPSA\nodeVisitorFactory($statement, $context);
53
54			$variable = $context->getSymbol("stmtTest");
55
56			parent::assertTrue($variable instanceof Variable);
			0 ignored issues – show Comprehensibility Bug introduced 2016-09-28 14:45 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`assertTrue()` instead of `testIfStatementCreatesVar()`). Are you sure this is correct? If so, you might want to change this to `$this->assertTrue()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
57			}
58			}
59

ovr / phpsa

Pull Request — master (#194)

IfTest::testIfElseIfCreatesVar() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like