Expression::compile() - Code Metrics - Inspection of "Refactor Expression class" - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#196)

by Enrico

created 2016-10-07 13:24 UTC

Expression::compile() C

↳ Parent: Expression

Complexity

Conditions	16
Paths	16

Size

Total Lines	70
Code Lines	42

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	37
CRAP Score	16.6949

Importance

Changes

Metric	Value
cc	16
eloc	42
nc	16
nop	1
dl	0
loc	70
ccs	37
cts	43
cp	0.8605
crap	16.6949
rs	5.5942
c	0
b	0
f	0

How to fix Long Method Complexity

<?php
/**
 * @author Patsura Dmitry https://github.com/ovr <[email protected]>
 */

namespace PHPSA\Compiler;

use InvalidArgumentException;
use phpDocumentor\Reflection\DocBlockFactory;
use PHPSA\Check;
use PHPSA\CompiledExpression;
use PHPSA\Compiler\Event\ExpressionBeforeCompile;
use PHPSA\Context;
use PhpParser\Node;
use PHPSA\Definition\ClassDefinition;
use PHPSA\Exception\RuntimeException;
use PHPSA\Variable;
use PHPSA\Compiler\Expression\AbstractExpressionCompiler;
use Webiny\Component\EventManager\EventManager;

class Expression

{
    /**
     * @var Context
     */
    protected $context;

    /**
     * @var EventManager
     */
    protected $eventManager;

    /**
     * @param Context $context
     */
    public function __construct(Context $context, EventManager $eventManager)
    {
        $this->context = $context;
        $this->eventManager = $eventManager;
    }

    /**
     * @param $expr
     * @return ExpressionCompilerInterface|AbstractExpressionCompiler
     */
    protected function factory($expr)
    {
        switch (get_class($expr)) {
            /**
             * Call(s)
             */
            case Node\Expr\MethodCall::class:
                return new Expression\MethodCall();
            case Node\Expr\FuncCall::class:
                return new Expression\FunctionCall();
            case Node\Expr\StaticCall::class:
                return new Expression\StaticCall();
            /**
             * Operators
             */
            case Node\Expr\New_::class:
                return new Expression\Operators\NewOp();
            case Node\Expr\Instanceof_::class:
                return new Expression\Operators\InstanceOfOp();
            /**
             * AssignOp
             */
            case Node\Expr\AssignOp\Pow::class:
                return new Expression\AssignOp\Pow();
            case Node\Expr\AssignOp\Plus::class:
                return new Expression\AssignOp\Plus();
            case Node\Expr\AssignOp\Minus::class:
                return new Expression\AssignOp\Minus();
            case Node\Expr\AssignOp\Mul::class:
                return new Expression\AssignOp\Mul();
            case Node\Expr\AssignOp\Div::class:
                return new Expression\AssignOp\Div();
            case Node\Expr\AssignOp\Mod::class:
                return new Expression\AssignOp\Mod();
            case Node\Expr\AssignOp\BitwiseOr::class:
                return new Expression\AssignOp\BitwiseOr();
            case Node\Expr\AssignOp\BitwiseAnd::class:
                return new Expression\AssignOp\BitwiseAnd();
            case Node\Expr\AssignOp\BitwiseXor::class:
                return new Expression\AssignOp\BitwiseXor();
            case Node\Expr\AssignOp\Concat::class:
                return new Expression\AssignOp\Concat();
            case Node\Expr\AssignOp\ShiftLeft::class:
                return new Expression\AssignOp\ShiftLeft();
            case Node\Expr\AssignOp\ShiftRight::class:
                return new Expression\AssignOp\ShiftRight();

            /**
             * BinaryOp
             */
            case Node\Expr\BinaryOp\Identical::class:
                return new Expression\BinaryOp\Identical();
            case Node\Expr\BinaryOp\Concat::class:
                return new Expression\Operators\Concat();
            case Node\Expr\BinaryOp\NotIdentical::class:
                return new Expression\BinaryOp\NotIdentical();
            case Node\Expr\BinaryOp\Equal::class:
                return new Expression\BinaryOp\Equal();
            case Node\Expr\BinaryOp\NotEqual::class:
                return new Expression\BinaryOp\NotEqual();
            case Node\Expr\BinaryOp\Spaceship::class:
                return new Expression\BinaryOp\SpaceShip();
            case Node\Expr\BinaryOp\Coalesce::class:
                return new Expression\BinaryOp\Coalesce();
                
            /**
             * @link http://php.net/manual/en/language.operators.increment.php
             */
            case Node\Expr\PostInc::class:
                return new Expression\Operators\PostInc();
            case Node\Expr\PostDec::class:
                return new Expression\Operators\PostDec();
            case Node\Expr\PreInc::class:
                return new Expression\Operators\PreInc();
            case Node\Expr\PreDec::class:
                return new Expression\Operators\PreDec();
            /**
             * Arithmetical
             */
            case Node\Expr\BinaryOp\Div::class:
                return new Expression\Operators\Arithmetical\Div();
            case Node\Expr\BinaryOp\Plus::class:
                return new Expression\Operators\Arithmetical\Plus();
            case Node\Expr\BinaryOp\Minus::class:
                return new Expression\Operators\Arithmetical\Minus();
            case Node\Expr\BinaryOp\Mul::class:
                return new Expression\Operators\Arithmetical\Mul();
            case Node\Expr\BinaryOp\Mod::class:
                return new Expression\Operators\Arithmetical\Mod();
            case Node\Expr\BinaryOp\Pow::class:
                return new Expression\Operators\Arithmetical\Pow();

            /**
             * Bitwise
             * @link http://php.net/manual/ru/language.operators.bitwise.php
             */
            case Node\Expr\BinaryOp\BitwiseOr::class:
                return new Expression\Operators\Bitwise\BitwiseOr();
            case Node\Expr\BinaryOp\BitwiseXor::class:
                return new Expression\Operators\Bitwise\BitwiseXor();
            case Node\Expr\BinaryOp\BitwiseAnd::class:
                return new Expression\Operators\Bitwise\BitwiseAnd();
            case Node\Expr\BinaryOp\ShiftRight::class:
                return new Expression\Operators\Bitwise\ShiftRight();
            case Node\Expr\BinaryOp\ShiftLeft::class:
                return new Expression\Operators\Bitwise\ShiftLeft();
            case Node\Expr\BitwiseNot::class:
                return new Expression\Operators\Bitwise\BitwiseNot();
            /**
             * Logical
             */
            case Node\Expr\BinaryOp\BooleanOr::class:
                return new Expression\Operators\Logical\BooleanOr();
            case Node\Expr\BinaryOp\BooleanAnd::class:
                return new Expression\Operators\Logical\BooleanAnd();
            case Node\Expr\BooleanNot::class:
                return new Expression\Operators\Logical\BooleanNot();
            case Node\Expr\BinaryOp\LogicalAnd::class:
                return new Expression\Operators\Logical\LogicalAnd();
            case Node\Expr\BinaryOp\LogicalOr::class:
                return new Expression\Operators\Logical\LogicalOr();
            case Node\Expr\BinaryOp\LogicalXor::class:
                return new Expression\Operators\Logical\LogicalXor();

            /**
             * Comparison
             */
            case Node\Expr\BinaryOp\Greater::class:
                return new Expression\Operators\Comparison\Greater();
            case Node\Expr\BinaryOp\GreaterOrEqual::class:
                return new Expression\Operators\Comparison\GreaterOrEqual();
            case Node\Expr\BinaryOp\Smaller::class:
                return new Expression\Operators\Comparison\Smaller();
            case Node\Expr\BinaryOp\SmallerOrEqual::class:
                return new Expression\Operators\Comparison\SmallerOrEqual();

            /**
             * Casts
             */
            case Node\Expr\Cast\Array_::class:
                return new Expression\Casts\ArrayCast();
            case Node\Expr\Cast\Bool_::class:
                return new Expression\Casts\BoolCast();
            case Node\Expr\Cast\Int_::class:
                return new Expression\Casts\IntCast();
            case Node\Expr\Cast\Double::class:
                return new Expression\Casts\DoubleCast();
            case Node\Expr\Cast\Object_::class:
                return new Expression\Casts\ObjectCast();
            case Node\Expr\Cast\String_::class:
                return new Expression\Casts\StringCast();
            case Node\Expr\Cast\Unset_::class:
                return new Expression\Casts\UnsetCast();


            /**
             * Other
             */
            case Node\Expr\Array_::class:
                return new Expression\ArrayOp();
            case Node\Expr\Assign::class:
                return new Expression\Assign();
            case Node\Expr\AssignRef::class:
                return new Expression\AssignRef();
            case Node\Expr\Closure::class:
                return new Expression\Closure();
            case Node\Expr\ConstFetch::class:
                return new Expression\ConstFetch();
            case Node\Expr\ClassConstFetch::class:
                return new Expression\ClassConstFetch();
            case Node\Expr\PropertyFetch::class:
                return new Expression\PropertyFetch();
            case Node\Expr\ArrayDimFetch::class:
                return new Expression\ArrayDimFetch();
            case Node\Expr\UnaryMinus::class:
                return new Expression\Operators\UnaryMinus();
            case Node\Expr\UnaryPlus::class:
                return new Expression\Operators\UnaryPlus();
            case Node\Expr\Exit_::class:
                return new Expression\ExitOp();
            case Node\Expr\Isset_::class:
                return new Expression\IssetOp();
            case Node\Expr\Print_::class:
                return new Expression\PrintOp();
            case Node\Expr\Empty_::class:
                return new Expression\EmptyOp();
            case Node\Expr\Eval_::class:
                return new Expression\EvalOp();
            case Node\Expr\ErrorSuppress::class:
                return new Expression\ErrorSuppress();
            case Node\Expr\Clone_::class:
                return new Expression\CloneOp();
            case Node\Expr\Ternary::class:
                return new Expression\Ternary();
            case Node\Expr\Variable::class:
                return new Expression\Variable();
        }

        return false;
    }

    /**
     * @param object|string $expr
     * @throws InvalidArgumentException when $expr is not string/object/null
     * @throws RuntimeException when compiler class does not return a CompiledExpression
     * @return CompiledExpression
     */
    public function compile($expr)

    {
        if (is_string($expr)) {
            return new CompiledExpression(CompiledExpression::STRING, $expr);
        }

        if (is_null($expr)) {
            return new CompiledExpression(CompiledExpression::NULL);
        }

        if (!is_object($expr)) {
            throw new InvalidArgumentException('$expr must be string/object/null');
        }

        $this->eventManager->fire(
            ExpressionBeforeCompile::EVENT_NAME,
            new ExpressionBeforeCompile(
                $expr,
                $this->context
            )
        );

        $className = get_class($expr);
        switch ($className) {
            case Node\Arg::class:
                /**
                 * @todo Better compile
                 */
                return $this->compile($expr->value);
            case Node\Stmt\Property::class:
                return $this->passProperty($expr);

            /**
             * Expressions
             */
            case Node\Name::class:
                return $this->getNodeName($expr);
            case Node\Name\FullyQualified::class:
                return $this->getFullyQualifiedNodeName($expr);

            /**
             * Simple Scalar(s)
             */
            case \PHPSA\Node\Scalar\Nil::class:
                return new CompiledExpression(CompiledExpression::NULL);
            case Node\Scalar\LNumber::class:
                return new CompiledExpression(CompiledExpression::INTEGER, $expr->value);
            case Node\Scalar\DNumber::class:
                return new CompiledExpression(CompiledExpression::DOUBLE, $expr->value);
            case Node\Scalar\String_::class:
                return new CompiledExpression(CompiledExpression::STRING, $expr->value);
            case \PHPSA\Node\Scalar\Boolean::class:
                return new CompiledExpression(CompiledExpression::BOOLEAN, $expr->value);
            case \PHPSA\Node\Scalar\Fake::class:
                return new CompiledExpression($expr->type, $expr->value);
        }

        $expressionCompiler = $this->factory($expr);
        if (!$expressionCompiler) {
            $this->context->debug("Expression compiler is not implemented for {$className}");
            return new CompiledExpression(CompiledExpression::UNIMPLEMENTED);
        }

        $result = $expressionCompiler->pass($expr, $this->context);
        if (!$result instanceof CompiledExpression) {
            throw new RuntimeException('Please return CompiledExpression from ' . get_class($expressionCompiler));
        }

        return $result;
    }

    /**
     * @todo Implement - needs to be a new analyzer for var docblock
     *
     * @param Node\Stmt\Property $st
     * @return CompiledExpression
     */
    public function passProperty(Node\Stmt\Property $st)

    {
        $docBlock = $st->getDocComment();
        if (!$docBlock) {
            return new CompiledExpression();
        }

        $phpdoc = DocBlockFactory::createInstance()->create($docBlock->getText());

        $varTags = $phpdoc->getTagsByName('var');
        if ($varTags) {

            /** @var \phpDocumentor\Reflection\DocBlock\Tag\VarTag $varTag */
            $varTag = current($varTags);

            $typeResolver = new \phpDocumentor\Reflection\TypeResolver();

            try {
                $type = $typeResolver->resolve($varTag->getType());
            } catch (\InvalidArgumentException $e) {
                return new CompiledExpression();
            }

            if ($type) {
                switch (get_class($type)) {
                    case \phpDocumentor\Reflection\Types\Object_::class:
                        return new CompiledExpression(
                            CompiledExpression::OBJECT
                        );
                    case \phpDocumentor\Reflection\Types\Integer::class:
                        return new CompiledExpression(
                            CompiledExpression::INTEGER
                        );
                    case \phpDocumentor\Reflection\Types\String_::class:
                        return new CompiledExpression(
                            CompiledExpression::STRING
                        );
                    case \phpDocumentor\Reflection\Types\Float_::class:
                        return new CompiledExpression(
                            CompiledExpression::DOUBLE
                        );
                    case \phpDocumentor\Reflection\Types\Null_::class:
                        return new CompiledExpression(
                            CompiledExpression::NULL
                        );
                    case \phpDocumentor\Reflection\Types\Boolean::class:
                        return new CompiledExpression(
                            CompiledExpression::BOOLEAN
                        );
                }
            }
        }

        return new CompiledExpression();
    }

    /**
     * @param Node\Expr\Variable $expr
     * @param mixed $value
     * @param int $type
     * @return CompiledExpression
     */
    public function declareVariable(Node\Expr\Variable $expr, $value = null, $type = CompiledExpression::UNKNOWN)
    {
        $variable = $this->context->getSymbol($expr->name);
        if (!$variable) {
            $variable = new Variable($expr->name, $value, $type, $this->context->getCurrentBranch());
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            $this->context->addVariable($variable);
        }

        return new CompiledExpression($variable->getType(), $variable->getValue(), $variable);
    }

    /**
     * @param Node\Name\FullyQualified $expr
     * @return CompiledExpression
     */
    public function getFullyQualifiedNodeName(Node\Name\FullyQualified $expr)
    {
        $this->context->debug('Unimplemented FullyQualified', $expr);

        return new CompiledExpression;
    }

    /**
     * @param Node\Name $expr
     * @return CompiledExpression
     */
    public function getNodeName(Node\Name $expr)
    {
        $nodeString = $expr->toString();
        if ($nodeString === 'null') {
            return new CompiledExpression(CompiledExpression::NULL);
        }

        if (in_array($nodeString, ['parent'], true)) {
            /** @var ClassDefinition $scope */
            $scope = $this->context->scope;
            assert($scope instanceof ClassDefinition);

            if ($scope->getExtendsClass()) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
                $definition = $scope->getExtendsClassDefinition();
                if ($definition) {
                    return new CompiledExpression(CompiledExpression::OBJECT, $definition);
                }
            } else {
                $this->context->notice(
                    'no-parent',
                    'Cannot access parent:: when current class scope has no parent',
                    $expr
                );
            }
        }

        if (in_array($nodeString, ['self', 'static'], true)) {
            return CompiledExpression::fromZvalValue($this->context->scope);
        }

        if (defined($nodeString)) {
            return CompiledExpression::fromZvalValue(constant($expr));
        }

        return new CompiledExpression(CompiledExpression::STRING, $expr->toString());
    }
}


1		<?php
2		/**
3		* @author Patsura Dmitry https://github.com/ovr <[email protected]>
4		*/
5
6		namespace PHPSA\Compiler;
7
8		use InvalidArgumentException;
9		use phpDocumentor\Reflection\DocBlockFactory;
10		use PHPSA\Check;
11		use PHPSA\CompiledExpression;
12		use PHPSA\Compiler\Event\ExpressionBeforeCompile;
13		use PHPSA\Context;
14		use PhpParser\Node;
15		use PHPSA\Definition\ClassDefinition;
16		use PHPSA\Exception\RuntimeException;
17		use PHPSA\Variable;
18		use PHPSA\Compiler\Expression\AbstractExpressionCompiler;
19		use Webiny\Component\EventManager\EventManager;
20
21		class Expression
		0 ignored issues – show Complexity introduced 2016-02-06 15:22 UTC by Report Bug Copy Issue Report This class has a complexity of 115 which exceeds the configured maximum of 50. The class complexity is the sum of the complexity of all methods. A very high value is usually an indication that your class does not follow the single reponsibility principle and does more than one job. Some resources for further reading: Single Reponsibility Principle Open/Closed Principle You can also find more detailed suggestions for refactoring in the “Code” section of your repository. Loading history...
22		{
23		/**
24		* @var Context
25		*/
26		protected $context;
27
28		/**
29		* @var EventManager
30		*/
31		protected $eventManager;
32
33		/**
34		* @param Context $context
35		*/
36	849	public function __construct(Context $context, EventManager $eventManager)
37		{
38	849	$this->context = $context;
39	849	$this->eventManager = $eventManager;
40	849	}
41
42		/**
43		* @param $expr
44		* @return ExpressionCompilerInterface\|AbstractExpressionCompiler
45		*/
46	839	protected function factory($expr)
47		{
48	839	switch (get_class($expr)) {
49		/**
50		* Call(s)
51		*/
52	839	case Node\Expr\MethodCall::class:
53		return new Expression\MethodCall();
54	839	case Node\Expr\FuncCall::class:
55	10	return new Expression\FunctionCall();
56	835	case Node\Expr\StaticCall::class:
57	1	return new Expression\StaticCall();
58		/**
59		* Operators
60		*/
61	834	case Node\Expr\New_::class:
62	2	return new Expression\Operators\NewOp();
63	834	case Node\Expr\Instanceof_::class:
64		return new Expression\Operators\InstanceOfOp();
65		/**
66		* AssignOp
67		*/
68	834	case Node\Expr\AssignOp\Pow::class:
69	21	return new Expression\AssignOp\Pow();
70	813	case Node\Expr\AssignOp\Plus::class:
71	17	return new Expression\AssignOp\Plus();
72	796	case Node\Expr\AssignOp\Minus::class:
73	20	return new Expression\AssignOp\Minus();
74	776	case Node\Expr\AssignOp\Mul::class:
75	20	return new Expression\AssignOp\Mul();
76	756	case Node\Expr\AssignOp\Div::class:
77	18	return new Expression\AssignOp\Div();
78	738	case Node\Expr\AssignOp\Mod::class:
79	11	return new Expression\AssignOp\Mod();
80	727	case Node\Expr\AssignOp\BitwiseOr::class:
81	12	return new Expression\AssignOp\BitwiseOr();
82	715	case Node\Expr\AssignOp\BitwiseAnd::class:
83	12	return new Expression\AssignOp\BitwiseAnd();
84	703	case Node\Expr\AssignOp\BitwiseXor::class:
85	12	return new Expression\AssignOp\BitwiseXor();
86	691	case Node\Expr\AssignOp\Concat::class:
87	14	return new Expression\AssignOp\Concat();
88	677	case Node\Expr\AssignOp\ShiftLeft::class:
89	12	return new Expression\AssignOp\ShiftLeft();
90	665	case Node\Expr\AssignOp\ShiftRight::class:
91	12	return new Expression\AssignOp\ShiftRight();
92
93		/**
94		* BinaryOp
95		*/
96	653	case Node\Expr\BinaryOp\Identical::class:
97	28	return new Expression\BinaryOp\Identical();
98	625	case Node\Expr\BinaryOp\Concat::class:
99	15	return new Expression\Operators\Concat();
100	611	case Node\Expr\BinaryOp\NotIdentical::class:
101	14	return new Expression\BinaryOp\NotIdentical();
102	597	case Node\Expr\BinaryOp\Equal::class:
103	42	return new Expression\BinaryOp\Equal();
104	568	case Node\Expr\BinaryOp\NotEqual::class:
105	17	return new Expression\BinaryOp\NotEqual();
106	551	case Node\Expr\BinaryOp\Spaceship::class:
107	11	return new Expression\BinaryOp\SpaceShip();
108	542	case Node\Expr\BinaryOp\Coalesce::class:
109	3	return new Expression\BinaryOp\Coalesce();
110
111		/**
112		* @link http://php.net/manual/en/language.operators.increment.php
113		*/
114	540	case Node\Expr\PostInc::class:
115	8	return new Expression\Operators\PostInc();
116	532	case Node\Expr\PostDec::class:
117	8	return new Expression\Operators\PostDec();
118	524	case Node\Expr\PreInc::class:
119	8	return new Expression\Operators\PreInc();
120	516	case Node\Expr\PreDec::class:
121	8	return new Expression\Operators\PreDec();
122		/**
123		* Arithmetical
124		*/
125	508	case Node\Expr\BinaryOp\Div::class:
126	37	return new Expression\Operators\Arithmetical\Div();
127	471	case Node\Expr\BinaryOp\Plus::class:
128	45	return new Expression\Operators\Arithmetical\Plus();
129	430	case Node\Expr\BinaryOp\Minus::class:
130	24	return new Expression\Operators\Arithmetical\Minus();
131	406	case Node\Expr\BinaryOp\Mul::class:
132	35	return new Expression\Operators\Arithmetical\Mul();
133	371	case Node\Expr\BinaryOp\Mod::class:
134	35	return new Expression\Operators\Arithmetical\Mod();
135	336	case Node\Expr\BinaryOp\Pow::class:
136	21	return new Expression\Operators\Arithmetical\Pow();
137
138		/**
139		* Bitwise
140		* @link http://php.net/manual/ru/language.operators.bitwise.php
141		*/
142	315	case Node\Expr\BinaryOp\BitwiseOr::class:
143	12	return new Expression\Operators\Bitwise\BitwiseOr();
144	303	case Node\Expr\BinaryOp\BitwiseXor::class:
145	12	return new Expression\Operators\Bitwise\BitwiseXor();
146	291	case Node\Expr\BinaryOp\BitwiseAnd::class:
147	12	return new Expression\Operators\Bitwise\BitwiseAnd();
148	279	case Node\Expr\BinaryOp\ShiftRight::class:
149	12	return new Expression\Operators\Bitwise\ShiftRight();
150	267	case Node\Expr\BinaryOp\ShiftLeft::class:
151	12	return new Expression\Operators\Bitwise\ShiftLeft();
152	255	case Node\Expr\BitwiseNot::class:
153	5	return new Expression\Operators\Bitwise\BitwiseNot();
154		/**
155		* Logical
156		*/
157	250	case Node\Expr\BinaryOp\BooleanOr::class:
158	17	return new Expression\Operators\Logical\BooleanOr();
159	235	case Node\Expr\BinaryOp\BooleanAnd::class:
160	15	return new Expression\Operators\Logical\BooleanAnd();
161	222	case Node\Expr\BooleanNot::class:
162	9	return new Expression\Operators\Logical\BooleanNot();
163	214	case Node\Expr\BinaryOp\LogicalAnd::class:
164	15	return new Expression\Operators\Logical\LogicalAnd();
165	201	case Node\Expr\BinaryOp\LogicalOr::class:
166	17	return new Expression\Operators\Logical\LogicalOr();
167	186	case Node\Expr\BinaryOp\LogicalXor::class:
168	17	return new Expression\Operators\Logical\LogicalXor();
169
170		/**
171		* Comparison
172		*/
173	171	case Node\Expr\BinaryOp\Greater::class:
174	12	return new Expression\Operators\Comparison\Greater();
175	159	case Node\Expr\BinaryOp\GreaterOrEqual::class:
176	12	return new Expression\Operators\Comparison\GreaterOrEqual();
177	147	case Node\Expr\BinaryOp\Smaller::class:
178	12	return new Expression\Operators\Comparison\Smaller();
179	135	case Node\Expr\BinaryOp\SmallerOrEqual::class:
180	12	return new Expression\Operators\Comparison\SmallerOrEqual();
181
182		/**
183		* Casts
184		*/
185	123	case Node\Expr\Cast\Array_::class:
186	3	return new Expression\Casts\ArrayCast();
187	122	case Node\Expr\Cast\Bool_::class:
188	8	return new Expression\Casts\BoolCast();
189	116	case Node\Expr\Cast\Int_::class:
190	8	return new Expression\Casts\IntCast();
191	110	case Node\Expr\Cast\Double::class:
192	8	return new Expression\Casts\DoubleCast();
193	104	case Node\Expr\Cast\Object_::class:
194	2	return new Expression\Casts\ObjectCast();
195	103	case Node\Expr\Cast\String_::class:
196	7	return new Expression\Casts\StringCast();
197	97	case Node\Expr\Cast\Unset_::class:
198	2	return new Expression\Casts\UnsetCast();
199
200
201		/**
202		* Other
203		*/
204	96	case Node\Expr\Array_::class:
205	36	return new Expression\ArrayOp();
206	68	case Node\Expr\Assign::class:
207	29	return new Expression\Assign();
208	50	case Node\Expr\AssignRef::class:
209	1	return new Expression\AssignRef();
210	50	case Node\Expr\Closure::class:
211		return new Expression\Closure();
212	50	case Node\Expr\ConstFetch::class:
213	7	return new Expression\ConstFetch();
214	47	case Node\Expr\ClassConstFetch::class:
215		return new Expression\ClassConstFetch();
216	47	case Node\Expr\PropertyFetch::class:
217		return new Expression\PropertyFetch();
218	47	case Node\Expr\ArrayDimFetch::class:
219		return new Expression\ArrayDimFetch();
220	47	case Node\Expr\UnaryMinus::class:
221	9	return new Expression\Operators\UnaryMinus();
222	38	case Node\Expr\UnaryPlus::class:
223	9	return new Expression\Operators\UnaryPlus();
224	29	case Node\Expr\Exit_::class:
225	1	return new Expression\ExitOp();
226	28	case Node\Expr\Isset_::class:
227	3	return new Expression\IssetOp();
228	25	case Node\Expr\Print_::class:
229	2	return new Expression\PrintOp();
230	24	case Node\Expr\Empty_::class:
231	5	return new Expression\EmptyOp();
232	19	case Node\Expr\Eval_::class:
233	2	return new Expression\EvalOp();
234	17	case Node\Expr\ErrorSuppress::class:
235	2	return new Expression\ErrorSuppress();
236	15	case Node\Expr\Clone_::class:
237	1	return new Expression\CloneOp();
238	14	case Node\Expr\Ternary::class:
239	2	return new Expression\Ternary();
240	12	case Node\Expr\Variable::class:
241	12	return new Expression\Variable();
242		}
243
244		return false;
245		}
246
247		/**
248		* @param object\|string $expr
249		* @throws InvalidArgumentException when $expr is not string/object/null
250		* @throws RuntimeException when compiler class does not return a CompiledExpression
251		* @return CompiledExpression
252		*/
253	849	public function compile($expr)
		0 ignored issues – show Complexity introduced 2016-02-06 15:22 UTC by Report Bug Copy Issue Report This operation has 320 execution paths which exceeds the configured maximum of 200. A high number of execution paths generally suggests many nested conditional statements and make the code less readible. This can usually be fixed by splitting the method into several smaller methods. You can also find more information in the “Code” section of your repository. Loading history...
254		{
255	849	if (is_string($expr)) {
256	16	return new CompiledExpression(CompiledExpression::STRING, $expr);
257		}
258
259	849	if (is_null($expr)) {
260	8	return new CompiledExpression(CompiledExpression::NULL);
261		}
262
263	849	if (!is_object($expr)) {
264		throw new InvalidArgumentException('$expr must be string/object/null');
265		}
266
267	849	$this->eventManager->fire(
268	849	ExpressionBeforeCompile::EVENT_NAME,
269	849	new ExpressionBeforeCompile(
270	849	$expr,
271	849	$this->context
272	849	)
273	849	);
274
275	849	$className = get_class($expr);
276		switch ($className) {
277	849	case Node\Arg::class:
278		/**
279		* @todo Better compile
280		*/
281	2	return $this->compile($expr->value);
282	849	case Node\Stmt\Property::class:
283		return $this->passProperty($expr);
284
285		/**
286		* Expressions
287		*/
288	849	case Node\Name::class:
289	27	return $this->getNodeName($expr);
290	849	case Node\Name\FullyQualified::class:
291		return $this->getFullyQualifiedNodeName($expr);
292
293		/**
294		* Simple Scalar(s)
295		*/
296	849	case \PHPSA\Node\Scalar\Nil::class:
297	25	return new CompiledExpression(CompiledExpression::NULL);
298	848	case Node\Scalar\LNumber::class:
299	512	return new CompiledExpression(CompiledExpression::INTEGER, $expr->value);
300	843	case Node\Scalar\DNumber::class:
301	212	return new CompiledExpression(CompiledExpression::DOUBLE, $expr->value);
302	842	case Node\Scalar\String_::class:
303	50	return new CompiledExpression(CompiledExpression::STRING, $expr->value);
304	841	case \PHPSA\Node\Scalar\Boolean::class:
305	241	return new CompiledExpression(CompiledExpression::BOOLEAN, $expr->value);
306	839	case \PHPSA\Node\Scalar\Fake::class:
307	79	return new CompiledExpression($expr->type, $expr->value);
308		}
309
310	839	$expressionCompiler = $this->factory($expr);
311	839	if (!$expressionCompiler) {
312		$this->context->debug("Expression compiler is not implemented for {$className}");
313		return new CompiledExpression(CompiledExpression::UNIMPLEMENTED);
314		}
315
316	839	$result = $expressionCompiler->pass($expr, $this->context);
317	839	if (!$result instanceof CompiledExpression) {
318		throw new RuntimeException('Please return CompiledExpression from ' . get_class($expressionCompiler));
319		}
320
321	839	return $result;
322		}
323
324		/**
325		* @todo Implement - needs to be a new analyzer for var docblock
326		*
327		* @param Node\Stmt\Property $st
328		* @return CompiledExpression
329		*/
330		public function passProperty(Node\Stmt\Property $st)
		0 ignored issues – show Comprehensibility introduced 2016-02-06 15:22 UTC by Report Bug Copy Issue Report Avoid variables with short names like $st. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
331		{
332		$docBlock = $st->getDocComment();
333		if (!$docBlock) {
334		return new CompiledExpression();
335		}
336
337		$phpdoc = DocBlockFactory::createInstance()->create($docBlock->getText());
338
339		$varTags = $phpdoc->getTagsByName('var');
340		if ($varTags) {
		0 ignored issues – show Bug Best Practice introduced 2016-05-08 22:00 UTC by Report Bug Copy Issue Report The expression `$varTags` of type `phpDocumentor\Reflection\DocBlock\Tag[]` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
341		/** @var \phpDocumentor\Reflection\DocBlock\Tag\VarTag $varTag */
342		$varTag = current($varTags);
343
344		$typeResolver = new \phpDocumentor\Reflection\TypeResolver();
345
346		try {
347		$type = $typeResolver->resolve($varTag->getType());
348		} catch (\InvalidArgumentException $e) {
349		return new CompiledExpression();
350		}
351
352		if ($type) {
353		switch (get_class($type)) {
354		case \phpDocumentor\Reflection\Types\Object_::class:
355		return new CompiledExpression(
356		CompiledExpression::OBJECT
357		);
358		case \phpDocumentor\Reflection\Types\Integer::class:
359		return new CompiledExpression(
360		CompiledExpression::INTEGER
361		);
362		case \phpDocumentor\Reflection\Types\String_::class:
363		return new CompiledExpression(
364		CompiledExpression::STRING
365		);
366		case \phpDocumentor\Reflection\Types\Float_::class:
367		return new CompiledExpression(
368		CompiledExpression::DOUBLE
369		);
370		case \phpDocumentor\Reflection\Types\Null_::class:
371		return new CompiledExpression(
372		CompiledExpression::NULL
373		);
374		case \phpDocumentor\Reflection\Types\Boolean::class:
375		return new CompiledExpression(
376		CompiledExpression::BOOLEAN
377		);
378		}
379		}
380		}
381
382		return new CompiledExpression();
383		}
384
385		/**
386		* @param Node\Expr\Variable $expr
387		* @param mixed $value
388		* @param int $type
389		* @return CompiledExpression
390		*/
391	1	public function declareVariable(Node\Expr\Variable $expr, $value = null, $type = CompiledExpression::UNKNOWN)
392		{
393	1	$variable = $this->context->getSymbol($expr->name);
394	1	if (!$variable) {
395	1	$variable = new Variable($expr->name, $value, $type, $this->context->getCurrentBranch());
		0 ignored issues – show Bug introduced 2016-10-03 13:50 UTC by Report Bug Copy Issue Report It seems like `$expr->name` can also be of type `object<PhpParser\Node\Expr>`; however, `PHPSA\Variable::__construct()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
396	1	$this->context->addVariable($variable);
397	1	}
398
399	1	return new CompiledExpression($variable->getType(), $variable->getValue(), $variable);
400		}
401
402		/**
403		* @param Node\Name\FullyQualified $expr
404		* @return CompiledExpression
405		*/
406		public function getFullyQualifiedNodeName(Node\Name\FullyQualified $expr)
407		{
408		$this->context->debug('Unimplemented FullyQualified', $expr);
409
410		return new CompiledExpression;
411		}
412
413		/**
414		* @param Node\Name $expr
415		* @return CompiledExpression
416		*/
417	27	public function getNodeName(Node\Name $expr)
418		{
419	27	$nodeString = $expr->toString();
420	27	if ($nodeString === 'null') {
421	1	return new CompiledExpression(CompiledExpression::NULL);
422		}
423
424	27	if (in_array($nodeString, ['parent'], true)) {
425		/** @var ClassDefinition $scope */
426		$scope = $this->context->scope;
427		assert($scope instanceof ClassDefinition);
428
429		if ($scope->getExtendsClass()) {
		0 ignored issues – show Bug Best Practice introduced 2016-01-18 21:09 UTC by Report Bug Copy Issue Report The expression `$scope->getExtendsClass()` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
430		$definition = $scope->getExtendsClassDefinition();
431		if ($definition) {
432		return new CompiledExpression(CompiledExpression::OBJECT, $definition);
433		}
434		} else {
435		$this->context->notice(
436		'no-parent',
437		'Cannot access parent:: when current class scope has no parent',
438		$expr
439		);
440		}
441		}
442
443	27	if (in_array($nodeString, ['self', 'static'], true)) {
444	1	return CompiledExpression::fromZvalValue($this->context->scope);
445		}
446
447	26	if (defined($nodeString)) {
448	7	return CompiledExpression::fromZvalValue(constant($expr));
449		}
450
451	23	return new CompiledExpression(CompiledExpression::STRING, $expr->toString());
452		}
453		}
454

ovr / phpsa

Pull Request — master (#196)

Expression::compile() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like