PropertyWithVar::pass() - Code Metrics - Inspection of "Add Property defined with var analyzer" - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#134)

by Enrico

created 2016-09-17 11:17 UTC

PropertyWithVar::pass() A

↳ Parent: PropertyWithVar

Complexity

Conditions	4
Paths	2

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	4

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	4
eloc	8
c	1
b	0
f	0
nc	2
nop	2
dl	0
loc	12
ccs	8
cts	8
cp	1
crap	4
rs	9.2

<?php

namespace PHPSA\Analyzer\Pass\Statement;

use PhpParser\Node\Stmt\Property;
use PhpParser\Node\Stmt\Class_;
use PHPSA\Analyzer\Pass\AnalyzerPassInterface;
use PHPSA\Analyzer\Pass\ConfigurablePassInterface;
use PHPSA\Context;
use Symfony\Component\Config\Definition\Builder\TreeBuilder;

class PropertyWithVar implements ConfigurablePassInterface, AnalyzerPassInterface
{
    /**
     * @param Property $stmt
     * @param Context $context
     * @return bool
     */
    public function pass(Property $stmt, Context $context)
    {
        if (!$stmt->isPrivate() && !$stmt->isProtected() && ($stmt->type & Class_::MODIFIER_PUBLIC) === 0) {
            $context->notice(
                'property.var',
                'Class property was defined with the deprecated var keyword. Use a visibility modifier instead',
                $stmt
            );
            return true;
        }
        return false;
    }

    /**
     * @return TreeBuilder
     */
    public function getConfiguration()
    {
        $treeBuilder = new TreeBuilder();
        $treeBuilder->root('property_with_var')
            ->canBeDisabled()
        ;

        return $treeBuilder;
    }

    /**
     * @return array
     */
    public function getRegister()
    {
        return [
            Property::class
        ];
    }
}


1		<?php
2
3		namespace PHPSA\Analyzer\Pass\Statement;
4
5		use PhpParser\Node\Stmt\Property;
6		use PhpParser\Node\Stmt\Class_;
7		use PHPSA\Analyzer\Pass\AnalyzerPassInterface;
8		use PHPSA\Analyzer\Pass\ConfigurablePassInterface;
9		use PHPSA\Context;
10		use Symfony\Component\Config\Definition\Builder\TreeBuilder;
11
12		class PropertyWithVar implements ConfigurablePassInterface, AnalyzerPassInterface
13		{
14		/**
15		* @param Property $stmt
16		* @param Context $context
17		* @return bool
18		*/
19	2	public function pass(Property $stmt, Context $context)
20		{
21	2	if (!$stmt->isPrivate() && !$stmt->isProtected() && ($stmt->type & Class_::MODIFIER_PUBLIC) === 0) {
22	1	$context->notice(
23	1	'property.var',
24	1	'Class property was defined with the deprecated var keyword. Use a visibility modifier instead',
25		$stmt
26	1	);
27	1	return true;
28		}
29	2	return false;
30		}
31
32		/**
33		* @return TreeBuilder
34		*/
35		public function getConfiguration()
36		{
37		$treeBuilder = new TreeBuilder();
38		$treeBuilder->root('property_with_var')
39		->canBeDisabled()
40		;
41
42		return $treeBuilder;
43		}
44
45		/**
46		* @return array
47		*/
48	1	public function getRegister()
49		{
50		return [
51		Property::class
52	1	];
53		}
54		}
55

ovr / phpsa

Pull Request — master (#134)

PropertyWithVar::pass() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like