FileParser::parserFile() - Code Metrics - Inspection of "[ControlFlowGraph] WIP" - ovr/phpsa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#293)

by Дмитрий

created 2017-01-07 12:35 UTC

FileParser::parserFile() B

↳ Parent: FileParser

Complexity

Conditions	4
Paths	17

Size

Total Lines	24
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	4.0119

Importance

Changes

Metric	Value
cc	4
eloc	15
nc	17
nop	2
dl	0
loc	24
rs	8.6845
c	0
b	0
f	0
ccs	10
cts	11
cp	0.9091
crap	4.0119

<?php
/**
 * @author Patsura Dmitry https://github.com/ovr <[email protected]>
 */

namespace PHPSA\Definition;
use PHPSA\Compiler;
use PHPSA\Context;
use RuntimeException;

class FileParser
{
    /**
     * @var \PhpParser\Parser
     */
    protected $parser;

    /**
     * @var \PhpParser\NodeTraverser
     */
    protected $nodeTraverser;

    /**
     * @var Compiler
     */
    protected $compiler;

    /**
     * @var \PHPSA\Compiler\DefinitionVisitor
     */
    protected $definitionVisitor;

    /**
     * @param \PhpParser\Parser $parser
     * @param Compiler $compiler
     */
    public function __construct(\PhpParser\Parser $parser, Compiler $compiler)
    {
        $this->nodeTraverser = new \PhpParser\NodeTraverser();
        $this->nodeTraverser->addVisitor(new \PhpParser\NodeVisitor\NameResolver);
        $this->nodeTraverser->addVisitor(
            $this->definitionVisitor = new \PHPSA\Compiler\DefinitionVisitor($compiler)
        );

        $this->parser = $parser;
        $this->compiler = $compiler;
    }

    /**
     * @param string $filepath
     * @param Context $context
     * @throws RuntimeException when filepath is not readable
     */
    public function parserFile($filepath, Context $context)
    {
        $context->setFilepath($filepath);

        try {
            if (!is_readable($filepath)) {
                throw new RuntimeException('File ' . $filepath . ' is not readable');
            }

            $context->debug('<comment>Precompile: ' . $filepath . '.</comment>');

            $code = file_get_contents($filepath);
            $astTree = $this->parser->parse($code);

            $this->definitionVisitor->setFilePath($filepath);
            $this->nodeTraverser->traverse($astTree);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

            $context->clear();
        } catch (\PhpParser\Error $e) {
            $context->syntaxError($e, $filepath);
        } catch (\Exception $e) {
            $context->output->writeln("<error>{$e->getMessage()}</error>");
        }
    }
}


1		<?php
2		/**
3		* @author Patsura Dmitry https://github.com/ovr <[email protected]>
4		*/
5
6		namespace PHPSA\Definition;
7		use PHPSA\Compiler;
8		use PHPSA\Context;
9		use RuntimeException;
10
11		class FileParser
12		{
13		/**
14		* @var \PhpParser\Parser
15		*/
16		protected $parser;
17
18		/**
19		* @var \PhpParser\NodeTraverser
20		*/
21		protected $nodeTraverser;
22
23		/**
24		* @var Compiler
25		*/
26		protected $compiler;
27
28		/**
29		* @var \PHPSA\Compiler\DefinitionVisitor
30		*/
31		protected $definitionVisitor;
32
33		/**
34		* @param \PhpParser\Parser $parser
35		* @param Compiler $compiler
36	51	*/
37		public function __construct(\PhpParser\Parser $parser, Compiler $compiler)
38	51	{
39	51	$this->nodeTraverser = new \PhpParser\NodeTraverser();
40		$this->nodeTraverser->addVisitor(new \PhpParser\NodeVisitor\NameResolver);
41	51	$this->nodeTraverser->addVisitor(
42	51	$this->definitionVisitor = new \PHPSA\Compiler\DefinitionVisitor($compiler)
43	51	);
44
45		$this->parser = $parser;
46		$this->compiler = $compiler;
47		}
48
49		/**
50	51	* @param string $filepath
51		* @param Context $context
52	51	* @throws RuntimeException when filepath is not readable
53		*/
54		public function parserFile($filepath, Context $context)
55	51	{
56		$context->setFilepath($filepath);
57
58		try {
59	51	if (!is_readable($filepath)) {
60		throw new RuntimeException('File ' . $filepath . ' is not readable');
61	51	}
62	51
63		$context->debug('<comment>Precompile: ' . $filepath . '.</comment>');
64	51
65		$code = file_get_contents($filepath);
66	51	$astTree = $this->parser->parse($code);
67	51
68		$this->definitionVisitor->setFilePath($filepath);
69		$this->nodeTraverser->traverse($astTree);
		0 ignored issues – show Bug introduced 2016-05-21 07:27 UTC by Report Bug Copy Issue Report It seems like `$astTree` defined by `$this->parser->parse($code)` on line `66` can also be of type `null`; however, `PhpParser\NodeTraverser::traverse()` does only seem to accept `array<integer,object<PhpParser\Node>>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
70
71		$context->clear();
72	51	} catch (\PhpParser\Error $e) {
73	51	$context->syntaxError($e, $filepath);
74		} catch (\Exception $e) {
75		$context->output->writeln("<error>{$e->getMessage()}</error>");
76		}
77	51	}
78		}
79

ovr / phpsa

Pull Request — master (#293)

FileParser::parserFile() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like