for testing and deploying your application
for finding and fixing issues
for empowering human code reviews
<?php
namespace PHPSA\Analyzer\Pass\Statement;
use PhpParser\Node;
use PhpParser\Node\Stmt\ClassMethod;
use PHPSA\Analyzer\Helper\DefaultMetadataPassTrait;
use PHPSA\Analyzer\Helper\ResolveExpressionTrait;
use PHPSA\Analyzer\Pass;
use PHPSA\Context;
class ReturnAndYieldInOneMethod implements Pass\AnalyzerPassInterface
{
const DESCRIPTION = 'Checks for using return and yield statements in a one method and discourages it.';
use DefaultMetadataPassTrait;
use ResolveExpressionTrait;
/**
* @param ClassMethod $func
* @param Context $context
* @return bool
*/
public function pass(ClassMethod $func, Context $context)
$stmts = $func->getStmts();
if ($stmts === null) {
return false;
}
$yieldExists = \PHPSA\generatorHasValue($this->findNode($stmts, Node\Expr\Yield_::class));
if (!$yieldExists) {
// YieldFrom is another expression
$yieldExists = \PHPSA\generatorHasValue($this->findNode($stmts, Node\Expr\YieldFrom::class));
if ($yieldExists && \PHPSA\generatorHasValue($this->findNode($stmts, Node\Stmt\Return_::class))) {
$context->notice('return_and_yield_in_one_method', 'Do not use return and yield in a one method', $func);
return true;
* @return array
public function getRegister()
return [
ClassMethod::class,
];
ovr /
phpsa
